ModifiersProject
ActivePublic

Watchers

  • This project does not have any watchers.

Details

Description

Modifier stack for meshes, curves, metaballs.

Developers:

Module Owners: @Campbell Barton (campbellbarton) @Sergey Sharybin (sergey) @Brecht Van Lommel (brecht)
Booleans: @Sergey Sharybin (sergey)

Recent Activity

Today

Sybren A. Stüvel (sybren) closed T55540: Add foreachMappedXXX equivalent API for evaluated meshes? as Resolved by committing rB8b9712faeb9c: Fix T55540 Add foreachMappedXXX equivalent API for evaluated meshes.
Wed, Jun 20, 10:05 AM · BF Blender: 2.8, Modifiers, Code Quest

Yesterday

Bastien Montagne (mont29) triaged T55540: Add foreachMappedXXX equivalent API for evaluated meshes? as Normal priority.
Tue, Jun 19, 7:11 PM · BF Blender: 2.8, Modifiers, Code Quest

Mon, Jun 18

Philipp Oeser (lichtwerk) triaged T55516: Mirror Modifier not Updating Correctly in Viewport as Normal priority.

Putting this on normal (so it doesnt appear untriaged...) because there is an issue [but only with old dependency graph...]

Mon, Jun 18, 1:25 PM · Modifiers, BF Blender
Philipp Oeser (lichtwerk) assigned T55516: Mirror Modifier not Updating Correctly in Viewport to Sergey Sharybin (sergey).

not an issue if you use the new dependency graph
(run blender from the commandline with the --enable-new-depsgraph option)

Mon, Jun 18, 11:42 AM · Modifiers, BF Blender

Sun, Jun 17

Ekin Ozturk (EO) created T55516: Mirror Modifier not Updating Correctly in Viewport.
Sun, Jun 17, 5:15 PM · Modifiers, BF Blender

Wed, May 30

omgold (omgold) added a comment to T54488: Mirror modifier and hair disconnect/reconnect not working together.

About the situation with subsurf and no 'use modfiier stack', not it is clearer to me. The reconnect in this case seems to work like this:

Wed, May 30, 7:00 PM · Modifiers, BF Blender

Tue, May 29

omgold (omgold) added a comment to T54488: Mirror modifier and hair disconnect/reconnect not working together.

@Philipp Oeser (lichtwerk) Yes, of course. Sorry in case I failed to follow the preferred procedures. No secret that I'm rather new around here.

Tue, May 29, 10:25 PM · Modifiers, BF Blender
Philipp Oeser (lichtwerk) added a comment to T54488: Mirror modifier and hair disconnect/reconnect not working together.

Hi @Brecht Van Lommel (brecht), @omgold (omgold), I've seen you discuss this on the mailinglist (and I understand reaching out here as for some reason this report seemed to slip under the radar)
But: why not continue here? This way others (including me) can follow and participate much better.
Sorry for the wall of text, but pasting from the mailinglist, so it doesnt get lost...

Tue, May 29, 11:27 AM · Modifiers, BF Blender

Mon, May 28

RobHue (RobHue) added a comment to T55219: Symmetrize and Mirror Modifier change the Normals on a Mesh.

sorry for the duplicate and thanks for the answer :)

Mon, May 28, 6:06 PM · Mesh Modeling, Modifiers, BF Blender
Philipp Oeser (lichtwerk) merged task T55219: Symmetrize and Mirror Modifier change the Normals on a Mesh into T53763: Mirror modifier AND mirror operator destroys custom normals.
Mon, May 28, 2:39 PM · Mesh Modeling, Modifiers, BF Blender
Philipp Oeser (lichtwerk) updated subscribers of T55219: Symmetrize and Mirror Modifier change the Normals on a Mesh.

Unfortunately operations that alter topology are not supporting Custom Split Normals:

Mon, May 28, 2:38 PM · Mesh Modeling, Modifiers, BF Blender
Brecht Van Lommel (brecht) triaged T54488: Mirror modifier and hair disconnect/reconnect not working together as Confirmed priority.

The problem here is that the "Use Modifier Stack" setting is not properly taken into account for these disconnect/reconnect operations.

Mon, May 28, 2:00 PM · Modifiers, BF Blender

Sun, May 27

RobHue (RobHue) created T55219: Symmetrize and Mirror Modifier change the Normals on a Mesh.
Sun, May 27, 5:12 AM · Mesh Modeling, Modifiers, BF Blender

Fri, May 25

Abdelhak SIDI ALI MEBAREK (abdelhaksam) added a comment to T55210: Subsurf modifier doesn't preview .

Thank you for the report. Currently we are aware of many issues in 2.8 and actively working to fix them. But since replying to reports takes time, we have decided to limit bug reports to module team members.

Fri, May 25, 5:13 PM · BF Blender: 2.8, Modifiers
LazyDodo (LazyDodo) closed T55210: Subsurf modifier doesn't preview as Invalid.

Thank you for the report. Currently we are aware of many issues in 2.8 and actively working to fix them. But since replying to reports takes time, we have decided to limit bug reports to module team members.

Fri, May 25, 5:12 PM · BF Blender: 2.8, Modifiers
Abdelhak SIDI ALI MEBAREK (abdelhaksam) created T55210: Subsurf modifier doesn't preview .
Fri, May 25, 5:10 PM · BF Blender: 2.8, Modifiers

May 16 2018

Sybren A. Stüvel (sybren) closed T55097: Mdef Modifier is ignoring Vgroup option in 2.8 as Resolved by committing rB6a4ba9133ce7: Fix T55097: Mesh Deformation modifier is ignoring Vgroup option.
May 16 2018, 3:19 PM · Modifiers, BF Blender: 2.8
Joshua Leung (aligorith) triaged T55097: Mdef Modifier is ignoring Vgroup option in 2.8 as High priority.
May 16 2018, 2:59 PM · Modifiers, BF Blender: 2.8

May 14 2018

Philipp Oeser (lichtwerk) closed D3239: Fix T54992: Lattice modifier on another Lattice object does not take the Influence vertexgroup into account.

commited rB69f2305415a2

May 14 2018, 2:18 PM · Modifiers

May 9 2018

Lukas Ziechmann (bl_cat) added a comment to T54992: “Lattice-modifier” on another “Lattice-object” does not take the vertex group into account..

@Philipp Oeser (lichtwerk) : your work here is really aprecciated - thanks again for taking the time to fix this issue so soon!

May 9 2018, 9:01 PM · Modifiers, BF Blender
Philipp Oeser (lichtwerk) closed T54992: “Lattice-modifier” on another “Lattice-object” does not take the vertex group into account. as Resolved by committing rB69f2305415a2: Fix T54992: Lattice modifier on another Lattice object does not take the….
May 9 2018, 3:04 PM · Modifiers, BF Blender
Philipp Oeser (lichtwerk) added a comment to T54992: “Lattice-modifier” on another “Lattice-object” does not take the vertex group into account..

@Lukas Ziechmann (bl_cat): note this isnt commited to master yet (want to check on an issue in 2.8 first so the merge would go smooth ...)
reg. T54397: surface deform is now ported as well, but changes can happen later as well [just need proper handling of 2.79 vs. 2.8], lets stick to that report and continue discussion there

May 9 2018, 12:28 PM · Modifiers, BF Blender

May 8 2018

Lukas Ziechmann (bl_cat) added a comment to T54992: “Lattice-modifier” on another “Lattice-object” does not take the vertex group into account..

*wow* - getting back from work to find the bug I reported yesterday to be already fixed for 2.79. Thank you so much @Philipp Oeser (lichtwerk)! Regarding my other bug report: T54397 , do you think I should CC a 2.8-developers directly as the surface-deform modifier isn't ported over to 2.8 yet or would that be considered annoying/ unhelpful? I don't know the policy here and I don't want to clutter their chat with unimportant messages. Thanks again for your time and effort!

May 8 2018, 9:01 PM · Modifiers, BF Blender
Bastien Montagne (mont29) accepted D3239: Fix T54992: Lattice modifier on another Lattice object does not take the Influence vertexgroup into account.

LGTM

May 8 2018, 2:05 PM · Modifiers
Philipp Oeser (lichtwerk) added inline comments to D3239: Fix T54992: Lattice modifier on another Lattice object does not take the Influence vertexgroup into account.
May 8 2018, 1:26 PM · Modifiers
Philipp Oeser (lichtwerk) updated the diff for D3239: Fix T54992: Lattice modifier on another Lattice object does not take the Influence vertexgroup into account.

missing NULL check

May 8 2018, 1:19 PM · Modifiers
Bastien Montagne (mont29) requested changes to D3239: Fix T54992: Lattice modifier on another Lattice object does not take the Influence vertexgroup into account.
May 8 2018, 11:42 AM · Modifiers
Philipp Oeser (lichtwerk) added a comment to T54992: “Lattice-modifier” on another “Lattice-object” does not take the vertex group into account..

lattice was already ported (see T54737), so this will need to go into 2.8 with minor tweaks separately

May 8 2018, 11:14 AM · Modifiers, BF Blender
Philipp Oeser (lichtwerk) updated subscribers of D3239: Fix T54992: Lattice modifier on another Lattice object does not take the Influence vertexgroup into account.

this probably wont merge into 2.8 cleanly [DerivedMesh → Mesh conversion], I guess I'll have to make another version for 2.8 as well [which should only be minimal massage].
CCing @Sybren A. Stüvel (sybren) , just so he knows...

May 8 2018, 11:12 AM · Modifiers
Philipp Oeser (lichtwerk) added a comment to T54992: “Lattice-modifier” on another “Lattice-object” does not take the vertex group into account..

D3239 should fix this

May 8 2018, 11:00 AM · Modifiers, BF Blender
Philipp Oeser (lichtwerk) added a comment to D3239: Fix T54992: Lattice modifier on another Lattice object does not take the Influence vertexgroup into account.

similar to rB9c95fd0a988fcd14f050098385e5461e2e51100d

May 8 2018, 10:59 AM · Modifiers
Philipp Oeser (lichtwerk) created D3239: Fix T54992: Lattice modifier on another Lattice object does not take the Influence vertexgroup into account.
May 8 2018, 10:58 AM · Modifiers
Philipp Oeser (lichtwerk) claimed T54992: “Lattice-modifier” on another “Lattice-object” does not take the vertex group into account..

Will have a look shortly

May 8 2018, 9:07 AM · Modifiers, BF Blender

May 7 2018

Lukas Ziechmann (bl_cat) created T54992: “Lattice-modifier” on another “Lattice-object” does not take the vertex group into account..
May 7 2018, 5:40 PM · Modifiers, BF Blender

May 4 2018

Philipp Oeser (lichtwerk) closed D3199: Fix T54341: Particle Instance Modifier doesn't preserve edge data.

commited rB288d7794d4c6

May 4 2018, 9:27 AM · Modifiers
Philipp Oeser (lichtwerk) closed T54341: Particle Instance doesn't preserve edge data as Resolved by committing rB288d7794d4c6: Fix T54341: Particle Instance Modifier doesn't preserve edge data.
May 4 2018, 9:24 AM · Modifiers, BF Blender
Campbell Barton (campbellbarton) accepted D3199: Fix T54341: Particle Instance Modifier doesn't preserve edge data.
May 4 2018, 9:08 AM · Modifiers

May 3 2018

Philipp Oeser (lichtwerk) added a comment to T54341: Particle Instance doesn't preserve edge data.

possible fix: D3199

May 3 2018, 10:58 PM · Modifiers, BF Blender
Philipp Oeser (lichtwerk) added a comment to D3199: Fix T54341: Particle Instance Modifier doesn't preserve edge data.

Just thought this could go in before this modifier gets ported in 2.8?

May 3 2018, 10:57 PM · Modifiers
Philipp Oeser (lichtwerk) created D3199: Fix T54341: Particle Instance Modifier doesn't preserve edge data.
May 3 2018, 10:56 PM · Modifiers
Sybren A. Stüvel (sybren) added a comment to T54341: Particle Instance doesn't preserve edge data.

I'll leave porting the Particle Instance modifier to @Philipp Oeser (lichtwerk) then ;-)

May 3 2018, 5:46 PM · Modifiers, BF Blender
Philipp Oeser (lichtwerk) updated subscribers of T54341: Particle Instance doesn't preserve edge data.

@Sergey Sharybin (sergey): got it working, will post patch tomorrow (just saying, so @Sybren A. Stüvel (sybren) is not porting this modifier over in 2.8 before we merge?)

May 3 2018, 3:56 PM · Modifiers, BF Blender

Apr 30 2018

Philipp Oeser (lichtwerk) claimed T54872: Skin modifier produces headless bone.

We are talking about the very first bone here, right (the one marked as 'root')?
Confirming on first sight.

Apr 30 2018, 11:37 AM · Modifiers, BF Blender

Apr 28 2018

Serge Lyatin (SergeL) created T54872: Skin modifier produces headless bone.
Apr 28 2018, 2:27 PM · Modifiers, BF Blender

Apr 27 2018

Sergey Sharybin (sergey) closed T53251: Armature modifier on hidden objects as Archived.

Depsgraph indeed only takes layers into account. This way it's cheap to see if some object from hidden layer affects something currently visible. In Blender 2.8 we are switching to collections visibility instead of object visibility. This part is still being worked on, so need some work to make depsgraph aware of that once rest of design is locked down.

Apr 27 2018, 1:31 PM · Modifiers, Animation, BF Blender
Philipp Oeser (lichtwerk) assigned T53251: Armature modifier on hidden objects to Sergey Sharybin (sergey).

At a quick glance at the code, dependency graph is only aware of layers, not object visibilities at all.
This is not limited to the Armature modifier, seems all modifiers evaluated (e.g. on frame change)
(Above difference in fps between visible vs. hidden is probably drawing code etc, not modifier evaluation).
So in that case, I would think this is a (somewhat known) limitation to the depsgraph?

Apr 27 2018, 1:02 PM · Modifiers, Animation, BF Blender
Philipp Oeser (lichtwerk) added a comment to T53251: Armature modifier on hidden objects.

While it is very well possible that hidden objects need to be evaluated (think of something shrinkwrapped to a hidden deformed object - you would want the deformations to be evaluated), it doesnt have to be so (agree, it would make sense to skip evaluation in that case).

Apr 27 2018, 10:56 AM · Modifiers, Animation, BF Blender

Apr 20 2018

Sergey Sharybin (sergey) added a comment to T54341: Particle Instance doesn't preserve edge data.

@Philipp Oeser (lichtwerk), this is something what we should support indeed. Mind looking into this? Shouldn't be hard to add support :)

Apr 20 2018, 1:41 PM · Modifiers, BF Blender
Philipp Oeser (lichtwerk) changed Type from Bug to To Do on T54341: Particle Instance doesn't preserve edge data.
Apr 20 2018, 1:04 PM · Modifiers, BF Blender
Philipp Oeser (lichtwerk) claimed T54341: Particle Instance doesn't preserve edge data.

This is a limitation to the current Particle Instance modifier (not a bug though).

Apr 20 2018, 1:04 PM · Modifiers, BF Blender