ModifiersProject
ActivePublic

Watchers

  • This project does not have any watchers.

Details

Description

Modifier stack for meshes, curves, metaballs.

Developers:

Module Owners: @Campbell Barton (campbellbarton) @Sergey Sharybin (sergey) @Brecht Van Lommel (brecht)
Booleans: @Sergey Sharybin (sergey)

Recent Activity

Fri, Apr 20

Sergey Sharybin (sergey) added a comment to T54341: Particle Instance doesn't preserve edge data.

@Philipp Oeser (lichtwerk), this is something what we should support indeed. Mind looking into this? Shouldn't be hard to add support :)

Fri, Apr 20, 1:41 PM · Modifiers, BF Blender
Philipp Oeser (lichtwerk) changed Type from Bug to To Do on T54341: Particle Instance doesn't preserve edge data.
Fri, Apr 20, 1:04 PM · Modifiers, BF Blender
Philipp Oeser (lichtwerk) claimed T54341: Particle Instance doesn't preserve edge data.

This is a limitation to the current Particle Instance modifier (not a bug though).

Fri, Apr 20, 1:04 PM · Modifiers, BF Blender

Wed, Apr 18

Philipp Oeser (lichtwerk) assigned T54397: “Surface Deform”-modifier is overwriting the whole modifier stack to Luca Rood (LucaRood).

Hi there,

Wed, Apr 18, 11:52 AM · Modifiers, BF Blender

Mon, Apr 9

Julian Eisel (Severin) changed the status of T45197: long scrolled areas do not revert when switching objects from Invalid to Resolved by committing rB7213553c84a3: UI: Clamp scrollbar offset to lower view boundaries.
Mon, Apr 9, 6:57 PM · User Interface, Modifiers, BF Blender
Philipp Oeser (lichtwerk) claimed T54526: Data Transfer modifier's Max Distance field working strangely.

I'll claim for the time being and do some further investiagtion. If that doesnt succeed, I'll get @Bastien Montagne (mont29) on board to help me out...

Mon, Apr 9, 10:16 AM · Modifiers

Thu, Apr 5

Philipp Oeser (lichtwerk) triaged T54526: Data Transfer modifier's Max Distance field working strangely as Confirmed priority.

Confirming on first sight, having a closer look now...

Thu, Apr 5, 10:41 AM · Modifiers

Wed, Apr 4

Nathan Vasil (vasiln) created T54526: Data Transfer modifier's Max Distance field working strangely.
Wed, Apr 4, 5:29 PM · Modifiers

Sun, Apr 1

omgold (omgold) created T54488: Mirror modifier and hair disconnect/reconnect not working together.
Sun, Apr 1, 10:12 PM · Modifiers, BF Blender

Tue, Mar 27

Campbell Barton (campbellbarton) added a comment to T54024: BMesh boolean fails when edge is co-planar to face (under some circumstances).

The plan is to improve bmesh boolean to support overlap.

Tue, Mar 27, 11:15 AM · Mesh Modeling, Modifiers, BF Blender
mathieu menuet (bliblubli) added a comment to T54024: BMesh boolean fails when edge is co-planar to face (under some circumstances).

Addons relying on carve modifier are not working in master like this one https://blenderartists.org/forum/showthread.php?409837-Destructive-Extrude-BETA/page9 and the results of bmesh are not yet there in some cases (like overlapping/coplanar edges/faces).
I think it was a very good idea to keep only one version of the boolean modifier and bmesh is really fast, but it should offer as much as the old combination. Or is the plan to only remove functionality in this case?

Tue, Mar 27, 11:10 AM · Mesh Modeling, Modifiers, BF Blender

Mar 24 2018

Rob Dodd (RobD) added a comment to T54342: Skin modifier crashes Blender.

(Disclaimer: I'm completely new to Blender dev, and I randomly picked this bug to have a look at to try to figure out the code. I've *think* I've tracked it to a certain point, described below, but please use caution when trusting what I say...)

Mar 24 2018, 1:54 PM · Modifiers, BF Blender

Mar 22 2018

Lukas Ziechmann (bl_cat) added a comment to T54397: “Surface Deform”-modifier is overwriting the whole modifier stack.

Just saw that "Shapekeys" of a target mesh have no effect in combination with the "Surface Deform"-modifier as well. This modifier really seems to overwrite any other transforms..

Mar 22 2018, 7:13 PM · Modifiers, BF Blender
Lukas Ziechmann (bl_cat) added a comment to T54397: “Surface Deform”-modifier is overwriting the whole modifier stack.


the attached file seems to be missing - sorry if I double-post it..

Mar 22 2018, 5:18 PM · Modifiers, BF Blender
Lukas Ziechmann (bl_cat) created T54397: “Surface Deform”-modifier is overwriting the whole modifier stack.
Mar 22 2018, 4:42 PM · Modifiers, BF Blender

Mar 18 2018

Christopher Anderssarian (Christopher_Anderssarian) added a project to T54331: Array modifier doesn't allow snapping in edit mode to generated clones: Modifiers.
Mar 18 2018, 2:17 PM · Modifiers, BF Blender

Mar 16 2018

Felix (BlenderSpot) updated the task description for T54342: Skin modifier crashes Blender.
Mar 16 2018, 10:15 PM · Modifiers, BF Blender
Felix (BlenderSpot) updated the task description for T54342: Skin modifier crashes Blender.
Mar 16 2018, 10:11 PM · Modifiers, BF Blender
LazyDodo (LazyDodo) triaged T54342: Skin modifier crashes Blender as Confirmed priority.

can confirm the issue on latest master.

Mar 16 2018, 10:05 PM · Modifiers, BF Blender
Felix (BlenderSpot) created T54342: Skin modifier crashes Blender.
Mar 16 2018, 9:59 PM · Modifiers, BF Blender
Serge Lyatin (SergeL) created T54341: Particle Instance doesn't preserve edge data.
Mar 16 2018, 9:11 PM · Modifiers, BF Blender

Mar 8 2018

Campbell Barton (campbellbarton) added a parent task for T47129: new Bmesh boolean is deleting some of edges data, (Creases and Bweigh): T47030: BMesh booleans (track todo's).
Mar 8 2018, 4:22 AM · Modifiers, BF Blender
Adrian Rutkowski (rrtk) added a comment to T47129: new Bmesh boolean is deleting some of edges data, (Creases and Bweigh).

since that was not mentioned,
creases disappear as well

Mar 8 2018, 2:36 AM · Modifiers, BF Blender
LazyDodo (LazyDodo) raised the priority of T47129: new Bmesh boolean is deleting some of edges data, (Creases and Bweigh) from Normal to Confirmed.

can confirm the weights disappear

Mar 8 2018, 2:30 AM · Modifiers, BF Blender

Mar 7 2018

LazyDodo (LazyDodo) raised the priority of T47129: new Bmesh boolean is deleting some of edges data, (Creases and Bweigh) from Incomplete to Normal.
Mar 7 2018, 11:06 PM · Modifiers, BF Blender
Cirno (Cirno) added a comment to T47129: new Bmesh boolean is deleting some of edges data, (Creases and Bweigh).

If you apply boolean then bevel weight disappear. I tested it on blender-2.79-737a5ef-win64-vc14

Mar 7 2018, 10:50 PM · Modifiers, BF Blender
LazyDodo (LazyDodo) lowered the priority of T47129: new Bmesh boolean is deleting some of edges data, (Creases and Bweigh) from Normal to Incomplete.

please attach a sample file (.blend file, not a video) showing the issue

Mar 7 2018, 10:40 PM · Modifiers, BF Blender
Cirno (Cirno) added a comment to T47129: new Bmesh boolean is deleting some of edges data, (Creases and Bweigh).

Bevel weight still not preserved after bmesh boolean. This is especially annoying after removing carve solver, which previously can be used instead

Mar 7 2018, 10:20 PM · Modifiers, BF Blender

Mar 6 2018

Campbell Barton (campbellbarton) abandoned D3092: Array modifier: Do not merge vertex groups with different names.

Committed rBd9d3ed16a8c61bb1c780d81a2cf398be92cd16c1

Mar 6 2018, 12:11 AM · Modifiers
Campbell Barton (campbellbarton) accepted D3092: Array modifier: Do not merge vertex groups with different names.
Mar 6 2018, 12:11 AM · Modifiers
Campbell Barton (campbellbarton) closed T53206: Unexpected merging of vertex groups with different names as Resolved by committing rBd9d3ed16a8c6: Fix T53206: Array modifier doesn't merge vgroups.
Mar 6 2018, 12:10 AM · Mesh Modeling, Modifiers, BF Blender

Mar 5 2018

Philip Holzmann (Foaly) updated the diff for D3092: Array modifier: Do not merge vertex groups with different names.

BKE_object_defgroup_index_map_apply now removes all weights with invalid def_nr.
If totweight is zero, it will be freed.

Mar 5 2018, 4:37 PM · Modifiers
Campbell Barton (campbellbarton) added a comment to D3092: Array modifier: Do not merge vertex groups with different names.

@Philip Holzmann (Foaly) - there is no need to remove them. Just keep the weights that are out of bounds, this is how booleans and object join already work.

Mar 5 2018, 8:58 AM · Modifiers
Philip Holzmann (Foaly) added a comment to D3092: Array modifier: Do not merge vertex groups with different names.

@Campbell Barton (campbellbarton) I'm not sure how to do that then.
If we want to keep vertex groups that are out of range, there are different possibilities:

  • Map all invalid indices to -1: That could result in a vertex having multiple MDeformWeights with the same def_nr. Also, I don't know if these weights can ever be accessed again.
  • Keep all invalid indices: Weights that do not have a mapping to a vertex group in the new mesh keep their def_nr. This means some vertex groups might be merged.
  • Keep invalid indices only if they are out of range: Weights that do not have a mapping and are >= totweight are kept. This should not cause problems. But it has to be decided what to do with the weights with valid indices but no mapping, so they don't merge. (Move above totweight or map to -1?)
Mar 5 2018, 8:45 AM · Modifiers
Campbell Barton (campbellbarton) added a comment to D3092: Array modifier: Do not merge vertex groups with different names.

@Philip Holzmann (Foaly), for now it might be simplest to use old behavior (don't throw away groups which are out of range).
Changes to behavior can backfire so it's sometimes best not to mix them into more general refactoring.

Mar 5 2018, 3:55 AM · Modifiers

Mar 4 2018

Philip Holzmann (Foaly) added a comment to D3092: Array modifier: Do not merge vertex groups with different names.

Demonstration File to show that def_nr can be out of bounds, created with Boolean Modifier "Union" in 2.79:


Add a vertex group to the object and go into edit mode. Click "Select" to see the vertices assigned to the group. The right cube will be selected.

Mar 4 2018, 7:49 PM · Modifiers
Bastien Montagne (mont29) requested changes to D3092: Array modifier: Do not merge vertex groups with different names.

@Campbell Barton (campbellbarton) I guess by clamping you mean the removal of 'invalid' vgroups? I think it’s fine to completely nuke them, I would really not like users relying on such a bad nasty dirty hack to do anything! But as pointed in comments below, I think there is something odd/inconsistent in proposed code regarding this, anyway…

Mar 4 2018, 6:50 PM · Modifiers

Mar 3 2018

mathieu menuet (bliblubli) added a comment to T54024: BMesh boolean fails when edge is co-planar to face (under some circumstances).

@Campbell Barton (campbellbarton) As Carve boolean has been removed, would it be possible to finalize Bmesh version? Before user could use the other one as fallback, but now we have to use Bmesh. I'm happy to have only one variant if it's robust enough.

Mar 3 2018, 5:09 PM · Mesh Modeling, Modifiers, BF Blender
Philip Holzmann (Foaly) updated the diff for D3092: Array modifier: Do not merge vertex groups with different names.

MEM_reallocN instead of MEM_reallocN_id.

Mar 3 2018, 1:41 PM · Modifiers
Campbell Barton (campbellbarton) accepted D3092: Array modifier: Do not merge vertex groups with different names.
Mar 3 2018, 1:32 PM · Modifiers
Philip Holzmann (Foaly) added inline comments to D3092: Array modifier: Do not merge vertex groups with different names.
Mar 3 2018, 1:10 PM · Modifiers
Philip Holzmann (Foaly) updated the diff for D3092: Array modifier: Do not merge vertex groups with different names.

Minor adjustments

Mar 3 2018, 1:05 PM · Modifiers
Campbell Barton (campbellbarton) requested changes to D3092: Array modifier: Do not merge vertex groups with different names.
Mar 3 2018, 12:20 PM · Modifiers
Campbell Barton (campbellbarton) accepted D3092: Array modifier: Do not merge vertex groups with different names.
Mar 3 2018, 12:16 PM · Modifiers
Campbell Barton (campbellbarton) updated subscribers of D3092: Array modifier: Do not merge vertex groups with different names.

Generally looks good, I'd like to get feedback from @Bastien Montagne (mont29) on clamping.

Mar 3 2018, 12:16 PM · Modifiers
Philip Holzmann (Foaly) updated the diff for D3092: Array modifier: Do not merge vertex groups with different names.

Vertex Group Merging is now two functions in BKE_object_deform.h.
Used by Array Modifier and join_mesh_single.

Mar 3 2018, 12:01 PM · Modifiers
Campbell Barton (campbellbarton) requested changes to D3092: Array modifier: Do not merge vertex groups with different names.
Mar 3 2018, 10:01 AM · Modifiers
Campbell Barton (campbellbarton) added a comment to D3092: Array modifier: Do not merge vertex groups with different names.

Generally OK, although this should be a reusable utility function, it can be added to BKE_object_deform.h call:

Mar 3 2018, 9:57 AM · Modifiers

Mar 2 2018

Philip Holzmann (Foaly) added a comment to T53206: Unexpected merging of vertex groups with different names.

I have added a patch, but I don't know if I did it correctly.
If you can see it: Is it okay to fix it that way?

Mar 2 2018, 11:33 PM · Mesh Modeling, Modifiers, BF Blender
Philip Holzmann (Foaly) added a task to D3092: Array modifier: Do not merge vertex groups with different names: T53206: Unexpected merging of vertex groups with different names.
Mar 2 2018, 11:30 PM · Modifiers