NodesProject
ActivePublic

Watchers

  • This project does not have any watchers.

Properties

Description

Node editor.

Module Owner: @Lukas Toenne (lukastoenne)

Recent Activity

Yesterday

Bastien Montagne (mont29) added a comment to T51007: Material viewport mode crash on node with more than 64 outputs..

@Sergey Sharybin (sergey) think raising hard limit is fine yes.

Wed, Mar 22, 5:44 PM · Nodes, BF Blender
Lex (Lex4art) added a comment to T51007: Material viewport mode crash on node with more than 64 outputs..

The issue is coming from hardcoded MAX_SOCKET set to 64. I've tried to remove such a static limit, but it's not so trivial within the current nodes design, especially for the texture nodes. I think it is safe to bump this constant to 512. This will only be ~16K extra stack memory usage per thread during evaluation which is really small for the modern systems.

Wed, Mar 22, 5:36 PM · Nodes, BF Blender
Sergey Sharybin (sergey) edited projects for T51007: Material viewport mode crash on node with more than 64 outputs., added: Nodes; removed Rendering, Cycles.
Wed, Mar 22, 5:25 PM · Nodes, BF Blender

Feb 9 2017

Joey Ferwerda (TheOnlyJoey) closed T50499: Object mapped normal maps are influenced by UVs. as "Invalid".

Report has not been reacted on for 7 days, closing due to bug tracker policy.

Feb 9 2017, 4:32 PM · Cycles, Nodes, BF Blender

Feb 2 2017

Aaron Carlisle (Blendify) triaged T50499: Object mapped normal maps are influenced by UVs. as "Incomplete" priority.

Please upload a simple blend-file that demonstrates the issue. It saves us loads of time.

Feb 2 2017, 6:51 AM · Cycles, Nodes, BF Blender

Jan 25 2017

LazyDodo (LazyDodo) closed T50527: Blender crashed right after add texture node in compositor as "Invalid".

This is a known issue, and the good news is: fixed already! if you need the fix urgently you can grab a build from http://builder.blender.org otherwise this fix will be included in the next official update.

Jan 25 2017, 4:45 PM · Nodes
Toha (nolka) added a comment to T50527: Blender crashed right after add texture node in compositor.

My CPU is: Intel(R) Core(TM) i5-3230M

Jan 25 2017, 4:43 PM · Nodes
Toha (nolka) created T50527: Blender crashed right after add texture node in compositor.
Jan 25 2017, 4:40 PM · Nodes

Jan 22 2017

Adam Preisler (Alphisto) created T50499: Object mapped normal maps are influenced by UVs..
Jan 22 2017, 4:58 PM · Cycles, Nodes, BF Blender

Jan 19 2017

Joey Ferwerda (TheOnlyJoey) closed T50417: .new() does not work when trying to create new sockets on a group input or group output node as "Resolved".
Jan 19 2017, 5:00 PM · Nodes, BF Blender

Jan 17 2017

Jacob Morris (BlendingJake) added a comment to T50417: .new() does not work when trying to create new sockets on a group input or group output node.
ng.outputs.new("NodeSocketColor", "color")  
ng.inputs.new("NodeSocketShader", "shader")

will probably work.

Jan 17 2017, 8:26 PM · Nodes, BF Blender
LazyDodo (LazyDodo) added a comment to T50417: .new() does not work when trying to create new sockets on a group input or group output node.
ng.outputs.new("NodeSocketColor", "color")  
ng.inputs.new("NodeSocketShader", "shader")

will probably work.

Jan 17 2017, 8:13 PM · Nodes, BF Blender
Jacob Morris (BlendingJake) added a comment to T50417: .new() does not work when trying to create new sockets on a group input or group output node.

I can not reproduce this working on 2.77 which does not match with the report, which version did this work on, can you retest please?

Have you tested with the 'a' releases?

Jan 17 2017, 8:10 PM · Nodes, BF Blender
Jacob Morris (BlendingJake) edited the description of T50417: .new() does not work when trying to create new sockets on a group input or group output node.
Jan 17 2017, 8:05 PM · Nodes, BF Blender
Joey Ferwerda (TheOnlyJoey) added a comment to T50417: .new() does not work when trying to create new sockets on a group input or group output node.

I can not reproduce this working on 2.77 which does not match with the report, which version did this work on, can you retest please?

Jan 17 2017, 1:28 PM · Nodes, BF Blender

Jan 15 2017

LazyDodo (LazyDodo) closed T50432: Crash with texture node as "Invalid".

Good news! This issue is already fixed! If you want the fix head over to https://builder.blender.org/download/ and grab a nightly, otherwise this will be fix in the next official version!

Jan 15 2017, 1:57 AM · Nodes, Compositing, BF Blender
Vincent Girès (VincentG) created T50432: Crash with texture node.
Jan 15 2017, 1:00 AM · Nodes, Compositing, BF Blender

Jan 12 2017

Jacob Morris (BlendingJake) renamed T50417: .new() does not work when trying to create new sockets on a group input or group output node from ".new does not work when trying to create new sockets on a group input or group output node" to ".new() does not work when trying to create new sockets on a group input or group output node".
Jan 12 2017, 3:27 PM · Nodes, BF Blender

Jan 11 2017

Jacob Morris (BlendingJake) created T50417: .new() does not work when trying to create new sockets on a group input or group output node.
Jan 11 2017, 11:46 PM · Nodes, BF Blender

Dec 20 2016

Julian Eisel (Severin) moved T46540: In-frame node selection issue from Backlog to Bugs/Conflicts/etc. on the User Interface board.
Dec 20 2016, 11:13 PM · User Interface, BF Blender, Nodes

Nov 29 2016

Sergey Sharybin (sergey) closed T50094: crash when viewport rendering point density texture as "Resolved" by committing rB1ec5edcc9669: Fix T50094: Crash when viewport rendering point density texture.
Nov 29 2016, 11:44 AM · Nodes, Cycles, BF Blender

Nov 28 2016

LazyDodo (LazyDodo) added a comment to T50094: crash when viewport rendering point density texture.

It would, BlenderSession::builtin_image_info would query the PD settings once, to get the resolution, and beyond that the buffer dimensions would be passed down, so there's no need for rna_ShaderNodePointDensity_density_calc to query the PD Settings and get a potentially different answer.

Nov 28 2016, 5:21 PM · Nodes, Cycles, BF Blender
Sergey Sharybin (sergey) added a comment to T50094: crash when viewport rendering point density texture.

Not sure that will solve anything. You can still change PD settings while builtin_image_float_pixels_cb() is sampling the PD causing threading conflicts.

Nov 28 2016, 5:06 PM · Nodes, Cycles, BF Blender
LazyDodo (LazyDodo) added a comment to T50094: crash when viewport rendering point density texture.

Ideally i'd like to extend builtin_image_float_pixels_cb and builtin_image_pixels_cb to include the buffer dimensions (passing a pointer to a buffer, without telling the callee what size it is, just seems bad faith to me, and inviting issues like these) however that in turn causes a change to rna_ShaderNodePointDensity_density_calc (to include the buffer dimensions there as well) but that might be a breaking api change, not sure if that's ok? (doesn't look like any python is calling it though, so it just be a c/c++ code change)

Nov 28 2016, 5:02 PM · Nodes, Cycles, BF Blender
Sergey Sharybin (sergey) added a comment to T50094: crash when viewport rendering point density texture.

Not sure what would be best here, can in theory use similar technique as initial sync is doing: have a main thread locked while sampling point density (see WM_job_main_thread_lock_acquire). This is annoying tho, because it introduces interface locks which we hate and must avoid.

Nov 28 2016, 1:27 PM · Nodes, Cycles, BF Blender
LazyDodo (LazyDodo) claimed T50094: crash when viewport rendering point density texture.

race condition, in between the time ImageManager allocates ram for the texture and the time it gets sampled the ui managed to get in a change to the resolution. causing things to overflow in point_density_sample_func. Not quite sure how to stop that from happening. @Sergey Sharybin (sergey) any hints/tips?

Nov 28 2016, 3:49 AM · Nodes, Cycles, BF Blender

Nov 27 2016

LazyDodo (LazyDodo) added a comment to T50094: crash when viewport rendering point density texture.

This one was easy to repro,

Nov 27 2016, 11:55 PM · Nodes, Cycles, BF Blender
Aaron Nichols (newbs) added a comment to T50094: crash when viewport rendering point density texture.

Joel Meyer, Can you upload a blend file please? Thank you.

Nov 27 2016, 3:13 PM · Nodes, Cycles, BF Blender

Nov 24 2016

Joel Meyer (sirjofri) edited the description of T50094: crash when viewport rendering point density texture.
Nov 24 2016, 3:59 PM · Nodes, Cycles, BF Blender

Nov 22 2016

Joel Meyer (sirjofri) created T50094: crash when viewport rendering point density texture.
Nov 22 2016, 10:45 PM · Nodes, Cycles, BF Blender

Nov 4 2016

Brecht Van Lommel (brecht) added a comment to T49801: Normal Map node is not working correctly.

If the images input into the shader network are linear, and you manipulate those values and link the result directly into a Normal Map node, then I'm not sure how you can end up with sRGB values unless the shader network is explicitly doing that conversion.

Nov 4 2016, 11:05 PM · BF Blender, Cycles, Nodes
Mario Mey (mariomey) added a comment to T49801: Normal Map node is not working correctly.

@Brecht Van Lommel (brecht), someone made a "Bump_to_normal" node setup, to convert a bump map in normal map, with some nodes. This setup works to make normal texture, but not for using it as normal map. Why? Because the color space isn't set up. It works as a NormalMap texture with sRGB (bad).

Nov 4 2016, 4:46 PM · BF Blender, Cycles, Nodes

Oct 23 2016

Brecht Van Lommel (brecht) added a comment to T49801: Normal Map node is not working correctly.

I think such issues with the new depsgraph can be reported as a bug. They might only get looked into for Blender 2.8, I'm not sure, but definitely useful to know about them.

Oct 23 2016, 1:30 AM · BF Blender, Cycles, Nodes

Oct 22 2016

Mario Mey (mariomey) added a comment to T49801: Normal Map node is not working correctly.

Just as it is. Thanks.

Oct 22 2016, 5:34 PM · BF Blender, Cycles, Nodes
Brecht Van Lommel (brecht) closed T49801: Normal Map node is not working correctly as "Invalid".

This is not a bug though confusing. For node setups, you must manually set the color space of the image to Non-Color in the image editor. The texture stack does this conversion automatically, but for arbitrary node setups we currently have no way of doing that.

Oct 22 2016, 12:21 PM · BF Blender, Cycles, Nodes

Oct 21 2016

Mario Mey (mariomey) added a comment to T49801: Normal Map node is not working correctly.

Despite I know that this node cames from Cycles, this report is about the incorporation of it in BI and ViewPort.

Oct 21 2016, 9:41 PM · BF Blender, Cycles, Nodes
Bastien Montagne (mont29) added projects to T49801: Normal Map node is not working correctly: Cycles, BF Blender.
Oct 21 2016, 2:59 PM · BF Blender, Cycles, Nodes

Oct 20 2016

Mario Mey (mariomey) edited the description of T49801: Normal Map node is not working correctly.
Oct 20 2016, 2:35 PM · BF Blender, Cycles, Nodes
Mario Mey (mariomey) created T49801: Normal Map node is not working correctly.
Oct 20 2016, 2:34 PM · BF Blender, Cycles, Nodes

Oct 18 2016

Vuk Gardašević (lijenstina) added a comment to D2007: Allow users to have vertical nodes in the node editor.

This could be useful for everything nodes like displaying bone hierarchies parent/child relations in general.

Oct 18 2016, 6:21 PM · User Interface, Nodes

Sep 30 2016

Greg Zaal (gregzaal) closed D2129: Node Wrangler - Reset node, Copy Node Attributes by committing rBA5929cc941927: Node Wrangler - Reset node by @poor & @zeffii.
Sep 30 2016, 12:06 PM · Addons, Nodes
Dealga McArdle (zeffii) added a comment to D2129: Node Wrangler - Reset node, Copy Node Attributes.

@Greg Zaal (gregzaal) asked me to chime in here.

Sep 30 2016, 11:20 AM · Addons, Nodes

Sep 27 2016

Julian Eisel (Severin) added a comment to D2129: Node Wrangler - Reset node, Copy Node Attributes.

@Greg Zaal (gregzaal), Git is open for BCon1 changes now, so should be fine to commit this now ;)

Sep 27 2016, 9:05 PM · Addons, Nodes

Sep 4 2016

Aaron Carlisle (Blendify) added a revision to T45657: Add visual warning for links between incompatible node sockets: D2190: Node Editor: Highlight invalid closure and string links in red.
Sep 4 2016, 11:00 PM · Rendering, Nodes, User Interface

Aug 31 2016

Greg Zaal (gregzaal) closed T49134: Node Wranger: Nodes sometimes not in alphabetical order. as "Resolved" by committing rBAd744864e5483: Fix T49134 - Sort node menus to match blender.
Aug 31 2016, 11:13 AM · Nodes, Addons

Aug 27 2016

Thomas Dinges (dingto) closed T49157: Cycles shows 16-bit PNG Textures as "missing(magenta)" as "Resolved".

Older Blender versions had a limit of 5 float (16 or 32bit) textures, as the error message says. This has been fixed. :)

Aug 27 2016, 11:32 PM · Nodes, Cycles, BF Blender

Aug 25 2016

Timm (Stillnotstatic) added a comment to T49157: Cycles shows 16-bit PNG Textures as "missing(magenta)".

Hi, thanks for the fast response...
As Wolfgang Faehnle said it works on CPU amd buildbot version.
The problem seems only to appear on GPU rendering on non-buildbot versions.

Aug 25 2016, 3:48 PM · Nodes, Cycles, BF Blender
Wolfgang Faehnle (mib2berlin) added a comment to T49157: Cycles shows 16-bit PNG Textures as "missing(magenta)".

Hi, checked the file and you use a complex shader group.
Your shader does work on CPU.
It work on master/buildbot, Sergey gave link already.

Aug 25 2016, 1:55 PM · Nodes, Cycles, BF Blender
Sergey Sharybin (sergey) triaged T49157: Cycles shows 16-bit PNG Textures as "missing(magenta)" as "Incomplete" priority.

Some questions:

Aug 25 2016, 9:51 AM · Nodes, Cycles, BF Blender
Timm (Stillnotstatic) edited the description of T49157: Cycles shows 16-bit PNG Textures as "missing(magenta)".
Aug 25 2016, 5:21 AM · Nodes, Cycles, BF Blender