Page MenuHome

NodesProject
ActivePublic

Details

Description

Node editor.

Module Owner: @Lukas Toenne (lukastoenne)

Recent Activity

Wed, Oct 9

Campbell Barton (campbellbarton) closed T70638: View Selected in node editor only works with multiple nodes selected as Invalid.
Wed, Oct 9, 4:13 AM · User Interface, Nodes, BF Blender
Campbell Barton (campbellbarton) added a comment to T70638: View Selected in node editor only works with multiple nodes selected.

Closing since this isn't a bug, continue discussion in D6019: Fix T70638: View Selected in node editor only works with multiple nodes selected

Wed, Oct 9, 4:13 AM · User Interface, Nodes, BF Blender

Tue, Oct 8

Jay Doshi (netricsa) added a comment to T70638: View Selected in node editor only works with multiple nodes selected.

Ah that does help!

Tue, Oct 8, 4:42 PM · User Interface, Nodes, BF Blender
Philipp Oeser (lichtwerk) raised the priority of T70638: View Selected in node editor only works with multiple nodes selected from Confirmed, Medium to Waiting for Developer to Reproduce.

Turns out this was made on purpose, see rB4005b88b30cf: minor edits to node view - when single (non frame) node selected, dont zoom in…, not sure what the reasoning there is @Campbell Barton (campbellbarton) ?
Maybe we should do something like D6019 (which will take the biggest node in the tree into account), so you get panning once close, but still gets you closer if you start far out?

Tue, Oct 8, 3:42 PM · User Interface, Nodes, BF Blender
Philipp Oeser (lichtwerk) added a revision to T70638: View Selected in node editor only works with multiple nodes selected: D6019: Fix T70638: View Selected in node editor only works with multiple nodes selected.
Tue, Oct 8, 3:41 PM · User Interface, Nodes, BF Blender
Philipp Oeser (lichtwerk) claimed T70638: View Selected in node editor only works with multiple nodes selected.

Confirmed, checking...

Tue, Oct 8, 2:24 PM · User Interface, Nodes, BF Blender

Fri, Oct 4

Brecht Van Lommel (brecht) merged T70533: Drag node release confirms into T70504: Moving nodes in the node editor stops after hotkey is lifted.
Fri, Oct 4, 7:48 PM · Nodes, BF Blender
Philipp Oeser (lichtwerk) closed T70504: Moving nodes in the node editor stops after hotkey is lifted as Resolved by committing rB295f8884336c: Fix T70504: Moving nodes in the node editor stops after hotkey is lifted.
Fri, Oct 4, 3:57 PM · Nodes, BF Blender
Brecht Van Lommel (brecht) added a comment to T70504: Moving nodes in the node editor stops after hotkey is lifted.

@Philipp Oeser (lichtwerk) you can commit that. I tried to see if there is a better solution but couldn't find a good one, macros really should have some way to pass along operator properties.

Fri, Oct 4, 3:16 PM · Nodes, BF Blender
Dalai Felinto (dfelinto) assigned T70504: Moving nodes in the node editor stops after hotkey is lifted to Brecht Van Lommel (brecht).
Fri, Oct 4, 3:04 PM · Nodes, BF Blender
Philipp Oeser (lichtwerk) merged T70518: G hotkey only works when holding in node editors into T70504: Moving nodes in the node editor stops after hotkey is lifted.
Fri, Oct 4, 3:03 PM · Nodes, BF Blender
Philipp Oeser (lichtwerk) lowered the priority of T70504: Moving nodes in the node editor stops after hotkey is lifted from Needs Triage by Developer to Confirmed, High.

Caused by rB540eb2dc1e57, @Brecht Van Lommel (brecht): for mouse tweak this seemed fine, but not for keyboard
How about this instead?

1
2
3diff --git a/source/blender/editors/space_node/node_ops.c b/source/blender/editors/space_node/node_ops.c
4index 5874b6d1cc0..11933ef0811 100644
5--- a/source/blender/editors/space_node/node_ops.c
6+++ b/source/blender/editors/space_node/node_ops.c
7@@ -143,7 +143,6 @@ void ED_operatormacros_node(void)
8 "Move nodes and attach to frame",
9 OPTYPE_UNDO | OPTYPE_REGISTER);
10 mot = WM_operatortype_macro_define(ot, "TRANSFORM_OT_translate");
11- RNA_boolean_set(mot->ptr, "release_confirm", true);
12 WM_operatortype_macro_define(ot, "NODE_OT_attach");
13 WM_operatortype_macro_define(ot, "NODE_OT_insert_offset");
14
15@@ -153,7 +152,6 @@ void ED_operatormacros_node(void)
16 "Move nodes and attach to frame",
17 OPTYPE_UNDO | OPTYPE_REGISTER);
18 mot = WM_operatortype_macro_define(ot, "TRANSFORM_OT_translate");
19- RNA_boolean_set(mot->ptr, "release_confirm", true);
20 RNA_boolean_set(mot->ptr, "remove_on_cancel", true);
21 WM_operatortype_macro_define(ot, "NODE_OT_attach");
22 WM_operatortype_macro_define(ot, "NODE_OT_insert_offset");
23diff --git a/source/blender/editors/transform/transform_generics.c b/source/blender/editors/transform/transform_generics.c
24index 083b5b94c48..2f77b0453a4 100644
25--- a/source/blender/editors/transform/transform_generics.c
26+++ b/source/blender/editors/transform/transform_generics.c
27@@ -1707,7 +1707,7 @@ void initTransInfo(bContext *C, TransInfo *t, wmOperator *op, const wmEvent *eve
28 }
29 }
30 else {
31- if (ISMOUSE(t->launch_event) && (U.flag & USER_RELEASECONFIRM)) {
32+ if (ISMOUSE(t->launch_event) && ((U.flag & USER_RELEASECONFIRM) || (t->spacetype == SPACE_NODE))) {
33 /* Global "release confirm" on mouse bindings */
34 t->flag |= T_RELEASE_CONFIRM;
35 }

Fri, Oct 4, 12:42 PM · Nodes, BF Blender

Wed, Oct 2

Brecht Van Lommel (brecht) closed T70253: Normal Map node ignores UV Map input node as Archived.

Could be improved once but is not a bug.

Wed, Oct 2, 11:51 PM · Nodes, BF Blender
Philipp Oeser (lichtwerk) closed T70441: Crash after delete material as Resolved by committing rB6b38c8a1ac1b: Fix T70441: crash after deleting a material output node.
Wed, Oct 2, 2:03 PM · Nodes, BF Blender
Philipp Oeser (lichtwerk) assigned T70441: Crash after delete material to Clément Foucault (fclem).

Still assigning to you, @Clément Foucault (fclem), but could you check if D5969 does the trick?

Wed, Oct 2, 12:53 PM · Nodes, BF Blender
Philipp Oeser (lichtwerk) added a revision to T70441: Crash after delete material: D5969: Fix T70441: crash after deleting a material output node.
Wed, Oct 2, 12:51 PM · Nodes, BF Blender
Philipp Oeser (lichtwerk) merged T70442: in lookdev mode, changing material output from "all" to "cycles" makes blender crash into T70441: Crash after delete material.
Wed, Oct 2, 12:33 PM · Nodes, BF Blender
Philipp Oeser (lichtwerk) added a comment to T70441: Crash after delete material.

crashes here node_start is NULL

Wed, Oct 2, 12:31 PM · Nodes, BF Blender
Philipp Oeser (lichtwerk) lowered the priority of T70441: Crash after delete material from Needs Triage by Developer to Confirmed, High.

Can confirm, checking... (probably 5c79f2d0fba7?)

Wed, Oct 2, 12:30 PM · Nodes, BF Blender

Mon, Sep 30

Philipp Oeser (lichtwerk) added a comment to T70362: Viewer node not showing basic color in preview..

Thanks. I will admit I am new to this but I do want to contribute my findings. Would you suggest that I should only report something which crashes the application?
I have recently reported a few dysfunctional example files in the 2.81 and 2.80 manual. Is this also something I should not do? I did not label it as a bug but rather a 'to do'.
I have just noticed the Blender Stack Exchange. Should I post in here unless I am judging it to be an absolute bug?

Mon, Sep 30, 4:54 PM · Nodes, Compositing, BF Blender
Junkflex (Junkflex) added a comment to T70362: Viewer node not showing basic color in preview..

Thanks. I will admit I am new to this but I do want to contribute my findings. Would you suggest that I should only report something which crashes the application?
I have recently reported a few dysfunctional example files in the 2.81 and 2.80 manual. Is this also something I should not do? I did not label it as a bug but rather a 'to do'.
I have just noticed the Blender Stack Exchange. Should I post in here unless I am judging it to be an absolute bug?

Mon, Sep 30, 4:18 PM · Nodes, Compositing, BF Blender
Philipp Oeser (lichtwerk) added projects to T70362: Viewer node not showing basic color in preview.: Compositing, Nodes.

In order to derive resolution for the Viewer node, it is mandatory to feed in a real image (so the compositor has an ImageUser to get with and height from)
This is why it starts working with your workaround.

Mon, Sep 30, 12:14 PM · Nodes, Compositing, BF Blender
Philipp Oeser (lichtwerk) merged T70365: In Node editor, Groups name does not change into T70364: In Node editor, Groups name does not change.
Mon, Sep 30, 11:37 AM · User Interface, Nodes, BF Blender
Philipp Oeser (lichtwerk) added projects to T70364: In Node editor, Groups name does not change: Nodes, User Interface.

Not sure I understand correctly:

Mon, Sep 30, 11:03 AM · User Interface, Nodes, BF Blender

Fri, Sep 27

noki paike (amonpaike) added a comment to T70279: crash, Helicopter, blender 2.74 demo file.

@Philipp Oeser (lichtwerk) just a little improvement, if the file is updated, the scratches of the metal should not move like reflections :)

Fri, Sep 27, 7:29 PM · Cycles, Nodes, BF Blender
Philipp Oeser (lichtwerk) added a project to T70279: crash, Helicopter, blender 2.74 demo file: Cycles.
Fri, Sep 27, 1:51 PM · Cycles, Nodes, BF Blender
Philipp Oeser (lichtwerk) updated subscribers of T70279: crash, Helicopter, blender 2.74 demo file.

So we are getting the crash in the versioning code due to node->storage being NULL.
This can happen in certain scenarios (see T69663 for how this can happen).

Fri, Sep 27, 1:31 PM · Cycles, Nodes, BF Blender
Philipp Oeser (lichtwerk) added a project to T70279: crash, Helicopter, blender 2.74 demo file: Nodes.

Sounds like an error in versioning code from rB23564583a498, should be fixied similar to rB5d9c01c53fd5.

Fri, Sep 27, 12:17 PM · Cycles, Nodes, BF Blender

Wed, Sep 25

Penny (penny) added a comment to T70253: Normal Map node ignores UV Map input node.

Oooh. That totally works now, thanks! I don't know why I've never noticed that field on the Normal Map node before. Sorry about that!

Wed, Sep 25, 11:01 PM · Nodes, BF Blender
Philipp Oeser (lichtwerk) added a project to T70253: Normal Map node ignores UV Map input node: Nodes.

Not exactly sure why this is, but you need to specify the UVMap not only as the Vector input for the Image texture node, but also on the Normal Map node itself:
https://docs.blender.org/manual/en/dev/render/shader_nodes/vector/normal_map.html#properties

Wed, Sep 25, 9:11 PM · Nodes, BF Blender

Sat, Sep 21

Shane Ambler (sambler) added a comment to T54314: Contents of "Viewer Node" image block do not get updated .

@Amir (Warrior) I checked with a master build before my previous comment. I hadn't tried in 2.79 for a while but just checked and it hasn't changed, not that any fixes will be done to 2.79.

Sat, Sep 21, 3:31 AM · Python, Nodes, Cycles, BF Blender

Thu, Sep 19

Amir (Warrior) added a comment to T54314: Contents of "Viewer Node" image block do not get updated .

@Shane Ambler (sambler) I haven't tried this in 2.8x. Did you try it with both 2.79x and 2.8x?

Thu, Sep 19, 6:53 PM · Python, Nodes, Cycles, BF Blender
Brecht Van Lommel (brecht) merged T70064: Mute RGB to BW converter node doesn't work in Cycles rendered into T54777: RGB To BW node is active when muted.
Thu, Sep 19, 2:30 PM · Nodes, Cycles
Shane Ambler (sambler) added a comment to T54314: Contents of "Viewer Node" image block do not get updated .

@Amir (Warrior) No. Just tried with 741d7d60ed90

Thu, Sep 19, 6:37 AM · Python, Nodes, Cycles, BF Blender

Tue, Sep 17

Amir (Warrior) added a comment to T54314: Contents of "Viewer Node" image block do not get updated .

@Jeroen Bakker (jbakker) Does this fix have anything to do with this issue?

Tue, Sep 17, 10:39 PM · Python, Nodes, Cycles, BF Blender

Sun, Sep 15

Philipp Oeser (lichtwerk) added a project to T67718: Point density texture crashes: Nodes.
Sun, Sep 15, 5:27 PM · Nodes, Cycles, BF Blender

Sep 13 2019

Brecht Van Lommel (brecht) closed T68823: GSoC 2019 - Cycles/EEVEE Improvements as Resolved.
Sep 13 2019, 3:44 PM · BF Blender (2.81), Nodes, Rendering, Cycles

Sep 12 2019

Omar Emara (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Sep 12 2019, 5:57 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Omar Emara (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Sep 12 2019, 1:14 PM · BF Blender (2.81), Nodes, Rendering, Cycles

Sep 11 2019

Omar Emara (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Sep 11 2019, 9:49 PM · BF Blender (2.81), Nodes, Rendering, Cycles

Sep 10 2019

Omar Emara (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Sep 10 2019, 6:15 PM · BF Blender (2.81), Nodes, Rendering, Cycles

Sep 9 2019

Omar Emara (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Sep 9 2019, 9:15 PM · BF Blender (2.81), Nodes, Rendering, Cycles

Sep 7 2019

Charlie Jolly (charlie) updated the summary of D3789: Cycles: Vector Rotate Node using Axis and Angle method.
Sep 7 2019, 5:17 PM · Nodes, Eevee, Cycles
Charlie Jolly (charlie) retitled D3789: Cycles: Vector Rotate Node using Axis and Angle method from Cycles & Eevee Vector Rotate Node: Standalone node with access to XYZ sockets. to Cycles: Vector Rotate Node using Axis and Angle method.
Sep 7 2019, 5:16 PM · Nodes, Eevee, Cycles
Charlie Jolly (charlie) added a comment to D3789: Cycles: Vector Rotate Node using Axis and Angle method.

Change rotation method to axis angle

Sep 7 2019, 5:10 PM · Nodes, Eevee, Cycles

Sep 6 2019

Charlie Jolly (charlie) added a comment to D3789: Cycles: Vector Rotate Node using Axis and Angle method.

Keep patch up to date

Sep 6 2019, 5:51 PM · Nodes, Eevee, Cycles

Sep 5 2019

Omar Emara (OmarSquircleArt) updated the task description for T68823: GSoC 2019 - Cycles/EEVEE Improvements.
Sep 5 2019, 9:02 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Omar Emara (OmarSquircleArt) added a comment to T68823: GSoC 2019 - Cycles/EEVEE Improvements.

Hi @Dalai Felinto (dfelinto) , I can create patches for both task in the next two days.

Sep 5 2019, 9:02 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Dalai Felinto (dfelinto) added a comment to T68823: GSoC 2019 - Cycles/EEVEE Improvements.

Hi @Omar Emara (OmarSquircleArt) I'm wondering if you have any timeline for:

Sep 5 2019, 8:30 PM · BF Blender (2.81), Nodes, Rendering, Cycles
Dalai Felinto (dfelinto) edited projects for T68823: GSoC 2019 - Cycles/EEVEE Improvements, added: BF Blender (2.81); removed BF Blender.
Sep 5 2019, 8:26 PM · BF Blender (2.81), Nodes, Rendering, Cycles