Wed, Apr 19
@Sergey Sharybin (sergey) on the topic of git logs, does the system pull an email address from this account? If so I should change it to my blender-specific one (trying to keep spam vectors to a minimum).
Removed name from comment.
Tue, Apr 18
Looks good to me, except one thing: we almost never put names in the comments. You'll be credited in the git logs and git blame already.
Updated to use more efficient conversion when color spaces are identical as per @Sergey Sharybin (sergey)
@Sergey Sharybin (sergey) sorry for the diff spam, uploaded it as you were typing. Sounds much better to use the simple conversion!
@Olly Funkster (Funkster), that check can not be avoided without performance drop. What we can do is to run much simpler byte-to-float conversion (IMB_buffer_float_from_byte) for such cases, which will still be faster that starting all the threading and creating pixel processors.
Okay, probably best to ignore pretty much everything I said above. I think I had my git in a mess (this seems to happen to me quite often now I come to think of it...) resulting in my jumping back to 2.78c still having the issue.
Whoops, sorry - I mis-spoke before. I had added a text strip, forgetting that those default to "alpha over". Seems it doesn't matter where they are in the layer stack, if you have any other strips that are supposed to combine with the scene render (Add, Subtract, Multiply, Alpha over / under, Over Drop blend modes) then you either get nothing, or the 3D scene render, as your output (which thus doesn't match the OpenGL preview).
Hi,color strip added on top, the color strip is rendered.
Ah okay, thanks for the extra info. If you add another sequence strip (anything will do, color strip maybe?) on top of the scene strip, what ends up being displayed?
Hello Funkster! I made another quick test and in my test the combo box appears in both Blender versions. See the attached image, many thanks for looking into this.
@Aaron Carlisle (Blendify) ffmpeg gets the length right because the duration (in frames) has doubled as well as the tbr. If you let Blender change the scene rate to whatever ffmpeg tells it, the length in elapsed time is correct.
There's something pretty odd going on here. Firstly, I wound my source back to the commit that was tagged as 2.78c, and it still exhibits the problem. Secondly, the problem is nothing to do with the operation of "alpha over", but instead to do with the render result display.
Sun, Apr 16
Indeed something seems weird here. @Olly Funkster (Funkster) can you take a look?
Since last asking for information it has been 7 or more days, due to the policy of our bug tracker
we will have to archive the report until the requested information is given.
Sat, Apr 15
If there were an issue, it would be a regression since 01fa4fb6 but I suspect the duplicated timebase is correct for paff-encoded video, see also tickets #3339 and #5378. In any case, there is most likely a bug in blender as FFmpeg always detects the correct length of the clip, no matter the timebase
hi, re-reading the task, maybe this is better as a patch? it's too much to expect users to edit internal files to run the addon.
closing as archived
Thu, Apr 13
Feel free to amend the patch as you see fit. Would be great to see this in 2.79.
@Mike Pan (mpan3) will you be around to get this in for 2.79 if not do you mind if I update it with the requested review?
Tue, Apr 11
@Olly Funkster (Funkster) Something like that. Not sure how this system works, but some can mark a bug as "upstream." I don't see any way for me to do that.
I am now fairly positive that the problem is in ffmpeg. I have submitted a bug on the ffmpeg bug tracker detailing my findings: https://trac.ffmpeg.org/ticket/6307
You certainly know more than I, but I think you're right about it being a library difference. Here's my ffprobe output:
I've added the missing UI option to toggle whether the user wants this fix or not.
Ok, I have one project that manifests this, but is uses a few GBs of video files, I'll see if just on of these will do in a project. So I can upload it for testing.
Also N.B. the output of ffprobe for the "bad" clip is different from that quoted in the original report:
I am full of questions.
The issue reported can't be reproduced so far, and has been moved to the BF Blender: Unconfirmed project.
If 2 other people aren't able to redo the bug after 2 weeks, it will be closed.
Mon, Apr 10
@Stephen Swaney (stiv) Oh, I agree completely. It's just the easiest way to get a small clip that exhibits the problem. It acts exactly like the larger (3.3GB), unmodified clip. I was using ffmpeg to create the clip, but whatever it does to the newly created file, the behavior is not the same.
second clip, produced with dd if=00008.MTS of=bad_clip_2.mts bs=10M count=1
So... Yeah, apparently the clip I uploaded does not exhibit the same properties as the original file. I short, the original file works as I described. The clip, which I created with ffmpeg -i 00008.MTS -c copy -t 10 clip.MTS, has the problem in all of the versions I've tried.
I can't replicate I'm afraid... I get the same result in 2.78a (same hash as you mention) as 2.78c - the clip is seen as 59.94 fps and if it's the first clip imported, the scene framerate is set to match. It could be that all of them are wrong, but they are at least consistent.
Sat, Apr 8
Thu, Apr 6
Wed, Apr 5
@Mike Pan (mpan3) It seems there are still some pending review requests, other than that I like the changes.
Mon, Apr 3
Can't reproduce here (admittedly different platform)... can you upload a set of files (including blend) that produces this result? Thanks.