Add an "Exists" boolean to the named attribute input node #100004

Closed
opened 2022-07-26 18:21:48 +02:00 by Hans Goudey · 18 comments
Member

It could be helpful to tell if an attribute exists when building node groups, to choose between different behaviors or to give more helpful errors.

For the purpose of the attribute usage/dependency info shown in node overlays and the modifier, this should count as "read".

It could be helpful to tell if an attribute exists when building node groups, to choose between different behaviors or to give more helpful errors. For the purpose of the attribute usage/dependency info shown in node overlays and the modifier, this should count as "read".
Author
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly

Added subscriber: @Erindale

Added subscriber: @Erindale

Would this allow for example to check if a node group socket is occupied and if not then to, eg, use Position? Similar to how the texture nodes had a default state that can be overridden by plugging into the vector socket.

Would this allow for example to check if a node group socket is occupied and if not then to, eg, use Position? Similar to how the texture nodes had a default state that can be overridden by plugging into the vector socket.

Added subscriber: @ikakupa

Added subscriber: @ikakupa

Added subscriber: @GeorgiaPacific

Added subscriber: @GeorgiaPacific

Added subscriber: @Shan-Huang

Added subscriber: @Shan-Huang

Hmm noob question: where should the boolean be stored? Should it be stored in the GeoNodeExecParams object passed to the node exec function, as a used_name_attribute?

Hmm noob question: where should the boolean be stored? Should it be stored in the `GeoNodeExecParams` object passed to the node exec function, as a `used_name_attribute`?

Added subscriber: @mod_moder

Added subscriber: @mod_moder

This is the provider's attribute response to a request by name, I think.

This is the provider's attribute response to a request by name, I think.

Added subscriber: @edward88

Added subscriber: @edward88

@HooglyBoogly I believe the only way to get the geometry component that has the attribute in question is during the evaluation of the node's attribute field, and i can't figure out how. Doesn't this feature belong to a data flow node?

@HooglyBoogly I believe the only way to get the geometry component that has the attribute in question is during the evaluation of the node's attribute field, and i can't figure out how. Doesn't this feature belong to a data flow node?
Author
Member

The new output should be a field input (GeometryFieldInput) internally, it can be single value though, with VArray<bool>::ForSingle

The new output should be a field input (`GeometryFieldInput`) internally, it can be single value though, with `VArray<bool>::ForSingle`

This comment was removed by @edward88

*This comment was removed by @edward88*

This issue was referenced by 0d3a33e45e

This issue was referenced by 0d3a33e45eb3a69b665429cd24694d2d2ca0cbd4
Edward was assigned by Iliya Katushenock 2023-01-18 22:21:39 +01:00
Author
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'

I have a question about feature's design.
Let's take vertex weight for example: Exists shows True for all geometry no matter how many vertices have really assigned weight, but at the same time it can't be plugged to Switch Geometry as it represents a field type data.
What's the point of working it that way, maybe a single value boolean output would have more meaning?

I have a question about feature's design. Let's take vertex weight for example: _Exists_ shows `True` for all geometry no matter how many vertices have really assigned weight, but at the same time it can't be plugged to _Switch Geometry_ as it represents a field type data. What's the point of working it that way, maybe a single value boolean output would have more meaning?

@SergeL

  1. Vertex weight isn't attribute.
  2. Exists outputs is a field. Due to this it take geometry from context. This can not be used fot single-value input socket.
  3. Exists return true if this name is contains in data layers. This not check is this vertex is was be in the mask for saveing named attribute / vertex weight is setted.
@SergeL 1. Vertex weight isn't attribute. 2. `Exists` outputs is a field. Due to this it take geometry from context. This can not be used fot single-value input socket. 3. `Exists` return true if this name is contains in _data layers_. This not check is this vertex is was be in the mask for saveing named attribute / vertex weight is setted.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
9 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#100004
No description provided.