Collections.hide_viewport needs Visibility user interface #100786

New Issue

Kevin C. Burke · 2022-09-03T01:54:33+02:00

Kevin C. Burke commented

2022-09-03 01:54:33 +02:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94

Blender Version
Broken: version: 3.4.0 Alpha, branch: Timeline-Changes (modified), commit date: 2022-08-05 08:51, hash: 009e1324c9

Short description of error
Collection.hide_viewport disables a Collection without a Visibility user interface: an inconsistency with Objects.

Exact steps for others to reproduce the error
Objects whose visibility have been disabled by Python can be re-enabled from the Visibility panel:

cube = bpy.data.objects.get("Cube")
cube.hide_viewport = True

Collections do not:

import bpy
coll = bpy.data.collections.get("Collection")
coll.hide_viewport = True

In order to re-enable a collection disabled using hide_viewport, the user must context-click the Collection > Visibility > Enable in Viewports which is very confusing and inconsistent with Objects.

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94 **Blender Version** Broken: version: 3.4.0 Alpha, branch: Timeline-Changes (modified), commit date: 2022-08-05 08:51, hash: `009e1324c9` **Short description of error** [Collection.hide_viewport ](https://docs.blender.org/api/current/bpy.types.Collection.html#bpy.types.Collection.hide_viewport) disables a Collection without a Visibility user interface: an inconsistency with Objects. **Exact steps for others to reproduce the error** Objects whose visibility have been disabled by Python can be re-enabled from the Visibility panel: ``` cube = bpy.data.objects.get("Cube") cube.hide_viewport = True ``` ![image.png](https://archive.blender.org/developer/F13453453/image.png) Collections do not: ``` import bpy coll = bpy.data.collections.get("Collection") coll.hide_viewport = True ``` ![image.png](https://archive.blender.org/developer/F13453459/image.png) In order to re-enable a collection disabled using `hide_viewport`, the user must context-click the Collection > Visibility > Enable in Viewports which is very confusing and inconsistent with Objects.

Kevin C. Burke commented

2022-09-03 01:54:33 +02:00

Added subscriber: @KevinCBurke

Kevin C. Burke commented

2022-09-03 01:55:00 +02:00

No description provided.

Pratik Borhade commented

2022-09-03 06:26:45 +02:00

No description provided.

Pratik Borhade commented

2022-09-03 06:26:47 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-09-03 06:39:07 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade self-assigned this 2022-09-03 06:39:07 +02:00

Pratik Borhade commented

2022-09-17 08:28:38 +02:00

Following change would add a option in interface. But clicking on the options clears the selection flag for the collection. Not sure how to avoid this. Will look into it.

index 95debb259b0..08858e6caf5 100644
    - a/release/scripts/startup/bl_ui/properties_collection.py
+++ b/release/scripts/startup/bl_ui/properties_collection.py
@@ -43,6 +43,7 @@ class COLLECTION_PT_collection_flags(CollectionButtonsPanel, Panel):

   col = layout.column(align=True)
   col.prop(collection, "hide_select", text="Selectable", toggle=False, invert_checkbox=True)
   col.prop(collection, "hide_render", toggle=False)

+        col.prop(collection, "hide_viewport", toggle=False)

   col = layout.column(align=True)
   col.prop(vlc, "holdout", toggle=False)```

Following change would add a option in interface. But clicking on the options clears the selection flag for the collection. Not sure how to avoid this. Will look into it. ```diff --git a/release/scripts/startup/bl_ui/properties_collection.py b/release/scripts/startup/bl_ui/properties_collection.py index 95debb259b0..08858e6caf5 100644 - a/release/scripts/startup/bl_ui/properties_collection.py +++ b/release/scripts/startup/bl_ui/properties_collection.py @@ -43,6 +43,7 @@ class COLLECTION_PT_collection_flags(CollectionButtonsPanel, Panel): ``` col = layout.column(align=True) col.prop(collection, "hide_select", text="Selectable", toggle=False, invert_checkbox=True) col.prop(collection, "hide_render", toggle=False) ``` + col.prop(collection, "hide_viewport", toggle=False) ``` col = layout.column(align=True) col.prop(vlc, "holdout", toggle=False)```

Kevin C. Burke commented

2022-09-18 09:23:35 +02:00

Perhaps this?
https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_outliner/outliner_draw.cc$933

Perhaps this? https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_outliner/outliner_draw.cc$933

Pratik Borhade commented

2022-09-20 13:05:47 +02:00

No, that didn't fix the issue

Pratik Borhade commented

2022-10-12 15:58:58 +02:00

I think I found the cause.
In layer.c file, if collection is hidden or disabled, we set it's parent collection as "active collection"

LayerCollection *active = view_layer->active_collection;
if (active && layer_collection_hidden(view_layer, active)) {
BKE_layer_collection_activate_parent(view_layer, active);
}```

I don't understand the purpose to set it's parent collection as active. 
- - -
I'm seeing more inconsistency here:
- Suppose Col2 is parent of Col1. Select Col1 and set it as Hidden . Now collection properties tab will display Col2 as active but in outliner Col1 appears as active/selected
- Say "scene collection" is parent of Col1. Select and hide col1. Now "scene collection" will be our active collection. For them we don't display "Collection properties tab". see: `buttons_context_path_collection`. So we'll have col1 as active/selected in outliner but there won't be Collection properties tab

I think I found the cause. In `layer.c` file, if collection is hidden or disabled, we set it's parent collection as "active collection" ``` /* Always set a valid active collection. */ ``` LayerCollection *active = view_layer->active_collection; if (active && layer_collection_hidden(view_layer, active)) { BKE_layer_collection_activate_parent(view_layer, active); }``` ``` I don't understand the purpose to set it's parent collection as active. - - - I'm seeing more inconsistency here: - Suppose Col2 is parent of Col1. Select Col1 and set it as Hidden . Now collection properties tab will display Col2 as active but in outliner Col1 appears as active/selected - Say "scene collection" is parent of Col1. Select and hide col1. Now "scene collection" will be our active collection. For them we don't display "Collection properties tab". see: `buttons_context_path_collection`. So we'll have col1 as active/selected in outliner but there won't be Collection properties tab

Paul Kotelevets commented

2022-10-12 17:08:11 +02:00

Added subscriber: @1D_Inc

Paul Kotelevets commented

2022-10-12 17:08:11 +02:00

The point of any active element is being user-defined, if active element is changed not by user, it is equal to "losing active element".

Pratik Borhade removed their assignment 2022-12-31 05:14:52 +01:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Collections.hide_viewport needs Visibility user interface #100786