Blender crash for mesh with string attribute. #101660

New Issue

Xing Wang · 2022-10-06T23:09:15+02:00

Xing Wang commented

2022-10-06 23:09:15 +02:00

System Information
Operating system: 'Linux-5.13.0-51-generic-x86_64-with-glibc2.31'
Graphics card: Mesa Intel(R) UHD Graphics (CML GT2)

Blender Version
Broken: 3.3, 3.4
Exposed by 25c8d72e20, but really caused by the move to CPPType 31365c6b9e / 2252bc6a55

Short description of error
Blender crashed when adding "Instance on Points Node" to mesh with a string attribute.

Exact steps for others to reproduce the error

use the default cube.
add a geometry node to the cube.
add "Instance on Points Node", and link the Group Input "Geometry" socket to the "Points" socket, and link the "Instances" socket to Group Output "Geometry" socket.
go to the "Attribute" panel in "Object data properties", and try to add a "String" attribute.

#101660.blend

Other information
May be related to another bug: https://developer.blender.org/T100747

**System Information** Operating system: 'Linux-5.13.0-51-generic-x86_64-with-glibc2.31' Graphics card: Mesa Intel(R) UHD Graphics (CML GT2) **Blender Version** Broken: 3.3, 3.4 Exposed by 25c8d72e20, but really caused by the move to CPPType 31365c6b9e / 2252bc6a55 **Short description of error** Blender crashed when adding "Instance on Points Node" to mesh with a string attribute. **Exact steps for others to reproduce the error** - use the default cube. - add a geometry node to the cube. - add "Instance on Points Node", and link the Group Input "Geometry" socket to the "Points" socket, and link the "Instances" socket to Group Output "Geometry" socket. - go to the "Attribute" panel in "Object data properties", and try to add a "String" attribute. [#101660.blend](https://archive.blender.org/developer/F13626152/T101660.blend) --- **Other information** May be related to another bug: https://developer.blender.org/T100747

Xing Wang commented

2022-10-06 23:09:15 +02:00

Added subscriber: @superstar54

Pratik Borhade commented

2022-10-07 05:51:08 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-10-07 06:04:52 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-10-07 06:04:52 +02:00

Thanks for the report. I can redo the crash locally. I'll check

Pratik Borhade commented

2022-10-07 06:26:10 +02:00

Added subscriber: @lichtwerk

Pratik Borhade commented

2022-10-07 06:26:10 +02:00

May be related to another bug: https://developer.blender.org/T100747

Indeed.
25c8d72e20 is the first bad commit
@lichtwerk ^

> May be related to another bug: https://developer.blender.org/T100747 Indeed. 25c8d72e20 is the first bad commit @lichtwerk ^

Iliya Katushenock commented

2022-10-07 06:27:27 +02:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2022-10-07 06:27:27 +02:00

Looks strange. In addition to the fact that there should not be a crash due to the string, it should not be possible to make a string attribute ...

Philipp Oeser commented

2022-10-07 08:58:27 +02:00

Will check.

In #101660#1428986, @mod_moder wrote:
it should not be possible to make a string attribute ...

why?

Will check. > In #101660#1428986, @mod_moder wrote: > it should not be possible to make a string attribute ... why?

Philipp Oeser self-assigned this 2022-10-07 12:34:31 +02:00

Iliya Katushenock commented

2022-10-07 14:34:42 +02:00

It's not supported yet, so why? But that's just what was on my mind, in general, you can ask someone above

Philipp Oeser commented

2022-10-07 16:12:26 +02:00

There are a couple of loose ends with the CPPType stuff, but I think we should at least fill these wholes to not make blender crash.
Only other solution would be to remove string support all togther (also from the UI)

There are a couple of loose ends with the `CPPType` stuff, but I think we should at least fill these wholes to not make blender crash. Only other solution would be to remove string support all togther (also from the UI)

Xing Wang commented

2022-10-07 16:21:48 +02:00

@lichtwerk Great thanks for your help!

As a user, I think the string attribute is very useful. I really hope Blender can keep this feature.

The crash happens when using the geometry node for mesh with string attribute. So is there any possible solution that decouples the geometry node and string attribute?

@lichtwerk Great thanks for your help! As a user, I think the string attribute is very useful. I really hope Blender can keep this feature. The crash happens when using the geometry node for mesh with string attribute. So is there any possible solution that decouples the geometry node and string attribute?

Philipp Oeser commented

2022-10-09 14:15:48 +02:00

Added subscribers: @HooglyBoogly, @JacquesLucke

Philipp Oeser removed their assignment 2022-10-09 14:15:48 +02:00

Philipp Oeser commented

2022-10-09 14:15:48 +02:00

Not totally sure how much work this really is.
I have started implementing stuff for string attributes (see P3245) but also checked with @HooglyBoogly in chat and it seems strings are not ready for primetime in GN.
So maybe there is a way to exclude these (instead of implementing the needed stuff), but I would prefer to leave these for others.

Will step down since 25c8d72e20 did not really cause the crashes (just exposed the fact that these are not covered by 31365c6b9e / 2252bc6a55)

Not totally sure how much work this really is. I have started implementing stuff for string attributes (see [P3245](https://archive.blender.org/developer/P3245.txt)) but also checked with @HooglyBoogly in chat and it seems strings are not ready for primetime in GN. So maybe there is a way to exclude these (instead of implementing the needed stuff), but I would prefer to leave these for others. Will step down since 25c8d72e20 did not really cause the crashes (just exposed the fact that these are not covered by 31365c6b9e / 2252bc6a55)

Jacques Lucke commented

2022-10-18 16:54:04 +02:00

Support for string attributes in geometry nodes is indeed intentionally limited currently. More design work is necessary to figure out how they should work. I just committed a2fcfcabd7 which solves part of the problem. To really fix it we'll probably have to add a check in all nodes that propagate attributes so that they don't propagate string attributes for now.

Support for string attributes in geometry nodes is indeed intentionally limited currently. More design work is necessary to figure out how they should work. I just committed a2fcfcabd7 which solves part of the problem. To really fix it we'll probably have to add a check in all nodes that propagate attributes so that they don't propagate string attributes for now.

blender-admin commented

2022-10-18 17:16:51 +02:00

This issue was referenced by 91e85230f9

This issue was referenced by 91e85230f9c1b490f7424b9da7bbd65b7c0c4068

Jacques Lucke commented

2022-10-18 17:17:23 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2022-10-18 17:17:23 +02:00

Jacques Lucke self-assigned this 2022-10-18 17:17:23 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Blender crash for mesh with string attribute. #101660