Crash when editing geometry node tree or curves in the graph editor #102766
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#102766
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 526.98
Blender Version
Broken: version: 3.4.0 Beta, branch: blender-v3.4-release, commit date: 2022-11-24 16:55, hash:
959f3cd645
Worked: (newest version of Blender that worked as expected)
Short description of error
Crash when editing geometry node tree or curves in the graph editor
I have a big scene I cannot share it here, with a bit of everything in it, one library override rig with animation, two vdbs, two or three geometry node trees. I can tweak the nodes and the animation curve for a minute, and then it crashes. Here is the stack trace if it can help :
animation5.crash.txt
bug_video.mp4
Exact steps for others to reproduce the error
bug11.blend
robot_ref_bug.blend
bone_camera_target
)Move the keys in the graph randomly
Chance of reproducing the bug is very low, sometimes it takes 2 minutes of clicking.
Added subscriber: @thornydre
Added subscriber: @iss
Changed status from 'Needs Triage' to: 'Needs User Info'
From crash log, issue seems to be related to some overridden object. Unfortunately, without sample .blend file it is not possible to fix the issue. Can you simplify file as much as possible, so it can be shared?
I updated the files, hopefully it is not to much, and hopefully it can help.
I am able to reproduce crash, sometimes after many clicks only.
So far I saw asserts being hit in debug mode:
On file load,
BLI_assert(ptr != NULL);
in:And after many vertices moved in graph editor:
BLI_assert(removed);
in:It does not crash with release build within debugger.
Random crashes occuringto Crash when editing geometry node tree or curves in the graph editorChanged status from 'Needs User Info' to: 'Confirmed'
Not quite sure what module is responsible for this one, will assign to core.
Don't really want to raise priority, since I don't have a way to reproduce the issue reliably.
Added subscribers: @Sergey, @mont29
@iss not 100% sure, but your assert sounds a lot like a 'running out of memory' issue (
BLI_memarena_alloc
failing and returningNULL
).Regarding the original report, I think it actually shows a root issue in liboverrides diffing, in theory this process is only supposed to access data, but if it finds some changes that are not allowed, it tries to reset the values from linked data. This is done through RNA, which may call DEG update tagging and/or send notifiers to the window manager. Neither of these are threadsafe currently.
Talked already with @Sergey about it, we have two options:
While solution #2 is likely to have a performance impact (in case there are a lot of IDs needing some values resetting), it is probably much safer in absolute, since some RNA property value setting code can have other thread unsafe behaviors, like modifying other IDs etc. (think e.g. about material assignment code...).
Would also be good to check in the node editing code though, since it should not allow modifying non-editable liboverride values, some operators there likely need some modifications of their
poll
functions...Added subscriber: @SteffenD
This issue was referenced by
d05909a70c
Changed status from 'Confirmed' to: 'Needs User Info'
OK, so I never managed to reproduce the crash here, but made a fix based on the trace from original report.
You can find the code in branch
#102766
, and some builds on https://builder.blender.org/download/experimental/ (for a few days, also named#102766
).Please let me know if you can still reproduce the crash with these changes.
Added subscriber: @EvaVomhoff
@mont29 I have checked this with branch
#102766
and was not able to reproduce crashChanged status from 'Needs User Info' to: 'Resolved'