Addon: Storypencil clears all frame_change_post handlers #103028

New Issue

Thomas Lachmann · 2022-12-08T15:40:52+01:00

Thomas Lachmann commented

2022-12-08 15:40:52 +01:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94

Blender Version
Broken: version: 3.4.0, branch: blender-v3.4-release, commit date: 2022-12-06 18:46, hash: blender/blender@a95bf1ac01
Worked: ?

Storypencil Version: 1.1.1

Short description of error
Upon loading Storypencil clears all frame_change_post handlers.
This renders other addons unusable.

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94 **Blender Version** Broken: version: 3.4.0, branch: blender-v3.4-release, commit date: 2022-12-06 18:46, hash: `blender/blender@a95bf1ac01` Worked: ? **Storypencil Version: 1.1.1** **Short description of error** Upon loading Storypencil clears all frame_change_post handlers. This renders other addons unusable.

Thomas Lachmann commented

2022-12-08 15:40:52 +01:00

Added subscriber: @Lachi

Germano Cavalcante commented

2022-12-08 15:55:16 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2022-12-08 15:55:16 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2022-12-08 15:55:16 +01:00

There is indeed a bpy.app.handlers.frame_change_post.clear() in the code:
{https://developer.blender.org/diffusion/BA/browse/master/storypencil/init.py$178}

Doesn't seem like good practice.
I could be wrong but I'm confirming it as a bug for now.

There is indeed a `bpy.app.handlers.frame_change_post.clear()` in the code: {https://developer.blender.org/diffusion/BA/browse/master/storypencil/__init__.py$178} Doesn't seem like good practice. I could be wrong but I'm confirming it as a bug for now.

Antonio Vazquez commented

2022-12-08 17:19:59 +01:00

Added subscriber: @antoniov

Antonio Vazquez commented

2022-12-08 17:19:59 +01:00

Yes, it's a mistake...I guess it was a debug line that we did not replaced with the right one.

EDIT:

I guess the right code is:

if bpy.app.handlers.frame_change_post:
        bpy.app.handlers.frame_change_post.remove(synchro.on_frame_changed)

Yes, it's a mistake...I guess it was a debug line that we did not replaced with the right one. EDIT: I guess the right code is: ``` if bpy.app.handlers.frame_change_post: bpy.app.handlers.frame_change_post.remove(synchro.on_frame_changed) ```

Antonio Vazquez commented

2022-12-08 17:24:06 +01:00

Since we forgot to include the addon with the 3.4 release, we are preparing an improved version for 3.4.1.