Custom nodes appear in search results for tree types that don't support them #104313

New Issue

Netherby · 2023-02-03T01:06:31+01:00

Netherby commented

2023-02-03 01:06:31 +01:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94

Blender Version
Broken: version: 3.4.0, branch: blender-v3.4-release, commit date: 2022-12-06 18:46, hash: a95bf1ac01
Worked: 3.3

Short description of error
Custom nodes created for custom node trees now appear in the search results when adding nodes to the built-in tree types (Shader, Geometry, etc)

Exact steps for others to reproduce the error
Exact steps are somewhat complicated since you need to have python script create a custom node tree type along with nodes to go in it and register them... But if you have an add-on or script that creates custom nodes not meant to show up in the Shader node tree and search for them by name while in the Shader node editor they now appear in the search results and can be added to the tree since 3.4. In the previous version they did not appear in search results and could not be added in this way.

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94 **Blender Version** Broken: version: 3.4.0, branch: blender-v3.4-release, commit date: 2022-12-06 18:46, hash: `a95bf1ac01` Worked: 3.3 **Short description of error** Custom nodes created for custom node trees now appear in the search results when adding nodes to the built-in tree types (Shader, Geometry, etc) **Exact steps for others to reproduce the error** Exact steps are somewhat complicated since you need to have python script create a custom node tree type along with nodes to go in it and register them... But if you have an add-on or script that creates custom nodes not meant to show up in the Shader node tree and search for them by name while in the Shader node editor they now appear in the search results and can be added to the tree since 3.4. In the previous version they did not appear in search results and could not be added in this way.

Netherby commented

2023-02-03 01:06:31 +01:00

Added subscriber: @JerahmyPocott

Pratik Borhade commented

2023-02-03 06:05:25 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2023-02-03 06:05:25 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Pratik Borhade commented

2023-02-03 06:05:25 +01:00

Hi, thanks for the report. Can not reproduce here with python Custom Node template.
Could you check again in latest 3.5 builds with factory settings?: https://builder.blender.org/download/daily/

Hi, thanks for the report. Can not reproduce here with python `Custom Node` template. Could you check again in latest 3.5 builds with factory settings?: https://builder.blender.org/download/daily/

Leon Schittek commented

2023-02-03 06:19:07 +01:00

Added subscriber: @lone_noel

Leon Schittek commented

2023-02-03 06:19:07 +01:00

Hi, there was a report similar to this a while a go in #101259. @JerahmyPocott, could you check if that sounds like the same issue to you?
If that's the case, you might need to update your custom nodes. There was a solution discussed in the comments, see #101259#1423746 and the few posts following

Hi, there was a report similar to this a while a go in #101259. @JerahmyPocott, could you check if that sounds like the same issue to you? If that's the case, you might need to update your custom nodes. There was a solution discussed in the comments, see #101259#1423746 and the few posts following

CarlottaKrajcik commented

2023-02-03 06:49:57 +01:00

(Migrated from localhost:3001)

Added subscriber: @CarlottaKrajcik

CarlottaKrajcik commented

2023-02-03 06:49:57 +01:00

(Migrated from localhost:3001)

This comment was removed by @CarlottaKrajcik

*This comment was removed by @CarlottaKrajcik*

Thomas Dinges commented

2023-02-03 11:42:46 +01:00

Added subscriber: @ThomasDinges

Netherby commented

2023-02-04 22:47:11 +01:00

Yes this appears to be the same issue where the template order causes the problem. Using the 'Custom Nodes' template included in Blender, having the node class defined as

class MyCustomNode(Node, MyCustomTreeNode): # Node appears incorrectly in search

class MyCustomNode(MyCustomTreeNode, Node): # Now is hidden as expected

Previously examples showed the order as the first case.. Going forward, I assume the Blender class should always be the last template in custom nodes and sockets?

Yes this appears to be the same issue where the template order causes the problem. Using the 'Custom Nodes' template included in Blender, having the node class defined as ``` class MyCustomNode(Node, MyCustomTreeNode): # Node appears incorrectly in search class MyCustomNode(MyCustomTreeNode, Node): # Now is hidden as expected ``` Previously examples showed the order as the first case.. Going forward, I assume the Blender class should always be the last template in custom nodes and sockets?

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Custom nodes appear in search results for tree types that don't support them #104313