Screen shot operator missing control for "Full Screen" option #28107

New Issue

Chris Want · 2011-07-28T21:07:52+02:00

Chris Want commented

2011-07-28 21:07:52 +02:00

%%%Hi there,

I've been trying to make a screen shot of a subwindow in Blender,
but there doesn't appear to be an option for this.

Digging deeper, it appears there is supposed to be a "Full Screen"
property for the screen shot operator, but it isn't showing up in
the interface (the save dialog says "Properties None").

The code I've been looking at in particular is in
/home/cwant/blender/bf-blender/blender/source/blender/editors/screen/screendump.c

In the function SCREEN_OT_screenshot(wmOperatorType *ot) there
are the lines defining a property for the operator:

prop= RNA_def_boolean(ot->srna, "full", 1, "Full Screen", "");
RNA_def_property_flag(prop, PROP_HIDDEN); /* hide because once the file sel is displayed, the option no longer does anything */

Changing the value from 1 to 0 in the first line causes the program to always save
the current area, rather than always saving full screen.
Commenting out the second line gives the option in the save dialog, but
as the comment says, the option does nothing.

Sorry, I don't understand the new architecture well enough to fix this issue.

Maybe there needs to be a second operator SCREEN_OT_screenshot_area() that
redefines the operator with the full screen flag equal to false?

Thanks,
Chris
%%%

%%%Hi there, I've been trying to make a screen shot of a subwindow in Blender, but there doesn't appear to be an option for this. Digging deeper, it appears there is supposed to be a "Full Screen" property for the screen shot operator, but it isn't showing up in the interface (the save dialog says "Properties None"). The code I've been looking at in particular is in /home/cwant/blender/bf-blender/blender/source/blender/editors/screen/screendump.c In the function SCREEN_OT_screenshot(wmOperatorType *ot) there are the lines defining a property for the operator: prop= RNA_def_boolean(ot->srna, "full", 1, "Full Screen", ""); RNA_def_property_flag(prop, PROP_HIDDEN); /* hide because once the file sel is displayed, the option no longer does anything */ Changing the value from 1 to 0 in the first line causes the program to always save the current area, rather than always saving full screen. Commenting out the second line gives the option in the save dialog, but as the comment says, the option does nothing. Sorry, I don't understand the new architecture well enough to fix this issue. Maybe there needs to be a second operator SCREEN_OT_screenshot_area() that redefines the operator with the full screen flag equal to false? Thanks, Chris %%%

Chris Want commented

2011-07-28 21:07:52 +02:00

Changed status to: 'Open'

Campbell Barton commented

2011-07-29 01:13:48 +02:00

%%%The issue here is that the screenshot is taken before the filesel shows so once you have the option displayed, its usless.

Possible fixes are...

different hot keys for fullscreen/subwindow.
screenshot both, then the option within the file selector can be made to function.
screenshot all and crop after (depending on the option in the fileselctor)
have a menu what you want to screenshot before the filesel loads, annoting and will probably be grabbed too (unless you do some trick with a timer).
%%%

%%%The issue here is that the screenshot is taken before the filesel shows so once you have the option displayed, its usless. Possible fixes are... - different hot keys for fullscreen/subwindow. - screenshot both, then the option within the file selector can be made to function. - screenshot all and crop after (depending on the option in the fileselctor) - have a menu what you want to screenshot before the filesel loads, annoting and will probably be grabbed too (unless you do some trick with a timer). %%%

Chris Want commented

2011-07-29 16:37:38 +02:00

%%%Perhaps this is a radical suggestion: would it be possible to take the screen shot after selecting the file? This would not only prevent the full screen problem, but would also potentially fix another problem: when you use the space bar to search for the screen shot operator, the search panel gets included in the screenshot (I can think of only a few cases where that would be desirable).

%%%

%%%Perhaps this is a radical suggestion: would it be possible to take the screen shot *after* selecting the file? This would not only prevent the full screen problem, but would also potentially fix another problem: when you use the space bar to search for the screen shot operator, the search panel gets included in the screenshot (I can think of only a few cases where that would be desirable). %%%

Chris Want commented

2011-07-29 17:00:34 +02:00

%%%By the way, attached is a patch that implements a solution that does Screenshot All/Subwindow.
The hotkey doesn't seem to work. If it did work, the hotkey for Screenshot All and Screenshot Subwindow
would be reversed from the convention in Blender 2.4x.%%%

%%%By the way, attached is a patch that implements a solution that does Screenshot All/Subwindow. The hotkey doesn't seem to work. If it did work, the hotkey for Screenshot All and Screenshot Subwindow would be reversed from the convention in Blender 2.4x.%%%

Chris Want commented

2011-07-29 17:01:47 +02:00

%%%Here is the file (new interface for attachments in bug tracker is a bit strange).%%%