Duplicate long shapekey names crash Blender #29337

New Issue

Thomas Larsson · 2011-11-20T15:52:19+01:00

Thomas Larsson commented

2011-11-20 15:52:19 +01:00

%%%Blender 2.60.5, r42004, Win 7 64 bit

The following code makes Blender hang. The problem is evidently that long shapekey names are not truncated uniquely.

import bpy

def makeShapeKey(name):

  bpy.ops.object.shape_key_add(from_mix=False)
  skey = bpy.context.object.active_shape_key
  skey.name = name
  return

makeShapeKey("Basis")
makeShapeKey("This-is-a-very-long-shape-key-name-number-1")
makeShapeKey("This-is-a-very-long-shape-key-name-number-2")

%%%

%%%Blender 2.60.5, r42004, Win 7 64 bit The following code makes Blender hang. The problem is evidently that long shapekey names are not truncated uniquely. ------------------------------------------- import bpy def makeShapeKey(name): ``` bpy.ops.object.shape_key_add(from_mix=False) skey = bpy.context.object.active_shape_key skey.name = name return ``` makeShapeKey("Basis") makeShapeKey("This-is-a-very-long-shape-key-name-number-1") makeShapeKey("This-is-a-very-long-shape-key-name-number-2") %%%

Thomas Larsson commented

2011-11-20 15:52:19 +01:00

Changed status to: 'Open'

Sergey Sharybin commented

2011-11-21 08:28:26 +01:00

%%%Will look into this issue.%%%

Sergey Sharybin commented

2011-11-21 09:00:41 +01:00

%%%Hrm, noticed two things. First is that it's not so simle to assign bugs to myself in google chrome - "Assigned To" is getting reset when focus is leaing combobox, but it's side note.

About this hung. Looks like it's old issue in code which makes names unique. Attached patch should solve this, but it's code used all over so extra eyes on checing it are welcome. Mabe Campbell can help here?%%%

%%%Hrm, noticed two things. First is that it's not so simle to assign bugs to myself in google chrome - "Assigned To" is getting reset when focus is leaing combobox, but it's side note. About this hung. Looks like it's old issue in code which makes names unique. Attached patch should solve this, but it's code used all over so extra eyes on checing it are welcome. Mabe Campbell can help here?%%%

Sergey Sharybin commented

2011-11-21 11:57:13 +01:00

%%%Discussed with Campbell. Its more complicated fix which chould be performed here: at every string clamp itteration string should be verified if it's still a valid utf8 sequence.
Just a not which should be taken into account if somebod would want to commit or use this patch.%%%

%%%Discussed with Campbell. Its more complicated fix which chould be performed here: at every string clamp itteration string should be verified if it's still a valid utf8 sequence. Just a not which should be taken into account if somebod would want to commit or use this patch.%%%

Brecht Van Lommel commented

2011-11-23 15:55:49 +01:00

%%%Seems this was fixed but the report not closed yet.
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=42029%%%

%%%Seems this was fixed but the report not closed yet. http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=42029%%%

Brecht Van Lommel commented

2011-11-23 15:55:49 +01:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2011-11-23 15:55:49 +01:00

Sign in to join this conversation.