file/save crashes when target path isnt found #29537

New Issue

mike marsh · 2011-12-08T06:33:18+01:00

mike marsh commented

2011-12-08 06:33:18 +01:00

%%%Blender 26.6 crashes when you try to save to a destination that is not ready. While trying to save to a removable flash drive, I clicked ok befor the flash drive was in my computer. A notice came up saying it was not ready, and then locked up. No buttons would work. "cancel" ,"retry" or "continue". only way out was to use task manager to close Blender.%%%

mike marsh commented

2011-12-08 06:33:18 +01:00

Changed status to: 'Open'

Sergey Sharybin commented

2011-12-09 12:58:40 +01:00

%%%Developer note: crash might happen because of how uiPopupMenuSaveOver works and used in wm_save_mainfile_invoke: it's getting called from invoke function and in case file doesn't exist it executes operator rather than showing popup. operator_cb is used for this which runs WM_operator_call which (indirectly) frees operator and this leads to reading freed memory in original's wm_operator_invoke call.
Here's valgrind output: http://www.pasteall.org/27233
Easy to reproduce: save file, remove it outside of blender, hit Ctrl-S%%%

%%%Developer note: crash might happen because of how uiPopupMenuSaveOver works and used in wm_save_mainfile_invoke: it's getting called from invoke function and in case file doesn't exist it executes operator rather than showing popup. operator_cb is used for this which runs WM_operator_call which (indirectly) frees operator and this leads to reading freed memory in original's wm_operator_invoke call. Here's valgrind output: http://www.pasteall.org/27233 Easy to reproduce: save file, remove it outside of blender, hit Ctrl-S%%%

Sergey Sharybin commented

2011-12-09 13:36:28 +01:00

%%%Another note: Function is called uiPupMenuSaveOver, but it's not a problem Problem that some more operatosr are using WM_operator_call from invoke(). Not sure, probably WM_operator_call should be changed in a way it's not freeing operator itself. Can be done by separating wm_operator_exec in such way: http://www.pasteall.org/27234/diff
Probably better not to perform such kind of changes just before release and rethink this WM_operator_call for 2.62.%%%

%%%Another note: Function is called uiPupMenuSaveOver, but it's not a problem Problem that some more operatosr are using WM_operator_call from invoke(). Not sure, probably WM_operator_call should be changed in a way it's not freeing operator itself. Can be done by separating wm_operator_exec in such way: http://www.pasteall.org/27234/diff Probably better not to perform such kind of changes just before release and rethink this WM_operator_call for 2.62.%%%

Campbell Barton commented

2011-12-12 19:06:50 +01:00

%%%fixed 42583.%%%

Campbell Barton commented

2011-12-12 19:06:50 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2011-12-12 19:06:50 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

file/save crashes when target path isnt found #29537