Can only alt+scroll image buffer slot once #30430

Closed
opened 2012-03-02 18:55:48 +01:00 by Ejner Fergo · 5 comments

%%%This is a minor issue but it still bugs me. In the UV/Image Editor, I want to cycle through the image buffers with alt+scroll on the slot list on the header. Problem is this only works once, since the next scroll will change the frame by 1. I have to move the mouse slightly on the slot list every time I want to alt+scroll to the next buffer. This is only on the header. Doing it in the properties (N-key) I can scroll through the whole list without moving the mouse. Unfortunately there's also a minor issue here in the properties. Since an empty buffer doesn't have a Curves panel, the whole interface jumps up and the slot list is no longer under the mouse. It is much preferable doing this on the header anyway.

OS: Linux
Tested on revision 44546 - 44608
%%%

%%%This is a minor issue but it still bugs me. In the UV/Image Editor, I want to cycle through the image buffers with alt+scroll on the slot list on the header. Problem is this only works once, since the next scroll will change the frame by 1. I have to move the mouse slightly on the slot list every time I want to alt+scroll to the next buffer. This is only on the header. Doing it in the properties (N-key) I can scroll through the whole list without moving the mouse. Unfortunately there's also a minor issue here in the properties. Since an empty buffer doesn't have a Curves panel, the whole interface jumps up and the slot list is no longer under the mouse. It is much preferable doing this on the header anyway. OS: Linux Tested on revision 44546 - 44608 %%%
Author

Changed status to: 'Open'

Changed status to: 'Open'

%%%Developer's note:
Issue is caused by mapping old buttons to new buttons. Render slot button in header holds RenerResult for particular slot, but in N-panel it hols RenderResult from RenderEngine. So what's happening is: switching render slot to empty slot makes slot button in header contain NULL as button function's argument, but old button holds RenderResult for rendereed image, so this two buttons aren't equal and so button isn't getting activated and no scrolling happens.
Making slot button hold RenderResult directly from RenderEngine (as it's happening with buttons in N-panel) makes old->new buttons mapping work correct and it's possible to alt-scroll smoothly. Looks quite safe change, but maybe Brecht can verify this (patch is in attachments)?%%%

%%%Developer's note: Issue is caused by mapping old buttons to new buttons. Render slot button in header holds RenerResult for particular slot, but in N-panel it hols RenderResult from RenderEngine. So what's happening is: switching render slot to empty slot makes slot button in header contain NULL as button function's argument, but old button holds RenderResult for rendereed image, so this two buttons aren't equal and so button isn't getting activated and no scrolling happens. Making slot button hold RenderResult directly from RenderEngine (as it's happening with buttons in N-panel) makes old->new buttons mapping work correct and it's possible to alt-scroll smoothly. Looks quite safe change, but maybe Brecht can verify this (patch is in attachments)?%%%

%%%Patch looks ok to me, please commit :)%%%

%%%Patch looks ok to me, please commit :)%%%

%%%Commited to svn rev45168.
Thanks for both of report and review.Closing now.%%%

%%%Commited to svn rev45168. Thanks for both of report and review.Closing now.%%%

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#30430
No description provided.