setGLSLMaterialSetting has no effect #31757

New Issue

Thomas Szepe · 2012-06-08T18:23:32+02:00

Thomas Szepe commented

2012-06-08 18:23:32 +02:00

Category: Python

%%%SetGLSLMaterialSetting is not working on Blender higher than version 2.59.
I have tried it with lights, shadows, shaders and extra_textures, no parameter is working.

Tested with Blender:
2.59 = working
2.62 = not working
2.63a = not working
2.63.10 = not working

Windows XP 32 Bit
Intel Q9300
Nvida GeForce GTX 460

Attached is a Blender 2.59 example.%%%

**Category**: Python %%%SetGLSLMaterialSetting is not working on Blender higher than version 2.59. I have tried it with lights, shadows, shaders and extra_textures, no parameter is working. Tested with Blender: 2.59 = working 2.62 = not working 2.63a = not working 2.63.10 = not working Windows XP 32 Bit Intel Q9300 Nvida GeForce GTX 460 Attached is a Blender 2.59 example.%%%

Thomas Szepe commented

2012-06-08 18:23:32 +02:00

Changed status to: 'Open'

Dalai Felinto commented

2012-06-09 01:17:30 +02:00

%%%confirmed (the file is missing its textures btw).

In 2.59, however, the GLSL setting is left 'alive' even after we quit the bge.
I think this was introduced when I fixed exactly that (with the GlobalSettings patch). I will investigate%%%

%%%confirmed (the file is missing its textures btw). In 2.59, however, the GLSL setting is left 'alive' even after we quit the bge. I think this was introduced when I fixed exactly that (with the GlobalSettings patch). I will investigate%%%

Dalai Felinto commented

2012-06-09 01:53:16 +02:00

%%%ok I found the problem. In gpu_material.c Blender is checking for the flags in the mat->scene, not in the globalsettings.

Since this is a shared function for both BGE and Blender I'm not sure what is the best way to solve that.
One option is to store in KX_Scene the original flag and re-set Blender flags when we leave BGE.

Brecht, do you have any suggestion on a clean way of solving this?

For the records, the patch below reproduce 2.59 behaviour:

Index: source/gameengine/Ketsji/KX_PythonInit.cpp

- source/gameengine/Ketsji/KX_PythonInit.cpp	(revision 47633)

+++ source/gameengine/Ketsji/KX_PythonInit.cpp (working copy)
@@ -1169,6 +1169,10 @@
}
}

/* temporarily store the glsl settings in the scene for the GLSL materials */
GameData *gm= &(gp_KetsjiScene->GetBlenderScene()->gm);
gm->flag = gs->glslflag;
Py_RETURN_NONE;
}

(and also confirmed that the bug was introduced with the fix in rev. 40113)%%%

%%%ok I found the problem. In gpu_material.c Blender is checking for the flags in the mat->scene, not in the globalsettings. Since this is a shared function for both BGE and Blender I'm not sure what is the best way to solve that. One option is to store in KX_Scene the original flag and re-set Blender flags when we leave BGE. Brecht, do you have any suggestion on a clean way of solving this? For the records, the patch below reproduce 2.59 behaviour: Index: source/gameengine/Ketsji/KX_PythonInit.cpp **** - source/gameengine/Ketsji/KX_PythonInit.cpp (revision 47633) +++ source/gameengine/Ketsji/KX_PythonInit.cpp (working copy) @@ -1169,6 +1169,10 @@ } } + /* temporarily store the glsl settings in the scene for the GLSL materials */ + GameData *gm= &(gp_KetsjiScene->GetBlenderScene()->gm); + gm->flag = gs->glslflag; + Py_RETURN_NONE; } (and also confirmed that the bug was introduced with the fix in rev. 40113)%%%

Thomas Szepe commented

2012-06-10 09:59:55 +02:00

%%%I change the place of your changing from line 1169 to 1154, because otherwise switching on and off is inverted.

Index: KX_PythonInit.cpp

- KX_PythonInit.cpp	(revision 47596)

+++ KX_PythonInit.cpp (working copy)

@@ -1154,6 +1154,10 @@
else
gs->glslflag |= flag;

/* temporarily store the glsl settings in the scene for the GLSL materials */
GameData *gm= &(gp_KetsjiScene->GetBlenderScene()->gm);
gm->flag = gs->glslflag;
/* display lists and GLSL materials need to be remade */
if (sceneflag != gs->glslflag) {
GPU_materials_free();
%%%

%%%I change the place of your changing from line 1169 to 1154, because otherwise switching on and off is inverted. Index: KX_PythonInit.cpp **** - KX_PythonInit.cpp (revision 47596) +++ KX_PythonInit.cpp (working copy) @@ -1154,6 +1154,10 @@ else gs->glslflag |= flag; + /* temporarily store the glsl settings in the scene for the GLSL materials */ + GameData *gm= &(gp_KetsjiScene->GetBlenderScene()->gm); + gm->flag = gs->glslflag; + /* display lists and GLSL materials need to be remade */ if (sceneflag != gs->glslflag) { GPU_materials_free(); %%%

Brecht Van Lommel commented

2012-06-11 16:29:57 +02:00

%%%This indeed seems to be the easiest solution, I'm ok with this fix.%%%

Angus Hollands commented

2012-06-18 20:19:29 +02:00

%%%Should this be closed?%%%

Dalai Felinto commented

2012-06-21 08:15:02 +02:00

%%%hi Angus,
this can't be closed (no commit was done to address that). I'm assigning to Mitchell in case he wants to implement the solution discussed above.
(the above patch + the changes in KX_Scene to store the initial glsl settings, although that requires testing).%%%

%%%hi Angus, this can't be closed (no commit was done to address that). I'm assigning to Mitchell in case he wants to implement the solution discussed above. (the above patch + the changes in KX_Scene to store the initial glsl settings, although that requires testing).%%%

Florian Voelker commented

2012-12-14 16:44:02 +01:00

%%%The problem isn't fixed until now.
Is there someone who can investigate into this problem?
It seems to be solved by Dalai Felinto and HG1, but it's still not fixed in trunk.
It would be very cool if someone can fix it.%%%

%%%The problem isn't fixed until now. Is there someone who can investigate into this problem? It seems to be solved by Dalai Felinto and HG1, but it's still not fixed in trunk. It would be very cool if someone can fix it.%%%

Mitchell Stokes commented

2012-12-24 04:41:06 +01:00

%%%I'm assigning this to Dalai; I never took much of a look at the patch.%%%

Florian Voelker commented

2013-03-26 13:18:23 +01:00

%%%Hi,
is there any possible fix for the function now?
I would like to see a function which works. :)
Thank you guys for investigating.%%%

%%%Hi, is there any possible fix for the function now? I would like to see a function which works. :) Thank you guys for investigating.%%%

Florian Voelker commented

2013-05-08 23:33:20 +02:00

%%%The mentioned fix from HG1 works perfectly.
I'd updated it for the newest revision.

Index: source/gameengine/Ketsji/KX_PythonInit.cpp

- source/gameengine/Ketsji/KX_PythonInit.cpp	(revision 56527)

+++ source/gameengine/Ketsji/KX_PythonInit.cpp (working copy)
@@ -1182,7 +1182,13 @@
gs->glslflag &= ~flag;
else
gs->glslflag |= flag;
+

/* temporarily store the glsl settings in the scene for the GLSL materials */
GameData *gm= &(gp_KetsjiScene->GetBlenderScene()->gm);
gm->flag = gs->glslflag;
/* display lists and GLSL materials need to be remade */
if (sceneflag != gs->glslflag) {
GPU_materials_free();%%%

%%%The mentioned fix from HG1 works perfectly. I'd updated it for the newest revision. Index: source/gameengine/Ketsji/KX_PythonInit.cpp **** - source/gameengine/Ketsji/KX_PythonInit.cpp (revision 56527) +++ source/gameengine/Ketsji/KX_PythonInit.cpp (working copy) @@ -1182,7 +1182,13 @@ gs->glslflag &= ~flag; else gs->glslflag |= flag; + + /* temporarily store the glsl settings in the scene for the GLSL materials */ + GameData *gm= &(gp_KetsjiScene->GetBlenderScene()->gm); + gm->flag = gs->glslflag; + /* display lists and GLSL materials need to be remade */ if (sceneflag != gs->glslflag) { GPU_materials_free();%%%

Dalai Felinto commented

2013-05-08 23:44:30 +02:00

%%%patch committed on rev. 56605
thanks everyone for contributing to that.

Sorry about the long delay, but I've been too busy lately%%%

%%%patch committed on rev. 56605 thanks everyone for contributing to that. Sorry about the long delay, but I've been too busy lately%%%

Dalai Felinto commented

2013-05-08 23:44:30 +02:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2013-05-08 23:44:30 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

setGLSLMaterialSetting has no effect #31757