Autosave ignores multires sculpting (patch attached) #32209

New Issue

Nicholas Bishop · 2012-07-28T19:19:29+02:00

Nicholas Bishop commented

2012-07-28 19:19:29 +02:00

%%%Steps to reproduce from the default cube:

Add multires and subdivide five times (exact number of subdivisions doesn't matter)
Enable sculpt mode
Sculpt a brush stroke on the mesh
Wait for an autosave to occur
Open the autosave file

Result: the autosaved file will show an unmodified mesh (missing the brush stroke.)

Regular file save calls ED_sculpt_force_update() to correct this, but autosave doesn't seem to have the right context. I've attached a patch that seems to work, looping over all meshes via G.main, but as I'm not familiar with this part of the code I'd like confirmation this is OK.%%%

%%%Steps to reproduce from the default cube: 1) Add multires and subdivide five times (exact number of subdivisions doesn't matter) 2) Enable sculpt mode 3) Sculpt a brush stroke on the mesh 4) Wait for an autosave to occur 5) Open the autosave file Result: the autosaved file will show an unmodified mesh (missing the brush stroke.) Regular file save calls ED_sculpt_force_update() to correct this, but autosave doesn't seem to have the right context. I've attached a patch that seems to work, looping over all meshes via G.main, but as I'm not familiar with this part of the code I'd like confirmation this is OK.%%%

Nicholas Bishop commented

2012-07-28 19:19:29 +02:00

Changed status to: 'Open'

Sergey Sharybin commented

2012-07-30 21:51:10 +02:00

%%%Nick, would check your patch.%%%

Sergey Sharybin commented

2012-08-01 11:05:16 +02:00

%%%Fixed in svn rev49438. Thanks for the report and patch, closing now.%%%

Sergey Sharybin commented

2012-08-01 11:05:16 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2012-08-01 11:05:16 +02:00

Jonathan Ringstad commented

2014-08-08 23:49:58 +02:00

Changed status from 'Resolved' to: 'Open'

Jonathan Ringstad reopened this issue

2014-08-08 23:49:58 +02:00

Jonathan Ringstad commented

2014-08-08 23:49:58 +02:00

Added subscriber: @Amadiro

Jonathan Ringstad commented

2014-08-08 23:49:58 +02:00

This seems to be an issue again with 2.71 (772af36).

To reproduce:

open blender
in preferences, set autosave to 1 minute
save preferences, quit blender
open blender with default scene
go into sculpt mode
manipulate cube
leave blender running for 5 minutes, without exiting sculpt mode
kill blender forcefully

When recovering the autosave afterwards, the sculpted changes are not there. Just lost about an hour of sculpting work that way.

This seems to be an issue again with 2.71 (772af36). To reproduce: - open blender - in preferences, set autosave to 1 minute - save preferences, quit blender - open blender with default scene - go into sculpt mode - manipulate cube - leave blender running for 5 minutes, without exiting sculpt mode - kill blender forcefully When recovering the autosave afterwards, the sculpted changes are not there. Just lost about an hour of sculpting work that way.

Jonathan Ringstad commented

2014-08-09 01:02:50 +02:00

Confirmed with a freshly built blender (ee8dafe). Upping priority to "high", which seems appropriate, since this can cause total loss of the users work.

Confirmed with a freshly built blender (ee8dafe). Upping priority to "high", which seems appropriate, since this can cause total loss of the users work.

Sergey Sharybin commented

2014-08-11 09:13:48 +02:00

Added subscriber: @Psy-Fi

Sergey Sharybin commented

2014-08-11 09:13:48 +02:00

Please don't triage priority by self. For every reporter his own report is top-prio, no doubts. But this confuses our bug smashing process.

Me or @Psy-Fi will have a look asap.

Please don't triage priority by self. For every reporter his own report is top-prio, no doubts. But this confuses our bug smashing process. Me or @Psy-Fi will have a look asap.

Sergey Sharybin was unassigned by Antonis Ryakiotakis

2014-08-11 15:53:57 +02:00

Antonis Ryakiotakis self-assigned this 2014-08-11 15:53:57 +02:00

Antonis Ryakiotakis commented

2014-08-11 17:05:55 +02:00

Added subscriber: @ideasman42

Antonis Ryakiotakis commented

2014-08-11 17:05:55 +02:00

OK, this is undo related. The issue is that we write the undo stack in the file which pretty much ignores the edit stacks completely (same would happen in edit mode). Issue also exists with quit.blend.

@ideasman42 can you take a look at the attached patch?

OK, this is undo related. The issue is that we write the undo stack in the file which pretty much ignores the edit stacks completely (same would happen in edit mode). Issue also exists with quit.blend. @ideasman42 can you take a look at the attached patch?

blender-admin commented

2014-10-10 12:04:44 +02:00

This issue was referenced by 585d2f31a9

This issue was referenced by 585d2f31a9c438bddb63842b2f160236323e355b

Antonis Ryakiotakis commented

2014-10-10 12:05:14 +02:00

Changed status from 'Open' to: 'Resolved'

Antonis Ryakiotakis closed this issue

2014-10-10 12:05:14 +02:00

Antonis Ryakiotakis commented

2014-10-10 12:05:14 +02:00

Closed by commit 585d2f31a9.

Closed by commit 585d2f31a9.

Antonis Ryakiotakis commented

2014-10-13 11:22:36 +02:00

After discussion we agreed that we wouldn't want to slow down autosave - remember it gets called even during rendering, it should really be as fast as possible.

Anyway, I think solution here is to warn explicitly that edit mode and sculpt mode are not supported here.

After discussion we agreed that we wouldn't want to slow down autosave - remember it gets called even during rendering, it should really be as fast as possible. Anyway, I think solution here is to warn explicitly that edit mode and sculpt mode are not supported here.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Autosave ignores multires sculpting (patch attached) #32209