Crash when flipping names of bones #33074

New Issue

Alberto Torres Ruiz · 2012-11-03T23:03:53+01:00

2012-11-03 23:03:53 +01:00

%%%- Have two mirrored bones, Bone_L and Bone_R

Have an object parented to Bone_R
In edit mode, with X-mirror disabled, delete Bone_R
Duplicate Bone_L and press W -> flip names
Crash

It doesn't occur if you exit and reenter edit mode between steps 3 and 4.%%%

%%%- Have two mirrored bones, Bone_L and Bone_R - Have an object parented to Bone_R - In edit mode, with X-mirror disabled, delete Bone_R - Duplicate Bone_L and press W -> flip names - Crash It doesn't occur if you exit and reenter edit mode between steps 3 and 4.%%%

Alberto Torres Ruiz commented

2012-11-03 23:03:53 +01:00

Changed status to: 'Open'

Ben Batt commented

2012-11-04 05:43:45 +01:00

%%%To clarify, regarding "It doesn't occur if you exit and reenter edit mode...", this means "after duplicating Bone_L". That's what I'm seeing, anyway.

The crash is happening because duplicating Bone_L creates a pose channel that doesn't point to a bone (since only an edit mode bone object exists at that point). Then the "Flip Names" command renames the pose channel to Bone_R, so the bone parenting code finds it and tries to get the length of the non-existent bone, causing a crash. Exiting and re-entering edit mode creates a proper bone object and hooks it up to the pose channel, so the crash doesn't occur.

It seems like the fix is to just check for the existence of the bone as well as the pose channel in the parenting code? This means flipping bone names won't hook up parented objects correctly until you exit edit mode, but that seems like an acceptable compromise.

Another possibility is to find the EditBone and use its length instead; I'm looking into this now.%%%

%%%To clarify, regarding "It doesn't occur if you exit and reenter edit mode...", this means "after duplicating Bone_L". That's what I'm seeing, anyway. The crash is happening because duplicating Bone_L creates a pose channel that doesn't point to a bone (since only an edit mode bone object exists at that point). Then the "Flip Names" command renames the pose channel to Bone_R, so the bone parenting code finds it and tries to get the length of the non-existent bone, causing a crash. Exiting and re-entering edit mode creates a proper bone object and hooks it up to the pose channel, so the crash doesn't occur. It seems like the fix is to just check for the existence of the bone as well as the pose channel in the parenting code? This means flipping bone names won't hook up parented objects correctly until you exit edit mode, but that seems like an acceptable compromise. Another possibility is to find the EditBone and use its length instead; I'm looking into this now.%%%

Ben Batt commented

2012-11-04 06:22:29 +01:00

%%%Hmm, finding the EditBone and use its length would require blenkernel/intern/object.c to include editors/include/ED_armature.h, which seems like a bad idea. A patch to bail out of bone parenting if the pose channel has no bone is attached.%%%

Ton Roosendaal commented

2012-11-04 12:41:51 +01:00

%%%Hey Ben - good to see you here again. I'd be happy to back your svn account so you commit yourself?%%%

Ton Roosendaal commented

2012-11-04 13:13:27 +01:00

%%%Syncing armature data and pose channels always has been a bit weak in this design.
It was based on old 2.0 design - attempt to have 1 object sharing many armatures in different ways. That's a feature we don't use really - especially now we have group instancing for entire characters.

I think the basic fix from Ben is acceptable for this call. In armature editmode pose channels are not used or visible really.

BTW: ED_ api calls indeed have to stay inside the editors/ directory!%%%

%%%Syncing armature data and pose channels always has been a bit weak in this design. It was based on old 2.0 design - attempt to have 1 object sharing many armatures in different ways. That's a feature we don't use really - especially now we have group instancing for entire characters. I think the basic fix from Ben is acceptable for this call. In armature editmode pose channels are not used or visible really. BTW: ED_ api calls indeed have to stay inside the editors/ directory!%%%

Ton Roosendaal commented

2012-11-04 13:13:28 +01:00

Changed status from 'Open' to: 'Resolved'

Ton Roosendaal closed this issue

2012-11-04 13:13:28 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when flipping names of bones #33074