Smooting shape key vertices with sculpt collapses masked vertices to object origin #33078

Closed
opened 2012-11-04 12:12:58 +01:00 by Eli Peters · 12 comments

%%%When in sculpt mode and using the smooth tool on a shape key causes all masked vertices to collapse to object origin.

Attached is a cube with subdivisions and masked vertices. Unmask to see unaltered mesh vertices. Mask to hide selected vertices. Use the smooth tool on cube. Unmask to see bug result.

Tested on PC (laptop) and Mac.%%%

%%%When in sculpt mode and using the smooth tool on a shape key causes all masked vertices to collapse to object origin. Attached is a cube with subdivisions and masked vertices. Unmask to see unaltered mesh vertices. Mask to hide selected vertices. Use the smooth tool on cube. Unmask to see bug result. Tested on PC (laptop) and Mac.%%%
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

%%%Relates to: 32943%%%

%%%Relates to: 32943%%%
Member

%%%Brecht, can you check if this relates to 32943? Otherwise we can ask Nicholas too :)%%%

%%%Brecht, can you check if this relates to 32943? Otherwise we can ask Nicholas too :)%%%

%%%It's unrelated, the other report was a simple error in the VBO drawing. I'll assign to Nicholas but will take a look into it to see if I can fix.%%%

%%%It's unrelated, the other report was a simple error in the VBO drawing. I'll assign to Nicholas but will take a look into it to see if I can fix.%%%

%%%I can't see anything collapsing in this file, testing with latest svn on Mac. One issue here is that the shape key being sculpted has weight 0.0, so brushes do nothing. That's not a bug, set the weight to 1.0 and it will work.

The second issue I see, which is a bug, is that masks don't show at all there are shape keys. The hidden faces are also not drawn hidden in that case.%%%

%%%I can't see anything collapsing in this file, testing with latest svn on Mac. One issue here is that the shape key being sculpted has weight 0.0, so brushes do nothing. That's not a bug, set the weight to 1.0 and it will work. The second issue I see, which is a bug, is that masks don't show at all there are shape keys. The hidden faces are also not drawn hidden in that case.%%%
Author

%%%Hi Brecht,

Maybe it is my terminology that is confusing? Mask is not the proper term here. I should have said hidden vertices. If you click on the cube with the smooth tool in sculpt mode then change to edit mode to unhide the vertices all hidden vertices have moved to the origin of the model.

I see the brush weight for smooth tool in the uploaded file is set to 0.5 (default setting) so not sure why you are seeing a value of 0.0 - I am sure this is a bug as I have tested on both mac and pc and get the same result.

If you are saying that this isn't a bug then I guess I will just have to live with the fact that I can not use smooth tools on shape keys.%%%

%%%Hi Brecht, Maybe it is my terminology that is confusing? Mask is not the proper term here. I should have said hidden vertices. If you click on the cube with the smooth tool in sculpt mode then change to edit mode to unhide the vertices all hidden vertices have moved to the origin of the model. I see the brush weight for smooth tool in the uploaded file is set to 0.5 (default setting) so not sure why you are seeing a value of 0.0 - I am sure this is a bug as I have tested on both mac and pc and get the same result. If you are saying that this isn't a bug then I guess I will just have to live with the fact that I can not use smooth tools on shape keys.%%%

%%%I was referring to the value in the shape keys panel, not the brush weight, the shape key value is 0.0 so the shape keys is not actually going to be visible.

If all the vertices go back to the origin that's a bug, but it's not happening when testing it here.%%%

%%%I was referring to the value in the shape keys panel, not the brush weight, the shape key value is 0.0 so the shape keys is not actually going to be visible. If all the vertices go back to the origin that's a bug, but it's not happening when testing it here.%%%
Author

%%%Apologies, yes the Shape Key is set to 0.0. In fact the bug is more evident if the Basis key is selected before applying smooth.%%%

%%%Apologies, yes the Shape Key is set to 0.0. In fact the bug is more evident if the Basis key is selected before applying smooth.%%%
Author

%%%Hi Brecht,

I have posted a video of the bug in action http://youtu.be/YBHh-A9EXmo

:)%%%

%%%Hi Brecht, I have posted a video of the bug in action http://youtu.be/YBHh-A9EXmo :)%%%

%%%The bug may be that those faces draw at all. without the shape key the faces are hidden and can't be painted onto.

Sculpt code is doing paint_is_face_hidden() checks when calculating faces to paint onto, but then drawing all faces because the resulting mesh is a CDDM from the modifier stack.

How about ignore the hidden face check when '(cddm->pbvh && cddm->pbvh_draw)' is false?
... or have CDDM be able to skip hidden faces too.
%%%

%%%The bug may be that those faces draw at all. without the shape key the faces are hidden and can't be painted onto. Sculpt code is doing paint_is_face_hidden() checks when calculating faces to paint onto, but then drawing all faces because the resulting mesh is a CDDM from the modifier stack. How about ignore the hidden face check when '(cddm->pbvh && cddm->pbvh_draw)' is false? ... or have CDDM be able to skip hidden faces too. %%%

%%%This bug is fixed in r56465.
There is still the problem that hidden faces cant be painted onto. added todo.

added as TODO.
http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Tools#Sculpting
%%%

%%%This bug is fixed in r56465. There is still the problem that hidden faces cant be painted onto. added todo. added as TODO. http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Tools#Sculpting %%%

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#33078
No description provided.