list items in properties editor #35750

New Issue

Cezary Kopias · 2013-06-14T15:10:01+02:00

Cezary Kopias commented

2013-06-14 15:10:01 +02:00

%%%--- Operating System, Graphics card ---

- Blender version with error, and version that worked ---


- Short description of error ---

properties list items ( like vertex groups list ) dont use interface theme list items text colors

- Steps for others to reproduce the error (preferably based on attached .blend file) ---

see attached image
%%%

%%%--- Operating System, Graphics card --- - Blender version with error, and version that worked --- - Short description of error --- properties list items ( like vertex groups list ) dont use interface theme list items text colors - Steps for others to reproduce the error (preferably based on attached .blend file) --- see attached image %%%

Cezary Kopias commented

2013-06-14 15:10:01 +02:00

Changed status to: 'Open'

Thomas Dinges commented

2013-06-14 15:57:46 +02:00

%%%Dev note:
In interface_templates.c in uiTemplateList()
some of the "layout_type" cases define a custom but and pass over the "LISTROW" type, so the list theme works, others use a draw_item(). %%%

%%%Dev note: In interface_templates.c in uiTemplateList() some of the "layout_type" cases define a custom but and pass over the "LISTROW" type, so the list theme works, others use a draw_item(). %%%

Ton Roosendaal commented

2013-06-15 16:45:29 +02:00

%%%Assign to self!%%%

Ton Roosendaal commented

2013-06-15 18:36:20 +02:00

%%%I move it to Brecht's desk. He coded most of it, might now smarter solutions.

Currently, the only lists in Blender respecting theme color for "List Item" is when it gets defined entirely as LISTROW button. That's in File Select editor now.

In the uiTemplateList() code however, the button gets a NULL icon, and a "" string. This then gets added as LABEL type later.

I wonder if the itemL() function could somehow find out it's a member of a list via layout? Python defined lists then would go OK too;.%%%

%%%I move it to Brecht's desk. He coded most of it, might now smarter solutions. Currently, the only lists in Blender respecting theme color for "List Item" is when it gets defined entirely as LISTROW button. That's in File Select editor now. In the uiTemplateList() code however, the button gets a NULL icon, and a "" string. This then gets added as LABEL type later. I wonder if the itemL() function could somehow find out it's a member of a list via layout? Python defined lists then would go OK too;.%%%

Bastien Montagne commented

2013-06-25 15:40:46 +02:00

%%%Proposed patch: http://www.pasteall.org/43485

See also mail http://lists.blender.org/pipermail/bf-committers/2013-June/040970.html%%%

%%%Proposed patch: http://www.pasteall.org/43485 See also mail http://lists.blender.org/pipermail/bf-committers/2013-June/040970.html%%%

Brecht Van Lommel commented

2013-06-25 18:51:07 +02:00

%%%That's quite a few hacks, wouldn't adding a LISTLABEL type make the code cleaner?%%%

Bastien Montagne commented

2013-06-25 20:00:31 +02:00

%%%Yes… but it would mean the need to expose it to python (through RNA ui api , probably as an option to layout.label), and the need for all python uiList classes to use it instead of usual label… not straight forward for addons programmers. While current solution is hackish, but fully under the hood (i.e. end UI api user has nothing to do).

So I’d say it’s a trade-off, between something not-that-nice but which does not need any changes to actual UI code, and something cleaner but modifying the UI API (in a somewhat strange way, "use this option only inside list item draw functions").%%%

%%%Yes… but it would mean the need to expose it to python (through RNA ui api , probably as an option to layout.label), and the need for all python uiList classes to use it instead of usual label… not straight forward for addons programmers. While current solution is hackish, but fully under the hood (i.e. end UI api user has nothing to do). So I’d say it’s a trade-off, between something not-that-nice but which does not need any changes to actual UI code, and something cleaner but modifying the UI API (in a somewhat strange way, "use this option only inside list item draw functions").%%%

Thomas Dinges commented

2013-06-25 20:05:06 +02:00

%%%This is "only" a UI theme color bug, rather not introduce too many hacks for that.%%%

Brecht Van Lommel commented

2013-06-25 20:51:26 +02:00

%%%Ah, I wasn't suggesting to expose this to python, just to change the type of the labels inside the list automatically to a LISTLABEL (either changing but->type afterwards or doing it in uiItemL if a list is being created).%%%

Bastien Montagne commented

2013-06-25 20:53:33 +02:00

%%%Ah, ok, yes, that would avoid abusing UI_BUT_COLOR_LOCK at least… Working on it.%%%

Bastien Montagne commented

2013-06-25 21:25:34 +02:00

%%%Updated patch: http://www.pasteall.org/43496/diff

Compared to previous one, had to edit handler code too to take into account new button type.

Note I completely removed widget_state_label(), it actually does nothing more than widget_state (i.e. use text colors from default color set), afaict.%%%

%%%Updated patch: http://www.pasteall.org/43496/diff Compared to previous one, had to edit handler code too to take into account new button type. Note I completely removed widget_state_label(), it actually does nothing more than widget_state (i.e. use text colors from default color set), afaict.%%%

Cezary Kopias commented

2013-06-26 00:28:01 +02:00

%%%Could the same code be used to display those things? Could someone can explain this case?%%%

Brecht Van Lommel commented

2013-06-26 01:34:15 +02:00

%%%Bastien: patch looks good to me know. Only thing I would change still is to replace the do / while loop with a simple for loop. Probably it works fine the way this function is called here but no need to introduce the risk of a NULL pointer access for the first item.

Czarek, I don't understand the question? This code is a fix for the bug so that it uses the theme colors for list items, it will be committed to the Blender code soon.%%%

%%%Bastien: patch looks good to me know. Only thing I would change still is to replace the do / while loop with a simple for loop. Probably it works fine the way this function is called here but no need to introduce the risk of a NULL pointer access for the first item. Czarek, I don't understand the question? This code is a fix for the bug so that it uses the theme colors for list items, it will be committed to the Blender code soon.%%%

Cezary Kopias commented

2013-06-26 02:52:22 +02:00

%%%Brecht, never mind i will read the code.
By the way i found another:

option ui elements in F6 after operator box use 3d view "Theme space Settings Text Highlight" color

attaching image%%%

%%%Brecht, never mind i will read the code. By the way i found another: option ui elements in F6 after operator box use 3d view "Theme space Settings Text Highlight" color attaching image%%%

Bastien Montagne commented

2013-06-26 09:31:54 +02:00

%%%Fixed in r57760, thanks for the report.

@ Czarek: Please open a new bug report, easier to track this way…%%%

%%%Fixed in r57760, thanks for the report. @ Czarek: Please open a new bug report, easier to track this way…%%%

Bastien Montagne commented

2013-06-26 09:31:54 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2013-06-26 09:31:54 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

list items in properties editor #35750