Blenderplayer crash on closing if file saved with an actual version. #35811

Closed
opened 2013-06-20 22:24:09 +02:00 by Thomas Szepe · 11 comments
Member

%%%The Blenderplayer will crash on closing if file saved a blend file with an actual Blender version.

File saved with Blender 2.67.1 r57570 open with Blenderplayer 2.67.1 r57570 --> crash on close
File saved with Blender 2.67.1 r57570 open with Blenderplayer 2.67.0 r57141 --> crash on close
File saved with Blender 2.67.0 r57141 open with Blenderplayer 2.67.0 r57570 --> working

Windows 7 64 bit with Blender 32 bit versions.
%%%

%%%The Blenderplayer will crash on closing if file saved a blend file with an actual Blender version. File saved with Blender 2.67.1 r57570 open with Blenderplayer 2.67.1 r57570 --> crash on close File saved with Blender 2.67.1 r57570 open with Blenderplayer 2.67.0 r57141 --> crash on close File saved with Blender 2.67.0 r57141 open with Blenderplayer 2.67.0 r57570 --> working Windows 7 64 bit with Blender 32 bit versions. %%%
Author
Member

Changed status to: 'Open'

Changed status to: 'Open'
Member

%%%Could you please attach a blend file that demonstrates this problem, or provide clear steps to reproduce the problem?%%%

%%%Could you please attach a blend file that demonstrates this problem, or provide clear steps to reproduce the problem?%%%
Author
Member

%%%Just save the standard cube scene with an new Blender version.
Then open and close it with the player. On close Blender will crash.

I have uploaded also two blend files now.%%%

%%%Just save the standard cube scene with an new Blender version. Then open and close it with the player. On close Blender will crash. I have uploaded also two blend files now.%%%

%%%I can confirm the crash also.
ive been aware of the crash for awhile but couldn't seem to narrow it down very well so didn't post it here.

But ill also add as it seems it stems from the same problem, that even if the blend file is saved with 2.67b official and its opened in a newer revision of blenderplayer such as r57570 it will still crash on exit when a new blend file is loaded from within the game engine even though all the blends were saved in r57141.%%%

%%%I can confirm the crash also. ive been aware of the crash for awhile but couldn't seem to narrow it down very well so didn't post it here. But ill also add as it seems it stems from the same problem, that even if the blend file is saved with 2.67b official and its opened in a newer revision of blenderplayer such as r57570 it will still crash on exit when a new blend file is loaded from within the game engine even though all the blends were saved in r57141.%%%
Member

%%%Should be fixed in r57680. Can you please confirm that this fixes the problem for you?%%%

%%%Should be fixed in r57680. Can you please confirm that this fixes the problem for you?%%%

%%%This fix has sadly made it worse it does now however not crash on exit when loading the first blend into the blenderplayer however it will crash every time now when exiting on the second blend wasn't happening before, and will now crash every time on loading a third blend file using the game actuator in blenderplayer.

I tested with a buildbot build rev blender-2.67-r57690M-win32
I made three blend files with this revision to test and will upload the three blends here.

To reproduce the crashes open blend1 in blenderplayer r57590m hit spacebar to load blend2 up, exiting should cause a crash on exit.
And then to reproduce crash two hit spacebar twice to load up blend3 and it should then crash on load.
It crashes every time for me on windows 8 where as before it was less persistent with previous versions and non existent with blender 2.67b official

I will upload the three blends in a zip file here if it lets me%%%

%%%This fix has sadly made it worse it does now however not crash on exit when loading the first blend into the blenderplayer however it will crash every time now when exiting on the second blend wasn't happening before, and will now crash every time on loading a third blend file using the game actuator in blenderplayer. I tested with a buildbot build rev blender-2.67-r57690M-win32 I made three blend files with this revision to test and will upload the three blends here. To reproduce the crashes open blend1 in blenderplayer r57590m hit spacebar to load blend2 up, exiting should cause a crash on exit. And then to reproduce crash two hit spacebar twice to load up blend3 and it should then crash on load. It crashes every time for me on windows 8 where as before it was less persistent with previous versions and non existent with blender 2.67b official I will upload the three blends in a zip file here if it lets me%%%
Author
Member

%%%Your patch fixed the crash with closing the blenderplayer.
But as James Press mentioned there is second bug that I didn't know.

I have seen that in blender.c there is also a free_nodesystem() function. But it seams that it don't work in blender.c
If I remove the free_nodesystem() from GPG_ghost.cpp and blender.c Blender not crash but I get much more memory leaks.

I think this is related with the other bug, therefore I don't open an new bug report.

I uploaded an example file.%%%

%%%Your patch fixed the crash with closing the blenderplayer. But as James Press mentioned there is second bug that I didn't know. I have seen that in blender.c there is also a free_nodesystem() function. But it seams that it don't work in blender.c If I remove the free_nodesystem() from GPG_ghost.cpp and blender.c Blender not crash but I get much more memory leaks. I think this is related with the other bug, therefore I don't open an new bug report. I uploaded an example file.%%%
Author
Member

%%%I think I found a proper solution for both issues.
You need to place free_nodesystem() somewhere after the while loop and before RNA_exit().

I added the patch.%%%

%%%I think I found a proper solution for both issues. You need to place free_nodesystem() somewhere after the while loop and before RNA_exit(). I added the patch.%%%
Member

%%%Please try r57711. Loading multiple blend files caused free_nodesystem() to be called multiple times, which the function was not expecting.%%%

%%%Please try r57711. Loading multiple blend files caused free_nodesystem() to be called multiple times, which the function was not expecting.%%%

%%%I can confirm crashes fixed with r57711. well played!

confirmed with build r57724. crash on exit no longer occurring, and crash when loading a blend file with the game actuator no longer occurring.%%%

%%%I can confirm crashes fixed with r57711. well played! confirmed with build r57724. crash on exit no longer occurring, and crash when loading a blend file with the game actuator no longer occurring.%%%
Member

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#35811
No description provided.