Blender crashes when trying to use vertex selection masking on a copy directly after using SHIFT+d #35914

New Issue

Gaia Clary · 2013-06-29T15:20:36+02:00

Gaia Clary commented

2013-06-29 15:20:36 +02:00

%%%--- Operating System, Graphics card ---

windows 7 64 bit
nvidia titan

- Blender version with error, and version that worked ---

2.67 works
trunk broken

- Short description of error ---

Open the attached Blend file
select the object onlayer 2
Now Blender crashes when trying to enter Weight Paint mode and enable vertex selection masking

- Steps for others to reproduce the error (preferably based on attached .blend file) ---

open Blender 2.67 or older

1.) Create a cube
2.) edit the cube
3.) Create a vertex Group and assign all verts to the group
4.) Select at least one of the verts
5.) enable X-Mirror
6.) step back to object mode
7.) Create a copy of the object using SHIFT +d
8.) still in object mode select the new copy
9.) switch to Weight Paint mode
10.) Enable vertex selection masking

Now Blender crashes because:

1.) me->totace > 0
2.) me->mselect = NULL
%%%

%%%--- Operating System, Graphics card --- windows 7 64 bit nvidia titan - Blender version with error, and version that worked --- 2.67 works trunk broken - Short description of error --- Open the attached Blend file select the object onlayer 2 Now Blender crashes when trying to enter Weight Paint mode and enable vertex selection masking - Steps for others to reproduce the error (preferably based on attached .blend file) --- open Blender 2.67 or older 1.) Create a cube 2.) edit the cube 3.) Create a vertex Group and assign all verts to the group 4.) Select at least one of the verts 5.) enable X-Mirror 6.) step back to object mode 7.) Create a copy of the object using SHIFT +d 8.) still in object mode select the new copy 9.) switch to Weight Paint mode 10.) Enable vertex selection masking Now Blender crashes because: 1.) me->totace > 0 2.) me->mselect = NULL %%%

Gaia Clary commented

2013-06-29 15:20:36 +02:00

Changed status to: 'Open'

Gaia Clary commented

2013-06-29 15:24:20 +02:00

%%%I could fix this problem by checking for me->totselect > 0 && me->mselect != NULL

int BKE_mesh_mselect_active_get(Mesh *me, int type)
{
BLI_assert(ELEM3(type, ME_VSEL, ME_ESEL, ME_FSEL));

/* XXX how can it be that sometimes me->mselect is NULL here ? 
   It happens, but its not clear why it happens! 
*/
if (me->totselect && me->mselect) {
	if (me->mselect[me->totselect - 1].type == type) {
		return me->mselect[me->totselect - 1].index;
	}
}
return -1;

}

However it may be better to solve this issue at a different place, maybe it makes more sense to ensure that mselect is set during loading the blend file or during entering vertex selection mask mode ?%%%

%%%I could fix this problem by checking for me->totselect > 0 && me->mselect != NULL int BKE_mesh_mselect_active_get(Mesh *me, int type) { BLI_assert(ELEM3(type, ME_VSEL, ME_ESEL, ME_FSEL)); /* XXX how can it be that sometimes me->mselect is NULL here ? It happens, but its not clear why it happens! */ if (me->totselect && me->mselect) { if (me->mselect[me->totselect - 1].type == type) { return me->mselect[me->totselect - 1].index; } } return -1; } However it may be better to solve this issue at a different place, maybe it makes more sense to ensure that mselect is set during loading the blend file or during entering vertex selection mask mode ?%%%

Gaia Clary commented

2013-06-30 09:33:20 +02:00

%%%I have found an easier way to get this problem and edited the original message.
It is not related to blender incompatibility, but it is directly related to the Copy step:

It looks like during SHIFT +d the mselect part is not created, but
BKE_mesh_mselect_active_get() expects this data to be up to date.%%%

%%%I have found an easier way to get this problem and edited the original message. It is not related to blender incompatibility, but it is directly related to the Copy step: It looks like during SHIFT +d the mselect part is not created, but BKE_mesh_mselect_active_get() expects this data to be up to date.%%%

Gaia Clary commented

2013-06-30 19:08:03 +02:00

%%%Here are 3 possible solutions to this:

1.) Set me->mtotselect to 0 on the created copy.
2.) just ensure that Weight Paint does not fall into the trap by checking that mselect != NULL
3.) copy the me->mselect array from the source object to the new copy.

So what is best ?%%%

%%%Here are 3 possible solutions to this: 1.) Set me->mtotselect to 0 on the created copy. 2.) just ensure that Weight Paint does not fall into the trap by checking that mselect != NULL 3.) copy the me->mselect array from the source object to the new copy. So what is best ?%%%

Campbell Barton commented

2013-07-01 00:04:48 +02:00

%%%me->mtotselect is now zero'd on load if the array is NULL.
But any new meshes copy the mselect array.

fixed r57888.
%%%

%%%me->mtotselect is now zero'd on load if the array is NULL. But any new meshes copy the mselect array. fixed r57888. %%%

Campbell Barton commented

2013-07-01 00:04:48 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2013-07-01 00:04:48 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Blender crashes when trying to use vertex selection masking on a copy directly after using SHIFT+d #35914