Timeline crash when chose any keying set then press keyframe-insert #37095

New Issue

Danyang Yi · 2013-10-15T18:17:52+02:00

Danyang Yi commented

2013-10-15 18:17:52 +02:00

%%%--- Operating System, Graphics card ---
win7 64bit sp1
GT 445m

- Blender version with error, and version that worked ---

2.69.1 rc1
r60739

- Short description of error ---

Timeline crash by chose any keying set then press keyframe-insert

- Steps for others to reproduce the error (preferably based on attached .blend file) ---

There is a snapshot with more detail in the attachment.

Thanks for you hard work!%%%

%%%--- Operating System, Graphics card --- win7 64bit sp1 GT 445m - Blender version with error, and version that worked --- 2.69.1 rc1 r60739 - Short description of error --- Timeline crash by chose any keying set then press keyframe-insert - Steps for others to reproduce the error (preferably based on attached .blend file) --- There is a snapshot with more detail in the attachment. Thanks for you hard work!%%%

Danyang Yi commented

2013-10-15 18:17:52 +02:00

Changed status to: 'Open'

Campbell Barton commented

2013-10-15 23:22:47 +02:00

%%%Cant redo, did this happen in 2.68a too? RC2 is out now, can you check if this fixes it?
%%%

%%%Cant redo, did this happen in 2.68a too? RC2 is out now, can you check if this fixes it? %%%

Danyang Yi commented

2013-10-16 03:41:26 +02:00

%%%I've tested 2.67a/2.68a/2.69.1rc2 also crashed and find the keys.

User Preferences - Sysyem - International Fonts - Translate -> Tooltips
Only crash when "Tooltips" activing. "Interface" and "New Data" is OK.

Best wishes!%%%

%%%I've tested 2.67a/2.68a/2.69.1rc2 also crashed and find the keys. User Preferences - Sysyem - International Fonts - Translate -> Tooltips Only crash when "Tooltips" activing. "Interface" and "New Data" is OK. Best wishes!%%%

Sebastian Koenig commented

2013-10-16 09:35:23 +02:00

%%%Oh indeed. Set language to chinese only f%%%

Sebastian Koenig commented

2013-10-16 09:49:33 +02:00

%%%... that comment totally did not work. :D
So again, if I set language to chinese for tooltips, activate keying set and press I --> crash (OSX 10.8.5)
%%%

%%%... that comment totally did not work. :D So again, if I set language to chinese for tooltips, activate keying set and press I --> crash (OSX 10.8.5) %%%

Danyang Yi commented

2013-10-16 15:44:25 +02:00

%%%Ops. Both Tranditional Chinese and Simple Chinese.

Thank you @sebastian-4 König.%%%

%%%Ops. Both Tranditional Chinese and Simple Chinese. Thank you @sebastian-4 König.%%%

Campbell Barton commented

2013-10-16 23:42:49 +02:00

%%%Theres an error in the translation:

"Successfully added %d keyframes for keying set '%s'", success, ks->name

Translates to:

鍵處理集「%s」已成功添加 %d 幀鍵幀

Notice %s and %d are flipped.

Bastien, aside from fixing this one case, it should be possible to automatically detect any more of these kinds of bugs.
%%%

%%%Theres an error in the translation: "Successfully added %d keyframes for keying set '%s'", success, ks->name Translates to: 鍵處理集「%s」已成功添加 %d 幀鍵幀 Notice %s and %d are flipped. Bastien, aside from fixing this one case, it should be possible to automatically detect any more of these kinds of bugs. %%%

Thomas Dinges commented

2013-10-16 23:59:07 +02:00

%%%Why is this marked as Release Blocker? If it crashes 2.68 too, it is not and I rather not do an RC3 because of this. %%%

Campbell Barton commented

2013-10-17 00:09:57 +02:00

%%%Thomas Dinges

Well, technically you could argue its not, but inserting keyframes is such a common operation and the bug is so simple to fix - It would be silly not to.

We dont even need any changes to code, just an updated translation.
%%%

%%%Thomas Dinges Well, technically you could argue its not, but inserting keyframes is such a common operation and the bug is so simple to fix - It would be silly not to. We dont even need any changes to code, just an updated translation. %%%

Bastien Montagne commented

2013-10-17 00:10:32 +02:00

%%%Grrr… we already have a check to remove from translations messages were formatting does not match org one, but only based on number of items, not they type/order… looks like we’ll have to be even more strict. But it’s a real PITA for translations. :/

Also do not think it’s a release blocker, I’ll just add the check and update translation files from current 2.69 blender tag, backport to i18n 2.69 tag, and that will do it imho… But not tonight! :P%%%

%%%Grrr… we already have a check to remove from translations messages were formatting does not match org one, but only based on number of items, not they type/order… looks like we’ll have to be even more strict. But it’s a real PITA for translations. :/ Also do not think it’s a release blocker, I’ll just add the check and update translation files from current 2.69 blender tag, backport to i18n 2.69 tag, and that will do it imho… But not tonight! :P%%%

Campbell Barton commented

2013-10-17 06:17:22 +02:00

%%%@Bastien, isn't it simple to write a python script which extracts string formatting from both strings and compares them?
Theres only so many kinds of string formatting which are possible, surely we're not the first project to run into this problem.%%%

%%%@Bastien, isn't it simple to write a python script which extracts string formatting from both strings and compares them? Theres only so many kinds of string formatting which are possible, surely we're not the first project to run into this problem.%%%

Leon Cheung commented

2013-10-17 08:23:56 +02:00

%%%Yes, the %s and %d indeed are flipped during translation, which is absolutely incorrect. I think it is probably caused by the differernt grammar rules (or word order) between the two languages, as well as the carelessness by the translator(s).

I've just tried to fix two items with such problem in the latest PO branch. (r2428)
https://svn.blender.org/svnroot/bf-translations/branches/zh_CN/

Also, probably any checking way needed to avoid this?%%%

%%%Yes, the %s and %d indeed are flipped during translation, which is absolutely incorrect. I think it is probably caused by the differernt grammar rules (or word order) between the two languages, as well as the carelessness by the translator(s). I've just tried to fix two items with such problem in the latest PO branch. (r2428) https://svn.blender.org/svnroot/bf-translations/branches/zh_CN/ Also, probably any checking way needed to avoid this?%%%

Danyang Yi commented

2013-10-17 09:02:25 +02:00

%%%Thanks Guys! I've been sending a message to Simple Chinese Translation team.%%%