Deadlock happens when stopping rendered viewport (Blender Internal) #37604

New Issue

Shinsuke Irie · 2013-11-24T20:18:32+01:00

Shinsuke Irie commented

2013-11-24 20:18:32 +01:00

System Information
Ubuntu 13.10 amd64 + GeForce GTX 670

Blender Version
Broken: git 178bd849bf 2013-11-24 17:21, also 2.69 is broken

Short description of error

Switching the viewport from "Rendered" to the other sometimes causes a deadlock, espacially using Freestyle tends to lead to the problem.

Backtrace: blender_rendered_view_deadlock.txt

I've made backtraces several times and found that this deadlock always occurs at WM_jobs_kill_type() in ED_view3d_shade_update().
Note that this happens even when not using Freestyle. pthread_cond_wait() or pthread_cond_timewait() in a subthread conflicts with the pthread_join() in the main thread.

**System Information** Ubuntu 13.10 amd64 + GeForce GTX 670 **Blender Version** Broken: git 178bd849bf6f 2013-11-24 17:21, also 2.69 is broken **Short description of error** Switching the viewport from "Rendered" to the other sometimes causes a deadlock, espacially using Freestyle tends to lead to the problem. Backtrace: [blender_rendered_view_deadlock.txt](https://archive.blender.org/developer/F32338/blender_rendered_view_deadlock.txt) I've made backtraces several times and found that this deadlock always occurs at WM_jobs_kill_type() in ED_view3d_shade_update(). Note that this happens even when not using Freestyle. pthread_cond_wait() or pthread_cond_timewait() in a subthread conflicts with the pthread_join() in the main thread.

Shinsuke Irie commented

2013-11-24 20:18:32 +01:00

Changed status to: 'Open'

Shinsuke Irie commented

2013-11-24 20:18:32 +01:00

Added subscriber: @IRIEShinsuke

Brecht Van Lommel commented

2013-11-25 02:10:24 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2013-11-25 02:10:24 +01:00

I think may be related to the python global interpreter lock, both the UI and freestyle using python. In cycles this is worked around by adding Py_BEGIN_ALLOW_THREADS / Py_END_ALLOW_THREADS in some places.

Shinsuke Irie commented

2013-11-25 04:57:45 +01:00

Thanks, I'm now testing Py_BEGIN_ALLOW_THREADS + Py_END_ALLOW_THREADS, but there is another case not related to the Python global interpreter lock and the deadlock still happens. BLI_ticket_mutex_lock() in sub thread also causes the deadlock.

Backtrace: blender_rendered_view_deadlock2.txt

Thanks, I'm now testing Py_BEGIN_ALLOW_THREADS + Py_END_ALLOW_THREADS, but there is another case not related to the Python global interpreter lock and the deadlock still happens. BLI_ticket_mutex_lock() in sub thread also causes the deadlock. Backtrace: [blender_rendered_view_deadlock2.txt](https://archive.blender.org/developer/F32569/blender_rendered_view_deadlock2.txt)

Sergey Sharybin commented

2013-12-04 16:07:35 +01:00

Added subscriber: @Sergey

Sergey Sharybin commented

2013-12-04 16:07:35 +01:00

Would be nice to be able to reproduce the deadlock. How do i do this?

Shinsuke Irie commented

2013-12-04 17:37:11 +01:00

Step to reproduce:

Make a scene using Freestyle
Start the rendered view (Shift+Z)
Stop the rendered view (Shift+Z) when the 3D view header shows "Freestyle: Stroke rendering"

This causes the deadlock related to the Python global interpreter lock, so probably can be resolved using Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS.

However, I still don't find out how to reproduce another deadlock related to BLI_ticket_mutex_lock(). This is quite rare case.

Step to reproduce: 1. Make a scene using Freestyle 2. Start the rendered view (Shift+Z) 3. Stop the rendered view (Shift+Z) when the 3D view header shows "Freestyle: Stroke rendering" This causes the deadlock related to the Python global interpreter lock, so probably can be resolved using Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS. However, I still don't find out how to reproduce another deadlock related to BLI_ticket_mutex_lock(). This is quite rare case.

Sergey Sharybin commented

2014-02-04 11:06:06 +01:00

Changed status from 'Open' to: 'Archived'

Sergey Sharybin closed this issue

2014-02-04 11:06:06 +01:00

Sergey Sharybin self-assigned this 2014-02-04 11:06:06 +01:00

Sergey Sharybin commented

2014-02-04 11:06:06 +01:00

@IRIEShinsuke, the thing is if you couldn't reproduce the issue you're hitting in rare cases it's very unlikely other will manage to do it. We couldn't actually spend hours trying to reproduce the issue..

That'd help a lot if you investigate the circumstances of the dead-lock. You've got much more chances becasue you alrady hit the issue!

For until then i'm archiving the report.

@IRIEShinsuke, the thing is if you couldn't reproduce the issue you're hitting in rare cases it's very unlikely other will manage to do it. We couldn't actually spend hours trying to reproduce the issue.. That'd help a lot if you investigate the circumstances of the dead-lock. You've got much more chances becasue you alrady hit the issue! For until then i'm archiving the report.

Shinsuke Irie commented

2014-02-04 12:44:53 +01:00

Ah OK, the remaining dead-lock is quite rare, so we can archive this.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Deadlock happens when stopping rendered viewport (Blender Internal) #37604