Material does no update when changing keyframes in dopesheet #37886

New Issue

Fabian Hernandez · 2013-12-19T20:26:03+01:00

Fabian Hernandez commented

2013-12-19 20:26:03 +01:00

System Information
OS X 10.9.1

Blender Version
Broken: Blender 2.69 r60991

Short description of error
When using the rendered view (either BI or Cycles), changes made to keyframes using the Dope Sheet are usually shown in rendered view (such as changes to Location keyframes). However, changes to property keyframes such as Diffuse Colour are not reflected in rendered view.

Exact steps for others to reproduce the error

Open either one of the attached files (there's a version for BI and one for Cycles)
Switch camera view to rendered view
Make sure you're at frame 12.
In Dope Sheet, select the keyframe at frame 23 (it's a location keyframe)
Move the keyframe to frame 12. Notice how the change is immediately shown in rendered view.
Now select the keyframe at frame 24 (it's a diffuse colour keyframe)
Move the keyframe to frame 12. Notice how the viewport re-renders, but doesn't show the change.
Go to the next frame and back to frame 12 again to finally see the change shown in rendered view

renderview-not-updated-on-keyframe-move-cycles.blend

renderview-not-updated-on-keyframe-move-bi.blend

**System Information** OS X 10.9.1 **Blender Version** Broken: Blender 2.69 r60991 **Short description of error** When using the rendered view (either BI or Cycles), changes made to keyframes using the Dope Sheet are usually shown in rendered view (such as changes to Location keyframes). However, changes to property keyframes such as Diffuse Colour are not reflected in rendered view. **Exact steps for others to reproduce the error** 1. Open either one of the attached files (there's a version for BI and one for Cycles) 2. Switch camera view to rendered view 3. Make sure you're at frame 12. 4. In Dope Sheet, select the keyframe at frame 23 (it's a location keyframe) 5. Move the keyframe to frame 12. Notice how the change is immediately shown in rendered view. 6. Now select the keyframe at frame 24 (it's a diffuse colour keyframe) 7. Move the keyframe to frame 12. Notice how the viewport re-renders, but doesn't show the change. 8. Go to the next frame and back to frame 12 again to finally see the change shown in rendered view [renderview-not-updated-on-keyframe-move-cycles.blend](https://archive.blender.org/developer/F46690/renderview-not-updated-on-keyframe-move-cycles.blend) [renderview-not-updated-on-keyframe-move-bi.blend](https://archive.blender.org/developer/F46691/renderview-not-updated-on-keyframe-move-bi.blend)

Fabian Hernandez commented

2013-12-19 20:26:03 +01:00

Changed status to: 'Open'

Fabian Hernandez commented

2013-12-19 20:26:03 +01:00

Added subscriber: @FabianHernandez

Brecht Van Lommel changed title from ~~Rendered view does not show changes made to keyframes related to properties~~ to Material does no update when changing keyframes in dopesheet

2013-12-20 01:44:17 +01:00

Brecht Van Lommel commented

2013-12-20 01:45:26 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2013-12-20 01:45:26 +01:00

I can redo the problem, but it seems unrelated to rendered draw type, other draw types and the properties editor don't update either. This means it's a bug in the animation itself, possibly a dependency graph limitation, need to investigate more to find that out.

Sergey Sharybin self-assigned this 2013-12-23 15:45:10 +01:00

Sergey Sharybin commented

2013-12-23 15:45:10 +01:00

I'll try to look into this.

Sergey Sharybin commented

2014-01-02 18:58:11 +01:00

Added subscriber: @JoshuaLeung

Sergey Sharybin commented

2014-01-02 18:58:11 +01:00

Developer note.

@brecht, looked into the issue and it's indeed limitation of current DAG and animation system.

What happens is changing keyframes in dopesheet or modifying fcurves in curve editor tags material for update which triggers re-render. However, animation system doesn't re-evaluate fcurves for material. Such a re-evaluation only happens when changing the frames.

What is needed to solve this bug is a way to tag materials as "need to be re-evaluated" and handle such an update in scene update function. Also materials need to become a part of DAG (that's easy tho).

I might hack this in by adding "recalc" field to ID itself (or maybe just to material for now?) and make it so scene_update will dela with materials and DAG_id_tag_update called for material will set that recalc flag.

This doesn't sound so much complicated, however this might conflict with what @JoshuaLeung was working on in his GSoC project.

So what would be the plan here?

Developer note. @brecht, looked into the issue and it's indeed limitation of current DAG and animation system. What happens is changing keyframes in dopesheet or modifying fcurves in curve editor tags material for update which triggers re-render. However, animation system doesn't re-evaluate fcurves for material. Such a re-evaluation only happens when changing the frames. What is needed to solve this bug is a way to tag materials as "need to be re-evaluated" and handle such an update in scene update function. Also materials need to become a part of DAG (that's easy tho). I might hack this in by adding "recalc" field to ID itself (or maybe just to material for now?) and make it so scene_update will dela with materials and DAG_id_tag_update called for material will set that recalc flag. This doesn't sound so much complicated, however this might conflict with what @JoshuaLeung was working on in his GSoC project. So what would be the plan here?

Brecht Van Lommel commented

2014-01-02 21:41:44 +01:00

Previously we closed such bug reports and moved them to the to do, but if you want to add some solution for this it's fine with me, if it doesn't conflict much with @JoshuaLeung's work.

We have a LIB_ID_RECALC flag already for Cycles to detect updates, that could probably be used.

Previously we closed such bug reports and moved them to the to do, but if you want to add some solution for this it's fine with me, if it doesn't conflict much with @JoshuaLeung's work. We have a LIB_ID_RECALC flag already for Cycles to detect updates, that could probably be used.

blender-admin commented

2014-01-13 14:02:23 +01:00

This issue was referenced by blender/blender-addons-contrib@08981f3a91

This issue was referenced by blender/blender-addons-contrib@08981f3a91a687efa8d28d308d6033e5a9e68b1f

blender-admin commented

2014-01-13 14:02:23 +01:00

This issue was referenced by 08981f3a91

This issue was referenced by 08981f3a91a687efa8d28d308d6033e5a9e68b1f

Sergey Sharybin commented

2014-01-13 14:04:54 +01:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue