Templates: Raycast Modal Op does not catch RuntimeError caused by Object.ray_cast for meshes with no faces #38493

New Issue

CodeManX · 2014-02-05T03:13:15+01:00

CodeManX commented

2014-02-05 03:13:15 +01:00

ray_cast() raises a RuntimeError if a mesh has no faces:

RuntimeError: Error: Object 'Plane' could not create internal data for ray casting

The template does neither check for len(obj.data.polygons) < 1, nor try/catch the exception.

`ray_cast()` raises a RuntimeError if a mesh has no faces: ``` RuntimeError: Error: Object 'Plane' could not create internal data for ray casting ``` The template does neither check for `len(obj.data.polygons) < 1`, nor try/catch the exception.

CodeManX commented

2014-02-05 03:13:15 +01:00

Changed status to: 'Open'

CodeManX commented

2014-02-05 03:13:15 +01:00

Added subscriber: @CodeManX

Campbell Barton was assigned by Sergey Sharybin

2014-02-06 08:52:29 +01:00

Sergey Sharybin commented

2014-02-06 08:52:29 +01:00

Added subscribers: @ideasman42, @Sergey

Sergey Sharybin commented

2014-02-06 08:52:29 +01:00

Not sure whether templates should handle all sorts of issues. They're more like hints how to do the things.

@ideasman42, leaving this one for you.

Not sure whether templates should handle all sorts of issues. They're more like hints how to do the things. @ideasman42, leaving this one for you.

CodeManX commented

2014-02-06 14:20:06 +01:00

There's no indication in the API docs, that ray_cast could ever raise an exception, so why would it be inappropriate to add this check if everyone should do it this way?

Atomic commented

2014-04-08 17:17:57 +02:00

Added subscriber: @AtomP

Atomic commented

2014-04-08 17:17:57 +02:00

It also raises an exception in official 2.70 if the mesh is in edit mode.

Try this on the default cube in edit mode.

import bpy

ob = bpy.data.objects.get("Cube")
polys = ob.data.polygons

end = polys[0].normal.copy() * -1   #Invert the normal because we are bouncing around inside the mesh.
start = polys[0].center
dist = 1000
hit, nor, index = ob.ray_cast(start, end * dist)

It also raises an exception in official 2.70 if the mesh is in edit mode. Try this on the default cube in edit mode. ``` import bpy ``` ``` ob = bpy.data.objects.get("Cube") polys = ob.data.polygons end = polys[0].normal.copy() * -1 #Invert the normal because we are bouncing around inside the mesh. start = polys[0].center dist = 1000 hit, nor, index = ob.ray_cast(start, end * dist) ```

blender-admin commented

2014-05-22 09:11:44 +02:00

This issue was referenced by blender/blender@c6de033bf1

This issue was referenced by blender/blender@c6de033bf1e92dd94858e8998f154fdea2e6bee2

Campbell Barton commented

2014-05-22 09:12:25 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2014-05-22 09:12:25 +02:00

Campbell Barton commented

2014-05-22 09:12:25 +02:00

Closed by commit blender/blender@c6de033bf1.