Each "undo" in Node Editor creates a non-existent user for linked node groups #39552

Closed
opened 2014-04-01 17:00:51 +02:00 by Sam Brubaker · 11 comments

Version: 2.70 official (win 64)

How to reproduce:

  • Link the composite node group in the provided .blend (or any node group)
  • Add the linked node group into the composite node editor of another blend file.
  • Perform some null actions, like moving a node around
  • Press ctrl+Z to undo.
  • Notice that each instance of undo adds 1 to the number of users of the linked node group. There is no reason for this.

Linked_Node_Group_Bug.blend

Version: 2.70 official (win 64) **How to reproduce:** - Link the composite node group in the provided .blend (or any node group) - Add the linked node group into the composite node editor of another blend file. - Perform some null actions, like moving a node around - Press ctrl+Z to undo. - Notice that each instance of undo adds 1 to the number of users of the linked node group. There is no reason for this. [Linked_Node_Group_Bug.blend](https://archive.blender.org/developer/F83691/Linked_Node_Group_Bug.blend)
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @rocketman

Added subscriber: @rocketman
Member

Added subscriber: @LukasTonne

Added subscriber: @LukasTonne
Member

This happens not only with node groups - it's just very easy to see there.

Another example:

  • Make an object group in the lib file
  • Link this group into a new blend
  • Move the group instance
  • Check bpy.data.groups[groupname].users (should be 1)
  • Undo
  • Check bpy.data.groups[groupname].users (now 2)

The user count for groups is not displayed as obviously as the node group count, but same error happens there. Common issue seems to be the newlibadr_us function (instead of newlibadr). Same problem exists in 2.69.

This happens not only with node groups - it's just very easy to see there. Another example: - Make an object group in the lib file - Link this group into a new blend - Move the group instance - Check `bpy.data.groups[groupname].users` (should be 1) - Undo - Check `bpy.data.groups[groupname].users` (now 2) The user count for groups is not displayed as obviously as the node group count, but same error happens there. Common issue seems to be the `newlibadr_us` function (instead of `newlibadr`). Same problem exists in 2.69.
Lukas Tönne was assigned by Sergey Sharybin 2014-04-10 17:48:24 +02:00

Added subscriber: @Sergey

Added subscriber: @Sergey

@LukasTonne, mind looking into the issue? You're already quite close to the solution even?

@LukasTonne, mind looking into the issue? You're already quite close to the solution even?
Lukas Tönne removed their assignment 2014-04-11 08:01:24 +02:00
Campbell Barton was assigned by Lukas Tönne 2014-04-11 08:01:24 +02:00
Member

Added subscriber: @ideasman42

Added subscriber: @ideasman42
Member

According to @ideasman42 this issue is not easily solvable ... Resetting linked blocks' user counts to zero before loading undo stage could break or something. Leaving it to Campbell to maybe explain and close.

According to @ideasman42 this issue is not easily solvable ... Resetting linked blocks' user counts to zero before loading undo stage could break or something. Leaving it to Campbell to maybe explain and close.

Ah, didn't pay much attention on the linked nature of the blocks. It's indeed quite difficult to solve.

Ah, didn't pay much attention on the linked nature of the blocks. It's indeed quite difficult to solve.
Member

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Member

Archiving for lack of urgency and/or solution.

Archiving for lack of urgency and/or solution.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#39552
No description provided.