GLSL Lamp with OnlyShadow makes weird colors in object. #40078

New Issue

Mario Mey · 2014-05-08T00:39:10+02:00

Mario Mey commented

2014-05-08 00:39:10 +02:00

Now, I have nVidia, but I remember the same problem with an ATI.

Look at the screenshot or open the file.

Now, I have nVidia, but I remember the same problem with an ATI. Look at the screenshot or open the file.

Mario Mey commented

2014-05-08 00:39:10 +02:00

Changed status to: 'Open'

Mario Mey commented

2014-05-08 00:39:10 +02:00

Added subscriber: @MarioSottile

Mario Mey commented

2014-05-08 00:39:50 +02:00

44-shadow-weird-colors.blend

![Captura_de_pantalla_de_2014-05-07_19:38:42.png](https://archive.blender.org/developer/F87687/Captura_de_pantalla_de_2014-05-07_19_38_42.png) [44-shadow-weird-colors.blend](https://archive.blender.org/developer/F87689/44-shadow-weird-colors.blend)

Mario Mey commented

2014-05-08 00:41:00 +02:00

With "Only Shadows" off.

With "Only Shadows" off. ![Captura_de_pantalla_de_2014-05-07_19:38:42.png](https://archive.blender.org/developer/F87690/Captura_de_pantalla_de_2014-05-07_19_38_42.png)

Mario Mey commented

2014-05-08 00:42:54 +02:00

Sorry, this is the screenshot with "Only Shadows" off.

Sorry, this is the screenshot with "Only Shadows" off. ![Captura_de_pantalla_de_2014-05-07_19:41:48.png](https://archive.blender.org/developer/F87692/Captura_de_pantalla_de_2014-05-07_19_41_48.png)

Bastien Montagne commented

2014-05-10 08:33:30 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2014-05-10 08:33:30 +02:00

“Only Shadow” is a rather advanced option, not sure whether we consider it supported or not with our current GLSL code?

Sergey Sharybin self-assigned this 2014-05-19 17:01:54 +02:00

Sergey Sharybin commented

2014-05-19 17:01:54 +02:00

Will have a look.

solarlune commented

2014-05-22 16:45:33 +02:00

Added subscriber: @solarlune

blender-admin commented

2014-05-30 10:11:41 +02:00

This issue was referenced by 8008d9bdfd

This issue was referenced by 8008d9bdfd5730b15727d0fb16f4417a4b8a85cc

Shinsuke Irie commented

2014-05-30 10:22:00 +02:00

Changed status from 'Open' to: 'Resolved'

Shinsuke Irie closed this issue

2014-05-30 10:22:00 +02:00

Shinsuke Irie commented

2014-05-30 10:22:00 +02:00

Closed by commit 8008d9bdfd.

Closed by commit 8008d9bdfd.

Shinsuke Irie changed title from ~~Lamp with OnlyShadow makes weird colors in object.~~ to GLSL Lamp with OnlyShadow makes weird colors in object.

2014-05-30 10:23:09 +02:00

Shinsuke Irie commented

2014-05-30 15:51:31 +02:00

Added subscribers: @Sergey, @brecht, @IRIEShinsuke

Shinsuke Irie commented

2014-05-30 15:51:31 +02:00

BTW, I noticed the only shadow lamp seems to be not working correctly in Blender Render.
If "Only Shadow" is enabled, disabling "Specular" option takes no effect.

@Sergey @brecht, do you think it's an actual bug?

Here is a fix for the glitch:

diff --git a/source/blender/render/intern/source/shadeoutput.c b/source/blender/render/intern/source/shadeoutput.c
index cc781c8..ebf88ef 100644
--- a/source/blender/render/intern/source/shadeoutput.c
+++ b/source/blender/render/intern/source/shadeoutput.c
@@ -1466,9 +1466,11 @@ static void shade_one_light(LampRen *lar, ShadeInput *shi, ShadeResult *shr, int
                                                shr->shad[1] -= shadfac[3]*shi->g*(1.0f-lashdw[1]);
                                                shr->shad[2] -= shadfac[3]*shi->b*(1.0f-lashdw[2]);
                                                
-                                               shr->spec[0] -= shadfac[3]*shi->specr*(1.0f-lashdw[0]);
-                                               shr->spec[1] -= shadfac[3]*shi->specg*(1.0f-lashdw[1]);
-                                               shr->spec[2] -= shadfac[3]*shi->specb*(1.0f-lashdw[2]);
+                                               if (!(lar->mode & LA_NO_SPEC)) {
+                                                       shr->spec[0] -= shadfac[3]*shi->specr*(1.0f-lashdw[0]);
+                                                       shr->spec[1] -= shadfac[3]*shi->specg*(1.0f-lashdw[1]);
+                                                       shr->spec[2] -= shadfac[3]*shi->specb*(1.0f-lashdw[2]);
+                                               }
                                                
                                                return;
                                        }

BTW, I noticed the only shadow lamp seems to be not working correctly in Blender Render. If "Only Shadow" is enabled, disabling "Specular" option takes no effect. @Sergey @brecht, do you think it's an actual bug? Here is a fix for the glitch: ``` diff --git a/source/blender/render/intern/source/shadeoutput.c b/source/blender/render/intern/source/shadeoutput.c index cc781c8..ebf88ef 100644 --- a/source/blender/render/intern/source/shadeoutput.c +++ b/source/blender/render/intern/source/shadeoutput.c @@ -1466,9 +1466,11 @@ static void shade_one_light(LampRen *lar, ShadeInput *shi, ShadeResult *shr, int shr->shad[1] -= shadfac[3]*shi->g*(1.0f-lashdw[1]); shr->shad[2] -= shadfac[3]*shi->b*(1.0f-lashdw[2]); - shr->spec[0] -= shadfac[3]*shi->specr*(1.0f-lashdw[0]); - shr->spec[1] -= shadfac[3]*shi->specg*(1.0f-lashdw[1]); - shr->spec[2] -= shadfac[3]*shi->specb*(1.0f-lashdw[2]); + if (!(lar->mode & LA_NO_SPEC)) { + shr->spec[0] -= shadfac[3]*shi->specr*(1.0f-lashdw[0]); + shr->spec[1] -= shadfac[3]*shi->specg*(1.0f-lashdw[1]); + shr->spec[2] -= shadfac[3]*shi->specb*(1.0f-lashdw[2]); + } return; } ```

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GLSL Lamp with OnlyShadow makes weird colors in object. #40078