Blender 2.70 crashes upon renaming node's socket #40282

New Issue

Mi Los · 2014-05-20T18:13:17+02:00

Mi Los commented

2014-05-20 18:13:17 +02:00

System Information
Operating system and graphics card

Blender Version
2.70

Short description of error
As soon as I rename "Mix Shader" node's input socket name from "Shader" to anything else via script Blender crashes like 1 second after successful renaming (so yea, it is clearly very easily possible jut like here that was actually my inspiration http://www.blenderdiplom.com/en/tutorials/all-tutorials/551-using-python-to-quickly-setup-nodes.html)

Exact steps for others to reproduce the error
. My code is:

mat = bpy.data.materials["m1"].node_tree.nodes
for i in mat:
    if i.type == "MIX_SHADER":
        i.inputs[1].name = "A"
        i.inputs[2].name = "B"

**System Information** Operating system and graphics card **Blender Version** 2.70 **Short description of error** As soon as I rename "Mix Shader" node's input socket name from "Shader" to anything else via script Blender crashes like 1 second after successful renaming (so yea, it is clearly very easily possible jut like here that was actually my inspiration http://www.blenderdiplom.com/en/tutorials/all-tutorials/551-using-python-to-quickly-setup-nodes.html) **Exact steps for others to reproduce the error** . My code is: # ``` mat = bpy.data.materials["m1"].node_tree.nodes for i in mat: if i.type == "MIX_SHADER": i.inputs[1].name = "A" i.inputs[2].name = "B" ```

Mi Los commented

2014-05-20 18:13:17 +02:00

Changed status to: 'Open'

Mi Los commented

2014-05-20 18:13:17 +02:00

Added subscriber: @bublible

Bastien Montagne commented

2014-05-20 19:46:57 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2014-05-20 19:46:57 +02:00

Please always provide a simple .blend file allowing to easily reproduce the issue.

Also, you can use the 'code' formatting (<> button in phab editor header), especially useful with languages like python, where formatting is crucial! ;)

Please always provide a simple .blend file allowing to easily reproduce the issue. Also, you can use the 'code' formatting (<> button in phab editor header), especially useful with languages like python, where formatting is crucial! ;)

Bastien Montagne commented

2014-05-20 19:48:00 +02:00

Also, you mention 2.70, is it the official release? if so, can you check with a recent build from our buildbot?

Also, you mention 2.70, is it the official release? if so, can you check with a recent build from [our buildbot](http://builder.blender.org/download)?

Greg Zaal commented

2014-05-21 08:10:38 +02:00

Added subscribers: @LukasTonne, @ThomasDinges, @brecht, @GregZaal

Greg Zaal commented

2014-05-21 08:10:38 +02:00

@LukasTonne I don't know if it was ever meant to be possible, but I think it'd be quite useful to be able to rename sockets from the properties region.

Would hopefully just involve changing the labels to properties (and fixing this bug of course)

I can confirm it crashes cycles shader nodes, but not in the compositor nor Blender Render material nodes. Perhaps this should be assigned to @brecht or @ThomasDinges ?

@LukasTonne I don't know if it was ever meant to be possible, but I think it'd be quite useful to be able to rename sockets from the properties region. ![rename_sockets.PNG](https://archive.blender.org/developer/F89555/rename_sockets.PNG) Would hopefully just involve changing the labels to properties (and fixing this bug of course) I can confirm it crashes cycles shader nodes, but not in the compositor nor Blender Render material nodes. Perhaps this should be assigned to @brecht or @ThomasDinges ?

Lukas Tönne commented

2014-05-21 11:01:09 +02:00

Well, cycles relies very much on socket names to map values and connections to the internal shaders. If you rename a socket, cycles won't be able to find a matching socket for a shader parameter, which should never happen.

This is tricky to solve: In principle, renaming sockets should not be allowed for the builtin C nodes (compositor, shader, texture nodes). However, it has to be allowed for pynodes, so making the name property read-only in general wouldn't work.

For the nodes i have defined an intermediate type "internal node", which redefines some core properties to be read-only. However, for node sockets this would become a messy limitation, due to the fact that the standard socket types can also be used for pynodes. So i'd rather not prohibit renaming in the API and rather make sure cycles handles such errors gracefully.

Renaming sockets would still not be possible (just disable the shader instead of crashing), but that's just the way cycles works.

Well, cycles relies very much on socket names to map values and connections to the internal shaders. If you rename a socket, cycles won't be able to find a matching socket for a shader parameter, which should never happen. This is tricky to solve: In principle, renaming sockets should not be allowed for the *builtin C nodes* (compositor, shader, texture nodes). However, it has to be allowed for pynodes, so making the name property read-only in general wouldn't work. For the nodes i have defined an intermediate type "internal node", which redefines some core properties to be read-only. However, for node sockets this would become a messy limitation, due to the fact that the standard socket types can also be used for pynodes. So i'd rather not prohibit renaming in the API and rather make sure cycles handles such errors gracefully. Renaming sockets would still not be possible (just disable the shader instead of crashing), but that's just the way cycles works.

Sergey Sharybin self-assigned this 2014-05-28 11:39:12 +02:00

Sergey Sharybin commented

2014-05-28 11:39:12 +02:00

Will look into it. Guess @brecht have too much on his desk already and wouldn't mind some help :)