Creating Rigid Bodies is rejected for some meshes #40447

New Issue

Fabian Emmes · 2014-05-31T14:17:50+02:00

Fabian Emmes commented

2014-05-31 14:17:50 +02:00

System Information
Windows 8.1, Intel integrated graphics (Sandy bridge).

Blender Version
Broken: current master branch (cc2cdfb0)

Short description of error
In engine "Blender Render", creating Rigid Bodies is rejected if the (base) Mesh Data object contains no faces, even if faces are created by the modifier stack (for example using the Screw modifier). Only using the "BASE" as mesh-source should be disallowed in this case, since using "FINAL" will yield a proper mesh.

Exact steps for others to reproduce the error
Create a circle mesh without faces. Use the Screw modifier to create a torus, but don't apply it. Creating a Rigid Body from this object is not possible (message: "Can't create Rigid Body from mesh with no polygons").

Proposed fix

Remove the check from rigidbody_object.c, and possibly add it at a later stage in the pipeline (when it is clear what mesh the Rigid Body should really be based on).

diff --git a/source/blender/editors/physics/rigidbody_object.c b/source/blender/editors/physics/rigidbody_object.c
index e4426fd..8fb79f8 100644
- a/source/blender/editors/physics/rigidbody_object.c
+++ b/source/blender/editors/physics/rigidbody_object.c
@@ -100,10 +100,6 @@ bool ED_rigidbody_object_add(Scene *scene, Object *ob, int type, ReportList *rep

              BKE_report(reports, RPT_ERROR, "Can't add Rigid Body to non mesh object");
              return false;
      }

if (((Mesh *)ob->data)->totpoly == 0) {
BKE_report(reports, RPT_ERROR, "Can't create Rigid Body from mesh with no polygons");
return false;
}

      /* Add rigid body world and group if they don't exist for convenience */
      if (rbw == NULL) {

**System Information** Windows 8.1, Intel integrated graphics (Sandy bridge). **Blender Version** Broken: current master branch (cc2cdfb0) **Short description of error** In engine "Blender Render", creating Rigid Bodies is rejected if the (base) Mesh Data object contains no faces, even if faces are created by the modifier stack (for example using the Screw modifier). Only using the "BASE" as mesh-source should be disallowed in this case, since using "FINAL" will yield a proper mesh. **Exact steps for others to reproduce the error** Create a circle mesh without faces. Use the Screw modifier to create a torus, but don't apply it. Creating a Rigid Body from this object is not possible (message: "Can't create Rigid Body from mesh with no polygons"). **Proposed fix** Remove the check from rigidbody_object.c, and possibly add it at a later stage in the pipeline (when it is clear what mesh the Rigid Body should really be based on). diff --git a/source/blender/editors/physics/rigidbody_object.c b/source/blender/editors/physics/rigidbody_object.c index e4426fd..8fb79f8 100644 - a/source/blender/editors/physics/rigidbody_object.c +++ b/source/blender/editors/physics/rigidbody_object.c @@ -100,10 +100,6 @@ bool ED_rigidbody_object_add(Scene *scene, Object *ob, int type, ReportList *rep ``` BKE_report(reports, RPT_ERROR, "Can't add Rigid Body to non mesh object"); return false; } ``` - if (((Mesh *)ob->data)->totpoly == 0) { - BKE_report(reports, RPT_ERROR, "Can't create Rigid Body from mesh with no polygons"); - return false; - } ``` /* Add rigid body world and group if they don't exist for convenience */ if (rbw == NULL) { ```

Fabian Emmes commented

2014-05-31 14:17:50 +02:00

Changed status to: 'Open'

Fabian Emmes commented

2014-05-31 14:17:50 +02:00

Added subscriber: @der_fab

Fabian Emmes commented

2014-05-31 14:20:57 +02:00

I messed up the formatting of the diff.

diff --git a/source/blender/editors/physics/rigidbody_object.c b/source/blender/editors/physics/rigidbody_object.c
index e4426fd..8fb79f8 100644

  - a/source/blender/editors/physics/rigidbody_object.c

+++ b/source/blender/editors/physics/rigidbody_object.c
@@ -100,10 +100,6 @@ bool ED_rigidbody_object_add(Scene *scene, Object *ob, int type, ReportList *rep
                BKE_report(reports, RPT_ERROR, "Can't add Rigid Body to non mesh object");
                return false;
        }

if (((Mesh *)ob->data)->totpoly == 0) {
BKE_report(reports, RPT_ERROR, "Can't create Rigid Body from mesh with no polygons");
return false;
}

        /* Add rigid body world and group if they don't exist for convenience */
        if (rbw == NULL) {

I messed up the formatting of the diff. ``` diff --git a/source/blender/editors/physics/rigidbody_object.c b/source/blender/editors/physics/rigidbody_object.c index e4426fd..8fb79f8 100644 ``` - a/source/blender/editors/physics/rigidbody_object.c ``` +++ b/source/blender/editors/physics/rigidbody_object.c @@ -100,10 +100,6 @@ bool ED_rigidbody_object_add(Scene *scene, Object *ob, int type, ReportList *rep BKE_report(reports, RPT_ERROR, "Can't add Rigid Body to non mesh object"); return false; } ``` - if (((Mesh *)ob->data)->totpoly == 0) { - BKE_report(reports, RPT_ERROR, "Can't create Rigid Body from mesh with no polygons"); - return false; - } ``` /* Add rigid body world and group if they don't exist for convenience */ if (rbw == NULL) { ```

Lukas Tönne commented

2014-06-01 15:54:24 +02:00

Added subscriber: @LukasTonne

Lukas Tönne commented

2014-06-01 15:54:24 +02:00

Agreed, this test is also pretty useless, since you can make a "proper" mesh with faces, make it a rigid body, then remove all faces afterward ... or assign different mesh datablock after making a rigid body object ... or something else, probably there are lots of ways to circumvent it.