cycles matlib file crashes #40482

New Issue

Brendon Murphy · 2014-06-03T15:01:32+02:00

Brendon Murphy commented

2014-06-03 15:01:32 +02:00

System Information
all

Blender Version
Broken: now)
Worked: (very early cycles dev)

Crash on render

open file, press f12

download from here:
http://www.blendswap.com/blends/view/56470
http://www.blendswap.com/blends/view/65460

both files have significant d/l on blendswap.

In the likely case some materials settings are depreciated/void, please let me know which materials need to be removed.

**System Information** all **Blender Version** Broken: now) Worked: (very early cycles dev) **Crash on render** **open file, press f12** download from here: http://www.blendswap.com/blends/view/56470 http://www.blendswap.com/blends/view/65460 both files have significant d/l on blendswap. In the likely case some materials settings are depreciated/void, please let me know which materials need to be removed.

Brendon Murphy commented

2014-06-03 15:01:32 +02:00

Changed status to: 'Open'

Thomas Dinges was assigned by Brendon Murphy

2014-06-03 15:01:32 +02:00

Brendon Murphy commented

2014-06-03 15:01:32 +02:00

Added subscriber: @BrendonMurphy

marc dion commented

2014-06-04 19:34:06 +02:00

Added subscriber: @MarcClintDion

marc dion commented

2014-06-04 19:34:06 +02:00

No description provided.

marc dion commented

2014-06-04 19:36:56 +02:00

Removed subscriber: @MarcClintDion

Sergey Sharybin commented

2014-06-04 21:27:20 +02:00

Added subscribers: @brecht, @Sergey

Sergey Sharybin commented

2014-06-04 21:27:20 +02:00

@brecht, it's possible that runtime optimizer would call get_attribute with NULL renderstate. As per documentation, we might simply add check to OSLRenderServices::get_attribute and return false if renderstate is NULL. In worst case scenario seems we'll just miss some possible optimization.

But i'm also wondering, how correct it'll be to use OSLRenderServices::kernel_globals instead of ShaderData::osl_globals in cases renderstate is NULL.Don't really see difference between returning false and trying to use kernel_globals with the files attached here.

@brecht, it's possible that runtime optimizer would call `get_attribute` with NULL renderstate. As per documentation, we might simply add check to `OSLRenderServices::get_attribute` and return `false` if renderstate is NULL. In worst case scenario seems we'll just miss some possible optimization. But i'm also wondering, how correct it'll be to use `OSLRenderServices::kernel_globals` instead of `ShaderData::osl_globals` in cases renderstate is NULL.Don't really see difference between returning false and trying to use kernel_globals with the files attached here.

Sergey Sharybin commented

2014-06-04 21:29:31 +02:00

Forgot to attach two possible patches.

First one seems somewhat safer for the release.

Forgot to attach two possible patches. - http://www.pasteall.org/52032/diff - http://www.pasteall.org/52031/diff First one seems somewhat safer for the release.

Brecht Van Lommel commented

2014-06-04 22:09:00 +02:00

It's best to return NULL for now. Attributes are only set up for the kernel to read after shader compilation.

If we want to take advantage of this optimization some bigger changes are needed, and I don't think this optimization is very important at the moment.

It's best to return NULL for now. Attributes are only set up for the kernel to read after shader compilation. If we want to take advantage of this optimization some bigger changes are needed, and I don't think this optimization is very important at the moment.

blender-admin commented

2014-06-04 22:33:21 +02:00

This issue was referenced by dc2daf7a67

This issue was referenced by dc2daf7a6786110a77cebc5ad8ea7a118d156d61

Sergey Sharybin commented

2014-06-04 22:33:49 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2014-06-04 22:33:49 +02:00

Sergey Sharybin commented

2014-06-04 22:33:49 +02:00

Closed by commit dc2daf7a67.

Closed by commit dc2daf7a67.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

cycles matlib file crashes #40482