unreachable code in wm_keymap.c #41811

New Issue

Greg Dickson · 2014-09-13T13:52:54+02:00

Greg Dickson commented

2014-09-13 13:52:54 +02:00

I could be wrong but it appears that line 1521 in the 2.71 source (1561 of the current on GIT) is unreachable in
/** \file blender/windowmanager/intern/wm_keymap.c

\ingroup wm
Configurable key-maps - add/remove/find/compare/patch...
*/

	else if (strstr(opname, "PAINT_OT")) {
		
		/* check for relevant mode */
		switch (CTX_data_mode_enum(C)) {
			case OB_MODE_WEIGHT_PAINT:
				km = WM_keymap_find_all(C, "Weight Paint", 0, 0);
				break;
			case OB_MODE_VERTEX_PAINT:
				km = WM_keymap_find_all(C, "Vertex Paint", 0, 0);
				break;
			case OB_MODE_TEXTURE_PAINT:
				km = WM_keymap_find_all(C, "Image Paint", 0, 0);
				break;
		}
	}
	/* Paint Face Mask */
	else if (strstr(opname, "PAINT_OT_face_select")) {
		km = WM_keymap_find_all(C, "Face Mask", sl->spacetype, 0);
	}

this should probably be

	/* Paint Face Mask */
	else if (strstr(opname, "PAINT_OT_face_select")) {
		km = WM_keymap_find_all(C, "Face Mask", sl->spacetype, 0);
	}
	else if (strstr(opname, "PAINT_OT")) {
		
		/* check for relevant mode */
		switch (CTX_data_mode_enum(C)) {
			case OB_MODE_WEIGHT_PAINT:
				km = WM_keymap_find_all(C, "Weight Paint", 0, 0);
				break;
			case OB_MODE_VERTEX_PAINT:
				km = WM_keymap_find_all(C, "Vertex Paint", 0, 0);
				break;
			case OB_MODE_TEXTURE_PAINT:
				km = WM_keymap_find_all(C, "Image Paint", 0, 0);
				break;
		}
	}

I could be wrong but it appears that line 1521 in the 2.71 source (1561 of the current on GIT) is unreachable in /** \file blender/windowmanager/intern/wm_keymap.c * \ingroup wm * * Configurable key-maps - add/remove/find/compare/patch... */ ``` else if (strstr(opname, "PAINT_OT")) { /* check for relevant mode */ switch (CTX_data_mode_enum(C)) { case OB_MODE_WEIGHT_PAINT: km = WM_keymap_find_all(C, "Weight Paint", 0, 0); break; case OB_MODE_VERTEX_PAINT: km = WM_keymap_find_all(C, "Vertex Paint", 0, 0); break; case OB_MODE_TEXTURE_PAINT: km = WM_keymap_find_all(C, "Image Paint", 0, 0); break; } } /* Paint Face Mask */ else if (strstr(opname, "PAINT_OT_face_select")) { km = WM_keymap_find_all(C, "Face Mask", sl->spacetype, 0); } ``` this should probably be ``` /* Paint Face Mask */ else if (strstr(opname, "PAINT_OT_face_select")) { km = WM_keymap_find_all(C, "Face Mask", sl->spacetype, 0); } else if (strstr(opname, "PAINT_OT")) { /* check for relevant mode */ switch (CTX_data_mode_enum(C)) { case OB_MODE_WEIGHT_PAINT: km = WM_keymap_find_all(C, "Weight Paint", 0, 0); break; case OB_MODE_VERTEX_PAINT: km = WM_keymap_find_all(C, "Vertex Paint", 0, 0); break; case OB_MODE_TEXTURE_PAINT: km = WM_keymap_find_all(C, "Image Paint", 0, 0); break; } } ```

Greg Dickson commented

2014-09-13 13:52:54 +02:00

Changed status to: 'Open'

Greg Dickson commented

2014-09-13 13:52:54 +02:00

Added subscriber: @GregDickson

blender-admin commented

2014-09-13 15:49:53 +02:00

This issue was referenced by fdb12ff564

This issue was referenced by fdb12ff564daefc20829ebe37edf76788530bef6

Bastien Montagne self-assigned this 2014-09-13 15:51:26 +02:00

Bastien Montagne commented

2014-09-13 15:51:26 +02:00

Good catch, thanks! :)

Bastien Montagne commented

2014-09-13 15:54:56 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2014-09-13 15:54:56 +02:00

Bastien Montagne commented

2014-09-13 15:54:56 +02:00

Closed by commit fdb12ff564.

Closed by commit fdb12ff564.

Greg Dickson commented

2014-09-13 22:00:18 +02:00

I was going to say while your in there couldn't the following work the same way.
I am still getting my head around the blender context thing

	else if (strstr(opname, "OBJECT_OT")) {
		/* exception, this needs to work outside object mode too */
		if (strstr(opname, "OBJECT_OT_mode_set"))
			km = WM_keymap_find_all(C, "Object Non-modal", 0, 0);
		else
			km = WM_keymap_find_all(C, "Object Mode", 0, 0);
	}

but may be next time your around there

I was going to say while your in there couldn't the following work the same way. I am still getting my head around the blender context thing ``` else if (strstr(opname, "OBJECT_OT")) { /* exception, this needs to work outside object mode too */ if (strstr(opname, "OBJECT_OT_mode_set")) km = WM_keymap_find_all(C, "Object Non-modal", 0, 0); else km = WM_keymap_find_all(C, "Object Mode", 0, 0); } ``` but may be next time your around there

Bastien Montagne commented

2014-09-13 23:38:04 +02:00

Yes it could, but current code is working too afaik, so no real need to change it here?

Greg Dickson commented

2014-09-13 23:46:36 +02:00

OK Cool
Thanks heaps for the quick fix.
I am trying to duplicate this in python (its not callable in anyway directly from python is it?)

OK Cool Thanks heaps for the quick fix. I am trying to duplicate this in python (its not callable in anyway directly from python is it?)

Bastien Montagne commented

2014-09-14 00:22:25 +02:00

No, this is not accessible from py currently :/

Greg Dickson commented

2014-09-14 02:56:31 +02:00

Don't be sad :)
That's the cool thing about Blender/Python.
If you want it you can always make it. :D
Peeling the onion is the bit that makes me cry a bit.

Don't be sad :) That's the cool thing about Blender/Python. If you want it you can always make it. :D Peeling the onion is the bit that makes me cry a bit.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

unreachable code in wm_keymap.c #41811