Changes to the Movie Clip Editor's grid color preferences do not take effect #42205

New Issue

Seth L. · 2014-10-13T14:45:24+02:00

Seth L. commented

2014-10-13 14:45:24 +02:00

System Information
OS X 10.8.5 ATI Radeon HD 4850 512 MB

Blender Version
Broken: 2.72 95182d1

Short description of error
It appears that the Movie Clip Editor grid color cannot be adjusted. Changing the grid color setting does not have an effect.

Also the Video Sequence Editor and the Node Editor actually lack the option to change the grid color entirely, and while that may be by deliberate design I thought I should bring it up since other editors which have grids do offer that option.

Exact steps for others to reproduce the error

Set part of your workspace to the Movie Clip Editor. Note the grid color.
Open Blender's Preferences and go to the Themes tab.
Navigate to the Movie Clip Editor section and under the Theme clip Editor heading find the color for "Grid".
Change that color value and observe how the grid color in the Movie Clip Editor does not change.

**System Information** OS X 10.8.5 ATI Radeon HD 4850 512 MB **Blender Version** Broken: 2.72 95182d1 **Short description of error** It appears that the Movie Clip Editor grid color cannot be adjusted. Changing the grid color setting does not have an effect. Also the Video Sequence Editor and the Node Editor actually lack the option to change the grid color entirely, and while that may be by deliberate design I thought I should bring it up since other editors which have grids do offer that option. **Exact steps for others to reproduce the error** 1. Set part of your workspace to the Movie Clip Editor. Note the grid color. 2. Open Blender's Preferences and go to the Themes tab. 3. Navigate to the Movie Clip Editor section and under the Theme clip Editor heading find the color for "Grid". 4. Change that color value and observe how the grid color in the Movie Clip Editor does not change.

Seth L. commented

2014-10-13 14:45:24 +02:00

Changed status to: 'Open'

Seth L. commented

2014-10-13 14:45:24 +02:00

Added subscriber: @quantumanomaly

Campbell Barton commented

2014-10-13 15:19:12 +02:00

Added subscribers: @Sergey, @ideasman42

Campbell Barton commented

2014-10-13 15:19:12 +02:00

Looks like this should simply be removed, its not used anywhere.

@Sergey ?

      diff --git a/source/blender/makesrna/intern/rna_userdef.c b/source/blender/makesrna/intern/rna_userdef.c
      index 976a89a..cfeac6a 100644

        - a/source/blender/makesrna/intern/rna_userdef.c

      +++ b/source/blender/makesrna/intern/rna_userdef.c
      @@ -2784,11 +2784,6 @@ static void rna_def_userdef_theme_space_clip(BlenderRNA *brna)
       	RNA_def_property_ui_text(prop, "Path After", "Color of path after current frame");
       	RNA_def_property_update(prop, 0, "rna_userdef_update");

    - prop = RNA_def_property(srna, "grid", PROP_FLOAT, PROP_COLOR_GAMMA);
    - RNA_def_property_array(prop, 3);
    - RNA_def_property_ui_text(prop, "Grid", "");
    - RNA_def_property_update(prop, 0, "rna_userdef_update");
    -

       	prop = RNA_def_property(srna, "frame_current", PROP_FLOAT, PROP_COLOR_GAMMA);
       	RNA_def_property_float_sdna(prop, NULL, "cframe");
       	RNA_def_property_array(prop, 3);

Looks like this should simply be removed, its not used anywhere. @Sergey ? ``` diff --git a/source/blender/makesrna/intern/rna_userdef.c b/source/blender/makesrna/intern/rna_userdef.c index 976a89a..cfeac6a 100644 ``` - a/source/blender/makesrna/intern/rna_userdef.c ``` +++ b/source/blender/makesrna/intern/rna_userdef.c @@ -2784,11 +2784,6 @@ static void rna_def_userdef_theme_space_clip(BlenderRNA *brna) RNA_def_property_ui_text(prop, "Path After", "Color of path after current frame"); RNA_def_property_update(prop, 0, "rna_userdef_update"); ``` - prop = RNA_def_property(srna, "grid", PROP_FLOAT, PROP_COLOR_GAMMA); - RNA_def_property_array(prop, 3); - RNA_def_property_ui_text(prop, "Grid", ""); - RNA_def_property_update(prop, 0, "rna_userdef_update"); - ``` prop = RNA_def_property(srna, "frame_current", PROP_FLOAT, PROP_COLOR_GAMMA); RNA_def_property_float_sdna(prop, NULL, "cframe"); RNA_def_property_array(prop, 3); ```

Sergey Sharybin commented

2014-10-13 15:23:10 +02:00

Yes, think so. Do you mind comitting?