Bug fixed of FBX plugin #42410

New Issue

Mingfen Wang · 2014-10-27T01:14:40+01:00

Mingfen Wang commented

2014-10-27 01:14:40 +01:00

System Information
Mac OSX 10.9.5, Mac mini 2012 late

Blender Version
Worked: Blender 2.72a

Short description of error
Some 3d models need to turn off pre-rotation and post rotation when importing FBX file.

Exact steps for others to reproduce the error
Import the attached FBX file, you will find that the neck of the giraffe is weird, if you turn off pre_rot and pst_rot, everything is okay.

I have patched the FBX plugin by having added a checkbox of this feature, the patched files are included in the attached file.

I have also modified the length of bones to 1e-3, this makes the models look fine when using 'Stick' armature display mode, the bones show as yellow tiny cubes, which are easy to select and operate on them.

Modifying the length of bones is not necessary, it is not a bug, I just feel that the long bones are terrible looking, at least I can rig and pose on the bones now:-)

bug_report.zip

**System Information** Mac OSX 10.9.5, Mac mini 2012 late **Blender Version** Worked: Blender 2.72a **Short description of error** Some 3d models need to turn off pre-rotation and post rotation when importing FBX file. **Exact steps for others to reproduce the error** Import the attached FBX file, you will find that the neck of the giraffe is weird, if you turn off pre_rot and pst_rot, everything is okay. I have patched the FBX plugin by having added a checkbox of this feature, the patched files are included in the attached file. I have also modified the length of bones to 1e-3, this makes the models look fine when using 'Stick' armature display mode, the bones show as yellow tiny cubes, which are easy to select and operate on them. Modifying the length of bones is not necessary, it is not a bug, I just feel that the long bones are terrible looking, at least I can rig and pose on the bones now:-) [bug_report.zip](https://archive.blender.org/developer/F119844/bug_report.zip)

Mingfen Wang commented

2014-10-27 01:14:40 +01:00

Changed status to: 'Open'

Mingfen Wang self-assigned this 2014-10-27 01:14:40 +01:00

Mingfen Wang commented

2014-10-27 01:14:40 +01:00

Added subscriber: @artgolf1000

Mingfen Wang commented

2014-10-27 01:27:22 +01:00

This comment was removed by @artgolf1000

*This comment was removed by @artgolf1000*

Mingfen Wang removed their assignment 2014-10-27 01:43:42 +01:00

Mingfen Wang commented

2014-10-27 01:43:42 +01:00

Removed subscriber: @artgolf1000

Bastien Montagne commented

2014-10-27 09:04:40 +01:00

Added subscriber: @mont29

Bastien Montagne commented

2014-10-27 09:04:40 +01:00

Meeeeh… even mooooore option to this poor addon… FBX should never ever have had such a complex transformation system, it's just not manageable. :/ Will check that.

About bones, well, in Blender those are bones, not joints like in many other apps… Anyway, please try addon from a build from our buildbot, bone importing was rather heavily reworked compared to 2.72 release, handles much more cases correctly now.

Meeeeh… even mooooore option to this poor addon… FBX should **never ever** have had such a complex transformation system, it's just not manageable. :/ Will check that. About bones, well, in Blender those are **bones**, not **joints** like in many other apps… Anyway, please try addon from a build from [our buildbot](https://builder.blender.org/download), bone importing was rather heavily reworked compared to 2.72 release, handles much more cases correctly now.

Bastien Montagne self-assigned this 2014-10-27 09:05:28 +01:00

Bastien Montagne commented

2014-10-27 09:05:28 +01:00

Added subscriber: @artgolf1000

Bastien Montagne commented

2014-10-29 12:22:06 +01:00

Hmm… The file you attached actually contains modified versions of files from old addon… Current one is rather different, especially since you did not provide patch as .diff file, could you please update your work against latest version (as available in builds from our buildbot)?

Hmm… The file you attached actually contains modified versions of files from old addon… Current one is rather different, especially since you did not provide patch as .diff file, could you please update your work against latest version (as available in builds from [our buildbot](https://builder.blender.org/download))?

Mingfen Wang commented

2014-11-01 07:07:44 +01:00

Yes, my patch is base on an old version, so I downloaded the latest build, but I find that I can not fix it, for the latest add-on changed a lot, and I am not familiar with python.
The important patches are only two lines, which are in the function of 'blen_read_object_transform_do', I just delete two lines of 'pre_rot' and 'pst_rot' according to the checkbox, here is the code:

  if settings.use_load_pre_post_rotation:
      return (
          lcl_translation *
          rot_ofs *
          rot_piv *
          pre_rot *
          lcl_rot *
          pst_rot *
          rot_piv.inverted() *
          sca_ofs *
          sca_piv *
          lcl_scale *
          sca_piv.inverted()
      )
  else:
      return (
          lcl_translation *
          rot_ofs *
          rot_piv *
          lcl_rot *
          rot_piv.inverted() *
          sca_ofs *
          sca_piv *
          lcl_scale *
          sca_piv.inverted()
      )

Yes, my patch is base on an old version, so I downloaded the latest build, but I find that I can not fix it, for the latest add-on changed a lot, and I am not familiar with python. The important patches are only two lines, which are in the function of 'blen_read_object_transform_do', I just delete two lines of 'pre_rot' and 'pst_rot' according to the checkbox, here is the code: ----------------------------------------------- ``` if settings.use_load_pre_post_rotation: return ( lcl_translation * rot_ofs * rot_piv * pre_rot * lcl_rot * pst_rot * rot_piv.inverted() * sca_ofs * sca_piv * lcl_scale * sca_piv.inverted() ) else: return ( lcl_translation * rot_ofs * rot_piv * lcl_rot * rot_piv.inverted() * sca_ofs * sca_piv * lcl_scale * sca_piv.inverted() ) ``` -----------------------------------------------

Bastien Montagne commented

2014-11-01 15:10:41 +01:00

Ok, should be able to redo that. :)