Redrawing dialogs/popups with ID properties #47691

New Issue

Aleksandr Zinovev · 2016-03-04T21:00:50+01:00

Aleksandr Zinovev commented

2016-03-04 21:00:50 +01:00

System Information
Kubuntu 15.10
Nvidia GeForce 9600 GT (driver: 340.96)

Blender Version
Broken: (2.76b)

Short description of error
Redrawing dialogs (invoke_props_dialog) doesn't work when changing ID property.
Works for popups (invoke_props_popup) but only after second redraw.

import bpy

class WM_OT_my_props_dialog(bpy.types.Operator):
    bl_idname = "wm.my_props_dialog"
    bl_label = "Props Dialog"
    bl_options = {'REGISTER', 'UNDO'}

    def check(self, context):
        return True

    def draw(self, context):
        layout = self.layout
        layout.prop(context.scene.objects, "active")
        if context.scene.objects.active:
            layout.prop(context.scene.objects.active, "data")

    def execute(self, context):
        return {'FINISHED'}

    def invoke(self, context, event):
        # return context.window_manager.invoke_props_dialog(self)
        return context.window_manager.invoke_props_popup(self, event)

bpy.utils.register_module(__name__)

bpy.ops.wm.my_props_dialog('INVOKE_DEFAULT')

Exact steps for others to reproduce the error

Run the script in blender's text editor.
Change active object 3 times (popup will be redrawn on 2nd and 3rd time).
Uncomment the line and repeat steps 1-2 with invoke_props_dialog.

**System Information** Kubuntu 15.10 Nvidia GeForce 9600 GT (driver: 340.96) **Blender Version** Broken: (2.76b) **Short description of error** Redrawing dialogs *(invoke_props_dialog)* doesn't work when changing ID property. Works for popups *(invoke_props_popup)* but only after second redraw. ![obj.gif](https://archive.blender.org/developer/F287649/obj.gif) ``` import bpy class WM_OT_my_props_dialog(bpy.types.Operator): bl_idname = "wm.my_props_dialog" bl_label = "Props Dialog" bl_options = {'REGISTER', 'UNDO'} def check(self, context): return True def draw(self, context): layout = self.layout layout.prop(context.scene.objects, "active") if context.scene.objects.active: layout.prop(context.scene.objects.active, "data") def execute(self, context): return {'FINISHED'} def invoke(self, context, event): # return context.window_manager.invoke_props_dialog(self) return context.window_manager.invoke_props_popup(self, event) bpy.utils.register_module(__name__) bpy.ops.wm.my_props_dialog('INVOKE_DEFAULT') ``` **Exact steps for others to reproduce the error** 1. Run the script in blender's text editor. 2. Change active object 3 times (popup will be redrawn on 2nd and 3rd time). 3. Uncomment the line and repeat steps 1-2 with *invoke_props_dialog*.

Aleksandr Zinovev commented

2016-03-04 21:00:50 +01:00

Changed status to: 'Open'

Aleksandr Zinovev commented

2016-03-04 21:00:50 +01:00

Added subscriber: @AleksandrZinovev-2

Campbell Barton commented

2016-03-04 21:03:53 +01:00

Added subscriber: @ideasman42

Campbell Barton commented

2016-03-04 21:03:53 +01:00

Did this ever work? if so what version.

Aleksandr Zinovev commented

2016-03-04 21:27:29 +01:00

No, afaik.
Tested in versions 2.71-2.76.

No, afaik. Tested in versions 2.71-2.76.

Campbell Barton commented

2016-03-07 06:31:17 +01:00

Investigated the bug,
The problem here is there is a button update callback which normally ensures changing the buttons re-draws the interface.

The dialog_check_cb callback initially set here:

https://developer.blender.org/diffusion/B/browse/master/source/blender/windowmanager/intern/wm_operators.c;431a5b623e2c7309517bdcaf3e665c08a6c3e2d0$1430

Is being overwritten by UI_but_func_search_set here:

https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface.c;431a5b623e2c7309517bdcaf3e665c08a6c3e2d0$4338

1   UI_but_func_set        interface.c         4150 0x15a6a2b      
2   UI_but_func_search_set interface.c         4338 0x15a83bc      
3   ui_but_add_search      interface_layout.c  1675 0x165eada      
4   uiItemFullR            interface_layout.c  1359 0x165b524      
5   rna_uiItemR            rna_ui_api.c        125  0x4254d89      
6   UILayout_prop_call     rna_ui_gen.c        1410 0x425e608

Investigated the bug, The problem here is there is a button update callback which normally ensures changing the buttons re-draws the interface. The `dialog_check_cb` callback initially set here: https://developer.blender.org/diffusion/B/browse/master/source/blender/windowmanager/intern/wm_operators.c;431a5b623e2c7309517bdcaf3e665c08a6c3e2d0$1430 Is being overwritten by `UI_but_func_search_set` here: https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface.c;431a5b623e2c7309517bdcaf3e665c08a6c3e2d0$4338 ``` 1 UI_but_func_set interface.c 4150 0x15a6a2b 2 UI_but_func_search_set interface.c 4338 0x15a83bc 3 ui_but_add_search interface_layout.c 1675 0x165eada 4 uiItemFullR interface_layout.c 1359 0x165b524 5 rna_uiItemR rna_ui_api.c 125 0x4254d89 6 UILayout_prop_call rna_ui_gen.c 1410 0x425e608 ```

blender-admin commented

2016-03-07 06:38:22 +01:00

This issue was referenced by blender/blender@19ec1bfa89

This issue was referenced by blender/blender@19ec1bfa89f74dbda02ce62fcf9c88032840c624

Campbell Barton commented

2016-03-07 06:49:53 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2016-03-07 06:49:53 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Redrawing dialogs/popups with ID properties #47691