Pose marker in camera action + marker bound to camera → crash #49489

New Issue

Sybren A. Stüvel · 2016-09-29T09:48:26+02:00

Sybren A. Stüvel commented

2016-09-29 09:48:26 +02:00

System Information
Kubuntu 16.04

Blender Version
Broken: current master (78c380d3b8)
Worked: unknown

Short description of error
When a pose marker is bound to a camera, and the pose marker is part of the camera's own action, it causes a crash when Blender opens the file. It seems to only happen when Blender is opened with that file, or when another file (or the default scene) was loaded first.

Exact steps for others to reproduce the error

Open this blend file posemarker-cam-crash1.blend
Crash

How to create this file:

Start with this file posemarker-cam-crash.blend
With the camera still selected, hover mouse over the pose marker F_30
Save the file
Open a another file, or close Blender completely.
Open the file in Blender.
Crash

**System Information** Kubuntu 16.04 **Blender Version** Broken: current master (78c380d3b84d53bf099b49571f0df67bea95bce2) Worked: unknown **Short description of error** When a pose marker is bound to a camera, and the pose marker is part of the camera's own action, it causes a crash when Blender opens the file. It seems to only happen when Blender is opened with that file, or when another file (or the default scene) was loaded first. **Exact steps for others to reproduce the error** 1. Open this blend file [posemarker-cam-crash1.blend](https://archive.blender.org/developer/F370461/posemarker-cam-crash1.blend) 2. Crash How to create this file: 1. Start with this file [posemarker-cam-crash.blend](https://archive.blender.org/developer/F370460/posemarker-cam-crash.blend) 2. With the camera still selected, hover mouse over the pose marker F_30 3. Save the file 4. Open a another file, or close Blender completely. 5. Open the file in Blender. 6. Crash

Sybren A. Stüvel commented

2016-09-29 09:48:26 +02:00

Changed status to: 'Open'

Sybren A. Stüvel commented

2016-09-29 09:48:26 +02:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2016-09-29 09:54:14 +02:00

The crash happens at anim_markers.c:408. The marker->camera pointer is not NULL, but not valid either.

The crash happens at `anim_markers.c:408`. The `marker->camera` pointer is not `NULL`, but not valid either.

Bastien Montagne commented

2016-09-29 16:04:34 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2016-09-29 16:04:34 +02:00

This is not actually a bug… action markers are not supposed to have cameras currently (scene ones either, actually, it’s a “temp Durian hack”, lol).

P406: #49489.diff

diff --git a/source/blender/blenloader/intern/readfile.c b/source/blender/blenloader/intern/readfile.c
index 60f276b..f204456 100644
--- a/source/blender/blenloader/intern/readfile.c
+++ b/source/blender/blenloader/intern/readfile.c
@@ -2498,6 +2498,7 @@ static void lib_link_action(FileData *fd, Main *main)
 {
 	bAction *act;
 	bActionChannel *chan;
+	TimeMarker *marker;
 
 	for (act = main->action.first; act; act = act->id.next) {
 		if (act->id.tag & LIB_TAG_NEED_LINK) {
@@ -2511,6 +2512,17 @@ static void lib_link_action(FileData *fd, Main *main)
 // >>> XXX deprecated - old animation system
 			
 			lib_link_fcurves(fd, &act->id, &act->curves);
+
+#ifdef DURIAN_CAMERA_SWITCH
+			for (marker = act->markers.first; marker; marker = marker->next) {
+				if (marker->camera) {
+					marker->camera = newlibadr(fd, act->id.lib, marker->camera);
+				}
+			}
+#else
+			(void)marker;
+#endif
+
 		}
 	}
 }
@@ -8860,6 +8872,18 @@ static void expand_action(FileData *fd, Main *mainvar, bAction *act)
 	
 	/* F-Curves in Action */
 	expand_fcurves(fd, mainvar, &act->curves);
+
+#ifdef DURIAN_CAMERA_SWITCH
+	{
+		TimeMarker *marker;
+
+		for (marker = act->markers.first; marker; marker = marker->next) {
+			if (marker->camera) {
+				expand_doit(fd, mainvar, marker->camera);
+			}
+		}
+	}
+#endif
 }
 
 static void expand_keyingsets(FileData *fd, Main *mainvar, ListBase *list)

adds needed read bits to correctly handle camera pointers in actions markers.

Note however that camera markers pointers are also missing from lib_query looper.

But imho, this should be added to some temp branch (or blender2.8), does not really makes sense to do changes here in master?

This is not actually a bug… action markers are not supposed to have cameras currently (scene ones either, actually, it’s a “temp Durian hack”, lol). [P406: #49489.diff](https://archive.blender.org/developer/P406.txt) ``` diff --git a/source/blender/blenloader/intern/readfile.c b/source/blender/blenloader/intern/readfile.c index 60f276b..f204456 100644 --- a/source/blender/blenloader/intern/readfile.c +++ b/source/blender/blenloader/intern/readfile.c @@ -2498,6 +2498,7 @@ static void lib_link_action(FileData *fd, Main *main) { bAction *act; bActionChannel *chan; + TimeMarker *marker; for (act = main->action.first; act; act = act->id.next) { if (act->id.tag & LIB_TAG_NEED_LINK) { @@ -2511,6 +2512,17 @@ static void lib_link_action(FileData *fd, Main *main) // >>> XXX deprecated - old animation system lib_link_fcurves(fd, &act->id, &act->curves); + +#ifdef DURIAN_CAMERA_SWITCH + for (marker = act->markers.first; marker; marker = marker->next) { + if (marker->camera) { + marker->camera = newlibadr(fd, act->id.lib, marker->camera); + } + } +#else + (void)marker; +#endif + } } } @@ -8860,6 +8872,18 @@ static void expand_action(FileData *fd, Main *mainvar, bAction *act) /* F-Curves in Action */ expand_fcurves(fd, mainvar, &act->curves); + +#ifdef DURIAN_CAMERA_SWITCH + { + TimeMarker *marker; + + for (marker = act->markers.first; marker; marker = marker->next) { + if (marker->camera) { + expand_doit(fd, mainvar, marker->camera); + } + } + } +#endif } static void expand_keyingsets(FileData *fd, Main *mainvar, ListBase *list) ``` adds needed read bits to correctly handle camera pointers in actions markers. Note however that camera markers pointers are also missing from lib_query looper. But imho, this should be added to some temp branch (or blender2.8), does not really makes sense to do changes here in master?

Sergey Sharybin commented

2016-09-29 17:22:45 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2016-09-29 17:22:45 +02:00

@mont29, we are on c11 now, so you can do for (Marker *foo = ...). I also not sure why to fix crash only in 2.8 branch?

@mont29, we are on c11 now, so you can do `for (Marker *foo = ...)`. I also not sure why to fix crash only in 2.8 branch?

Sybren A. Stüvel commented

2016-09-29 19:22:41 +02:00

The ability to link a camera to a marker is very useful, especially for the pose library, so that we can automatically render a pose from a certain camera. I don't care much for the user interface (I can create my own), but the data model is quite useful.

I also feel this should be fixed in master. This bug now can produce a file that crashes Blender and can't be fixed (without hacking binary stuff yourself).

The ability to link a camera to a marker is very useful, especially for the pose library, so that we can automatically render a pose from a certain camera. I don't care much for the user interface (I can create my own), but the data model is quite useful. I also feel this should be fixed in master. This bug now can produce a file that crashes Blender and can't be fixed (without hacking binary stuff yourself).

Bastien Montagne commented

2016-09-29 19:52:29 +02:00

What I mean is that this feature (ob pointer in marker) is, in current master, an (old, Durian) hack with very poor/incomplete support.

Fixing it is easy - but it would only be needed for new poselib system, which is 2.8 area… In current Blender, there is no way for user to set the ob pointer of an action marker (afaik?), this is only doable through RNA API.

What I mean is that this feature (ob pointer in marker) is, in current master, an (old, Durian) hack with very poor/incomplete support. Fixing it is easy - but it would only be needed for new poselib system, which is 2.8 area… In current Blender, there is no way for user to set the ob pointer of an action marker (afaik?), this is only doable through RNA API.

Joshua Leung commented

2016-09-30 09:21:53 +02:00

Added subscriber: @JoshuaLeung

Joshua Leung commented

2016-09-30 09:21:53 +02:00

Er... I think there might be a way to have markers-with-cameras-attached created in master by users without using py/rna. IIRC we have an operator to copy the current set of scene markers (or maybe just the selected ones) to be action markers instead. Check the action editor markers menu.

My 2 cents: IMO, in this case we should be fixing this crash in master.

Er... I think there might be a way to have markers-with-cameras-attached created in master by users without using py/rna. IIRC we have an operator to copy the current set of scene markers (or maybe just the selected ones) to be action markers instead. Check the action editor markers menu. My 2 cents: IMO, in this case we should be fixing this crash in master.

Bastien Montagne commented

2016-09-30 10:03:21 +02:00

Uuuuhhhh… OK… then yes, will fix that in master…

And will remove that 'durina hack' ifdef around core places where this pointer is handled (i.e. readfile.c and lib_query.c), too.

Uuuuhhhh… OK… then yes, will fix that in master… And will remove that 'durina hack' ifdef around core places where this pointer is handled (i.e. readfile.c and lib_query.c), too.

blender-admin commented

2016-09-30 10:11:29 +02:00

This issue was referenced by 85d543b4ac

This issue was referenced by 85d543b4acb35750ea81e12cc7c1cc5db55ce361

Bastien Montagne commented

2016-09-30 10:14:26 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2016-09-30 10:14:26 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Pose marker in camera action + marker bound to camera → crash #49489