Minor interface bug: UV/ImageEditor - Paint Mode - Fill Brush #50035

New Issue

Maestro Pivetta · 2016-11-15T15:54:10+01:00

Maestro Pivetta commented

2016-11-15 15:54:10 +01:00

System Information
Windows8 QuadroFX5800

Blender Version
Blender 2.78

Short description of error
When using paint mode in UV/ImageEditor by selecting the fill brush and choosing Erase or Add Alpha, the "Fill threshold" bar disappears. Function works well, only the treshold has to be selected on another blending mode.

Exact steps for others to reproduce the error
Open UV/ImageEditor, set to Paint, select the Fill brush, change mode from mix to Erase Alpha.

**System Information** Windows8 QuadroFX5800 **Blender Version** Blender 2.78 **Short description of error** When using paint mode in UV/ImageEditor by selecting the fill brush and choosing Erase or Add Alpha, the "Fill threshold" bar disappears. Function works well, only the treshold has to be selected on another blending mode. **Exact steps for others to reproduce the error** Open UV/ImageEditor, set to Paint, select the Fill brush, change mode from mix to Erase Alpha.

Maestro Pivetta commented

2016-11-15 15:54:10 +01:00

Changed status to: 'Open'

Maestro Pivetta commented

2016-11-15 15:54:10 +01:00

Added subscriber: @M.Pivetta

Luca Rood commented

2016-11-18 14:15:51 +01:00

Added subscriber: @LucaRood-3

Luca Rood commented

2016-11-18 14:15:51 +01:00

This fixes the issue:
P426: Fix for #50035

diff --git a/release/scripts/startup/bl_ui/properties_paint_common.py b/release/scripts/startup/bl_ui/properties_paint_common.py
index cca142b..fec6fdd 100644
--- a/release/scripts/startup/bl_ui/properties_paint_common.py
+++ b/release/scripts/startup/bl_ui/properties_paint_common.py
@@ -139,6 +139,9 @@ def brush_texpaint_common(panel, context, layout, brush, settings, projpaint=Fal
                     panel.prop_unified_color(row, context, brush, "secondary_color", text="")
                     row.separator()
                     row.operator("paint.brush_colors_flip", icon='FILE_REFRESH', text="")
+        else:
+            if brush.image_tool == 'FILL' and not projpaint:
+                col.prop(brush, "fill_threshold")
 
     elif brush.image_tool == 'SOFTEN':
         col = layout.column(align=True)

However, I think there is also an issue with the fill code itself, as it defines the fill area based on the threshold on the RGB channels, even when using the erase/add alpha blend mode. Shouldn't the fill area be defined using the values in the alpha channel itself?

This fixes the issue: [P426: Fix for #50035](https://archive.blender.org/developer/P426.txt) ```diff diff --git a/release/scripts/startup/bl_ui/properties_paint_common.py b/release/scripts/startup/bl_ui/properties_paint_common.py index cca142b..fec6fdd 100644 --- a/release/scripts/startup/bl_ui/properties_paint_common.py +++ b/release/scripts/startup/bl_ui/properties_paint_common.py @@ -139,6 +139,9 @@ def brush_texpaint_common(panel, context, layout, brush, settings, projpaint=Fal panel.prop_unified_color(row, context, brush, "secondary_color", text="") row.separator() row.operator("paint.brush_colors_flip", icon='FILE_REFRESH', text="") + else: + if brush.image_tool == 'FILL' and not projpaint: + col.prop(brush, "fill_threshold") elif brush.image_tool == 'SOFTEN': col = layout.column(align=True) ``` However, I think there is also an issue with the fill code itself, as it defines the fill area based on the threshold on the RGB channels, even when using the erase/add alpha blend mode. Shouldn't the fill area be defined using the values in the alpha channel itself?

Bastien Montagne commented

2016-11-18 14:51:07 +01:00

Added subscriber: @mont29

Bastien Montagne commented

2016-11-18 14:51:07 +01:00

UI fix looks OK to me.

Regarding using alpha channel, am not sure… can think cases where each (based on colors or based on alpha) situation is valid actually.

Also, current way to compute whether color is included in threshold factor looks slightly broken to me? Shouldn’t we multiply threshold by square root of three before using it to compare the squared sum of the three differences? afaict, full black versus full white will give squared distance of three, which is totally unreachable with a threshold in [0, 1] range?

UI fix looks OK to me. Regarding using alpha channel, am not sure… can think cases where each (based on colors or based on alpha) situation is valid actually. Also, current way to compute whether color is included in threshold factor looks slightly broken to me? Shouldn’t we multiply threshold by square root of three before using it to compare the squared sum of the three differences? afaict, full black versus full white will give squared distance of three, which is totally unreachable with a threshold in [0, 1] range?

blender-admin commented

2016-11-18 15:49:41 +01:00

This issue was referenced by 27de0c40c5

This issue was referenced by 27de0c40c594b9a2e853ec2c3c913d5a16e68e84

Bastien Montagne commented

2016-11-18 15:53:48 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2016-11-18 15:53:48 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Minor interface bug: UV/ImageEditor - Paint Mode - Fill Brush #50035