rake brush spacing wrong since revision 076616898b #53593

New Issue

Vilem Duha · 2017-12-19T22:21:58+01:00

Vilem Duha commented

2017-12-19 22:21:58 +01:00

this commit:
Fix #53577: Rake sculpt/paint wrong on first step
name

introduced a new bug:
spacing of the brush changes radically when scaling the brush, doesn't anymore work when the brush is scaled down beyond some ratio...it grows like it would be absolute distances or something, I don't see this quite clearly. The brush should behave consistently when scaled up/down...

In the uploaded file below, please test the 'seam' brush. the file itself should show the issue quite clearly, also attaching 2 screenshots.
seambug.blend

this bug:

VS old bug(first step wrong):

as a little side - note, I don't know why blender's rake option doesn't have an 'roll' option that would enable applying various alphas in much better way. see it here:
https://pixologic.com/zclassroom/lesson/alpha-roll
blender's rake actually always applies the center of the image. Roll means that the seamless alpha (should be seamless for this) is offset each brush step, and thus the brush-center of the image is taken from a different y-coordinate of the image. Probably also some image deform could be applied, but definitely just taking a different center/offseting each step would be a big + by now.

this commit: Fix #53577: Rake sculpt/paint wrong on first step [name ](https://developer.blender.org/rB076616898bff0acfc2336351ee975bd0fef944b2) introduced a new bug: spacing of the brush changes radically when scaling the brush, doesn't anymore work when the brush is scaled down beyond some ratio...it grows like it would be absolute distances or something, I don't see this quite clearly. The brush should behave consistently when scaled up/down... In the uploaded file below, please test the 'seam' brush. the file itself should show the issue quite clearly, also attaching 2 screenshots. [seambug.blend](https://archive.blender.org/developer/F1458813/seambug.blend) this bug: ![image.png](https://archive.blender.org/developer/F1458820/image.png) VS old bug(first step wrong): ![image.png](https://archive.blender.org/developer/F1458822/image.png) as a little side - note, I don't know why blender's rake option doesn't have an 'roll' option that would enable applying various alphas in much better way. see it here: https://pixologic.com/zclassroom/lesson/alpha-roll blender's rake actually always applies the center of the image. Roll means that the seamless alpha (should be seamless for this) is offset each brush step, and thus the brush-center of the image is taken from a different y-coordinate of the image. Probably also some image deform could be applied, but definitely just taking a different center/offseting each step would be a big + by now.

Vilem Duha commented

2017-12-19 22:21:58 +01:00

Added subscriber: @VilemDuha

Vilem Duha commented

2017-12-19 23:12:34 +01:00

I forgot to pack the brush alpha into the example file, here is the file also with the brush:
seambug.blend

I forgot to pack the brush alpha into the example file, here is the file also with the brush: [seambug.blend](https://archive.blender.org/developer/F1459040/seambug.blend)

Sergey Sharybin commented

2017-12-20 10:14:35 +01:00

Added subscribers: @ideasman42, @Sergey

Campbell Barton was assigned by Sergey Sharybin

2017-12-20 10:14:35 +01:00

Sergey Sharybin commented

2017-12-20 10:14:35 +01:00

@ideasman42, mind having a look? Thanks! :)

Vilem Duha commented

2017-12-25 09:53:59 +01:00

Peeked in the code and it's quite clear what happens.
the check if there's enough distance for estimating rake brush orientation is resetting, so small steps aren't possible.
The check should happen only on the beginning of the stroke, now it happens after every brush application...
Is that clear?

Peeked in the code and it's quite clear what happens. the check if there's enough distance for estimating rake brush orientation is resetting, so small steps aren't possible. The check should happen only on the beginning of the stroke, now it happens after every brush application... Is that clear?

Vilem Duha commented

2018-01-24 13:00:09 +01:00

There should be a bugfix release soon and this bug literally brakes sculpting.

blender-admin commented

2018-01-24 14:25:59 +01:00

This issue was referenced by bbc562fc69

This issue was referenced by bbc562fc69e1cb01d68877f002bb976881c08d3f

Brecht Van Lommel commented

2018-01-24 16:15:53 +01:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2018-01-24 16:15:53 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

rake brush spacing wrong since revision 076616898b #53593

rake brush spacing wrong since revision `076616898b` #53593