2.8 blender exit after particular event using short key #53647

New Issue

Ivaylo Gogov · 2017-12-28T10:36:26+01:00

Ivaylo Gogov commented

2017-12-28 10:36:26 +01:00

System Information
Windows 10, Nvidia GTX 2 x 1050 Ti

Blender Version
branch:2.8; bd80ace /2017-12-26

Short description of error

blender exit after particular event using short key

Exact steps for others to reproduce the error

I create a plane in any render mode in Blender, then I press "x" for delete the plane, then blender crass
crash_01.blend

**System Information** Windows 10, Nvidia GTX 2 x 1050 Ti **Blender Version** branch:2.8; bd80ace /2017-12-26 **Short description of error** - blender exit after particular event using short key **Exact steps for others to reproduce the error** - I create a plane in any render mode in Blender, then I press "x" for delete the plane, then blender crass [crash_01.blend](https://archive.blender.org/developer/F1559475/crash_01.blend)

Ivaylo Gogov commented

2017-12-28 10:36:26 +01:00

Added subscriber: @IvayloGogov

Philipp Oeser commented

2017-12-28 15:20:04 +01:00

Added subscribers: @dfelinto, @lichtwerk

Philipp Oeser commented

2017-12-28 15:20:04 +01:00

I can confirm this, crashes in outliner_build_tree() if the outliner is set to "Active" -- and there is no active object anymore after deletion...
Something like this prevents the crash
P584: #53647 prevent crash



diff --git a/source/blender/editors/space_outliner/outliner_tree.c b/source/blender/editors/space_outliner/outliner_tree.c
index a9c9ab74970..5130fdc3611 100644
--- a/source/blender/editors/space_outliner/outliner_tree.c
+++ b/source/blender/editors/space_outliner/outliner_tree.c
@@ -1959,7 +1959,9 @@ void outliner_build_tree(Main *mainvar, Scene *scene, ViewLayer *view_layer, Spa
 	}
 	else {
 		ten = outliner_add_element(soops, &soops->tree, OBACT(view_layer), NULL, 0, 0);
-		ten->directdata = BASACT(view_layer);
+		if (ten) {
+			ten->directdata = BASACT(view_layer);
+		}
 	}
 
 	if ((soops->flag & SO_SKIP_SORT_ALPHA) == 0) {

maybe @dfelinto can have a look?

I can confirm this, crashes in outliner_build_tree() if the outliner is set to "Active" -- and there is no active object anymore after deletion... Something like this prevents the crash [P584: #53647 prevent crash](https://archive.blender.org/developer/P584.txt) ``` diff --git a/source/blender/editors/space_outliner/outliner_tree.c b/source/blender/editors/space_outliner/outliner_tree.c index a9c9ab74970..5130fdc3611 100644 --- a/source/blender/editors/space_outliner/outliner_tree.c +++ b/source/blender/editors/space_outliner/outliner_tree.c @@ -1959,7 +1959,9 @@ void outliner_build_tree(Main *mainvar, Scene *scene, ViewLayer *view_layer, Spa } else { ten = outliner_add_element(soops, &soops->tree, OBACT(view_layer), NULL, 0, 0); - ten->directdata = BASACT(view_layer); + if (ten) { + ten->directdata = BASACT(view_layer); + } } if ((soops->flag & SO_SKIP_SORT_ALPHA) == 0) { ``` maybe @dfelinto can have a look?

blender-admin commented

2017-12-29 12:55:13 +01:00

This issue was referenced by f2a24afe8c

This issue was referenced by f2a24afe8c1aa0221b378585e3c1901cc568a6d7

Dalai Felinto commented

2017-12-29 12:56:45 +01:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2017-12-29 12:56:45 +01:00

Dalai Felinto commented

2017-12-29 12:57:47 +01:00

Done, @lichtwerk thanks for nailing the issue down.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

2.8 blender exit after particular event using short key #53647