Fix topbar region refresh issues #54753

New Issue

Brecht Van Lommel · 2018-04-21T13:42:50+02:00

Brecht Van Lommel commented

2018-04-21 13:42:50 +02:00

The topbar uses new dynamically sized regions, where the width of the region is defined by the buttons in it. This currently has refresh and flickering issues.

The problem is that the region width is only updated after drawing, and then on the next redraw the region gets the proper width. Two possible solutions:

Change area drawing to first compute the UI buttons in all regions in an area, then adjust the region sizes, and then draw the regions.
Instead of using dynamically sized regions, keep it all within one region and improve the UI layout and drawing code to support better alignment and separators.

The topbar uses new dynamically sized regions, where the width of the region is defined by the buttons in it. This currently has refresh and flickering issues. The problem is that the region width is only updated after drawing, and then on the next redraw the region gets the proper width. Two possible solutions: * Change area drawing to first compute the UI buttons in all regions in an area, then adjust the region sizes, and then draw the regions. * Instead of using dynamically sized regions, keep it all within one region and improve the UI layout and drawing code to support better alignment and separators.

Brecht Van Lommel commented

2018-04-21 13:42:50 +02:00

Added subscriber: @brecht

Julian Eisel commented

2018-04-21 15:23:41 +02:00

Added subscriber: @JulianEisel

Julian Eisel self-assigned this 2018-04-21 15:23:41 +02:00

Julian Eisel commented

2018-04-21 15:23:41 +02:00

I think this depends a bit on how we want to handle scrolling in the top-bar. If we don't want any scrolling and instead do things like moving tabs into a '...' menu if there are to many to display, the second solution sounds better. If we want to make sections scrollable option one should be the way to go.

Option one is a bit less of a hassle probably, although design wise I think number two sounds better.

I think this depends a bit on how we want to handle scrolling in the top-bar. If we don't want any scrolling and instead do things like moving tabs into a '...' menu if there are to many to display, the second solution sounds better. If we want to make sections scrollable option one should be the way to go. Option one is a bit less of a hassle probably, although design wise I think number two sounds better.

Brecht Van Lommel commented

2018-04-21 17:53:11 +02:00

Good point about scrolling.

The other thing is that I think it would be good to support addons registering custom regions in the topbar, and letting users resize them and toggle their visibility. Perhaps even letting users decide to have only a top bar or only a status bar, and what goes where then. With that kind of customization regions seem like a better fit.

Good point about scrolling. The other thing is that I think it would be good to support addons registering custom regions in the topbar, and letting users resize them and toggle their visibility. Perhaps even letting users decide to have only a top bar or only a status bar, and what goes where then. With that kind of customization regions seem like a better fit.

Julian Eisel was unassigned by Brecht Van Lommel

2018-04-29 22:05:27 +02:00

Brecht Van Lommel self-assigned this 2018-04-29 22:05:27 +02:00

Brecht Van Lommel commented

2018-04-29 22:07:24 +02:00

Since I was working on related code for WM drawing and popover refreshing, I went ahead and fixed this as well.

Julian Eisel commented

2018-04-30 10:08:00 +02:00

Thanks a lot! I did work on a patch taking the same direction as yours, just didn't get around to finish it. Glad it's fixed now!

Dalai Felinto commented

2018-04-30 10:10:06 +02:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2018-04-30 10:10:06 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix topbar region refresh issues #54753