Implement motion path drawing code in draw engine #54991

New Issue

Joshua Leung · 2018-05-07T17:26:58+02:00

Joshua Leung commented

2018-05-07 17:26:58 +02:00

Motion path drawing code (drawanimviz.c) is not currently implemented in 2.8, meaning that old files with motion paths and/or files where motionpaths have been freshly calculated do not show up.

Branch / Current Code: tmp-b28-motionpath-drawing

Design Notes:

This should work as an overlay (visible in the overlays popover), so that it can be turned on/off independent of other stuff we draw in the viewport. It should not be tied to manipulator/relationship line visibility.
Motion paths work with both objects and bones. They can either be defined on Object Level (e.g. ob->mpath), or Bone Level (e.g. pchan->mpath)
The old drawing methods use immediate mode. Could/should be optimised.
Appearance could be updated a bit - for example, thicker/nicer line quality + shading, different ways of visualising the keyframe positions (e.g. with lines perpendicular to path - similar to what animators use for timing charts - [ - ], [http:*www.brianlemay.com/Pages/animationschool/animation/lipsyncbook/timingcharts.html | 2 ]

Motion path drawing code (drawanimviz.c) is not currently implemented in 2.8, meaning that old files with motion paths and/or files where motionpaths have been freshly calculated do not show up. **Branch / Current Code**: `tmp-b28-motionpath-drawing` **Design Notes:** * This should work as an overlay (visible in the overlays popover), so that it can be turned on/off independent of other stuff we draw in the viewport. It should not be tied to manipulator/relationship line visibility. * Motion paths work with both objects and bones. They can either be defined on Object Level (e.g. ob->mpath), or Bone Level (e.g. pchan->mpath) * The old drawing methods use immediate mode. Could/should be optimised. * Appearance could be updated a bit - for example, thicker/nicer line quality + shading, different ways of visualising the keyframe positions (e.g. with lines perpendicular to path - similar to what animators use for timing charts - [ - [x]], [[http:*www.brianlemay.com/Pages/animationschool/animation/lipsyncbook/timingcharts.html | 2](http:*profspevack.com/archive/animation/course_cal/week05/week05.html) ]

Joshua Leung commented

2018-05-07 17:26:58 +02:00

Added subscriber: @JoshuaLeung

Joshua Leung commented

2018-05-11 18:16:53 +02:00

Added subscriber: @Jeroen-Bakker

Joshua Leung self-assigned this 2018-05-14 13:37:07 +02:00

Luciano Muñoz Sessarego commented

2018-05-14 18:49:59 +02:00

Added subscriber: @LucianoMunoz

Joshua Leung removed their assignment 2018-05-22 12:09:10 +02:00

Clément Foucault was assigned by Joshua Leung

2018-05-22 12:09:10 +02:00

Joshua Leung commented

2018-05-22 12:09:10 +02:00

Added subscriber: @fclem

Joshua Leung commented

2018-05-22 12:09:10 +02:00

Offloading to @fclem who can probably do this faster, while I deal with nasty Copy-on-Write issues.

Current WIP code can be found in the tmp-b28-motionpath-drawing branch.

Offloading to @fclem who can probably do this faster, while I deal with nasty Copy-on-Write issues. Current WIP code can be found in the `tmp-b28-motionpath-drawing` branch.

Luciano Muñoz Sessarego commented

2018-05-22 12:30:08 +02:00

Please consider an option to offset the motion path!, example, i create a motion path on the head bone but i want to offset it to the forehead, or to the tip of the ear (which are directly moved by the head joing)

Joshua Leung commented

2018-05-22 12:38:32 +02:00

@LucianoMunoz That is a separate topic - Calculation of motion paths is not the same as the drawing code (which this task focusses on restoring).

Regarding what you're talking about - we have been discussing ideas for allowing calculation of paths for arbitrary geometry points instead of just objects/bones (e.g. using the derived center-of-gravity for a body part for instance). But, again, that's a separate topic, to be tackled separately/later once we get back basic functionality (with maybe a slight cosmetic upgrade).

@LucianoMunoz That is a separate topic - Calculation of motion paths is not the same as the drawing code (which this task focusses on restoring). Regarding what you're talking about - we have been discussing ideas for allowing calculation of paths for arbitrary geometry points instead of just objects/bones (e.g. using the derived center-of-gravity for a body part for instance). But, again, that's a separate topic, to be tackled separately/later once we get back basic functionality (with maybe a slight cosmetic upgrade).

Luciano Muñoz Sessarego commented

2018-05-22 12:40:25 +02:00

oh cool, sorry for spamming the wrong thread, if you want to point me in the right direction it Id be happy to contribute :)

Luciano Muñoz Sessarego commented

2018-05-22 12:42:18 +02:00

in regards to drawing, maybe there could be an option to randomize colors for them, so each new path gets a different color, though they should probably go in order, Ie, 1 gets red, the second one gets green, the third one gets blue and so on, much easier to see, and the thicknes definitelly should be like what in 2.79 wa 2 px or so.

Daniel Paul commented

2018-05-28 14:52:25 +02:00

Added subscriber: @DanielPaul

Daniel Paul commented

2018-05-28 14:52:25 +02:00

Im not sure if i overlooked something in the description above,
but will the motion paths be calculated automatically.
So we dont have to set the framerange, only a max and min frame value would be nice.

Im not sure how dificult this is, but it would be a nice way to diplay the motion path.
Also the tangent editing is nice.

Im not sure if i overlooked something in the description above, but will the motion paths be calculated automatically. So we dont have to set the framerange, only a max and min frame value would be nice. Im not sure how dificult this is, but it would be a nice way to diplay the motion path. Also the tangent editing is nice. ![Animationcurve_01.gif](https://archive.blender.org/developer/F3489132/Animationcurve_01.gif)

Joshua Leung commented

2018-05-28 14:57:35 +02:00

@DanielPaul

Auto calculation is a separate topic - it's not related to the drawing.
The main interesting features of that mockup are the explicit display of the start/end frames. Otherwise, it's actually pretty much just the standard display
"Tangent editing" or just general motion path editing is actually a lot harder than it looks - especially in everything other than the most basic case. Unfortunately, you can't just support that simple case, as people will want the others too. Anyway, again this is separate from the issue of just getting drawing code working

@DanielPaul - Auto calculation is a separate topic - it's not related to the drawing. - The main interesting features of that mockup are the explicit display of the start/end frames. Otherwise, it's actually pretty much just the standard display - "Tangent editing" or just general motion path editing is actually a lot harder than it looks - especially in everything other than the most basic case. Unfortunately, you can't just support that simple case, as people will want the others too. Anyway, again this is separate from the issue of just getting drawing code working

Clément Foucault commented

2018-05-30 00:07:40 +02:00

@JoshuaLeung

Is there a reason not to tag the baked motion path verts if there are on a keyframe? It would simplify the whole drawing a lot.
Also I don't see the point of showing synced keyframe marker but at the baked position.

@JoshuaLeung Is there a reason not to tag the baked motion path verts if there are on a keyframe? It would simplify the whole drawing a lot. Also I don't see the point of showing synced keyframe marker but at the baked position.

Luciano Muñoz Sessarego commented

2018-05-30 18:04:05 +02:00

its important to show the keyframes in the motion path of the selected object, which is not necesarilly the object from which the motion path is calculated.

Clément Foucault commented

2018-05-30 22:49:32 +02:00

@LucianoMunoz
I don't understand. Keyframes are only showed when there is keys are on the motion path, which is baked from an object/bone.
I don't even think that's possible to show the selected object keyframe on another path in 2.7.

Also for the record, I talked with @JoshuaLeung IRL and he told me it was ok to bake the keyframes into the motionpath verts.

@LucianoMunoz I don't understand. Keyframes are only showed when there is keys are on the motion path, which is baked from an object/bone. I don't even think that's possible to show the selected object keyframe on another path in 2.7. Also for the record, I talked with @JoshuaLeung IRL and he told me it was ok to bake the keyframes into the motionpath verts.

Luciano Muñoz Sessarego commented

2018-05-30 22:53:47 +02:00

that is accurate. in 2.7 it doesnt work like this, but this isnt useful at all, as an animator you want to see in the path the keyframes of the currently selected object that affects it,
example: the path is set to the head control, but i have the hip selected, the path should show the keys of the hip, because that´s what im modifiying that will ultimately affect the path because of the hierarchy (you should try to confirm with hjalti, he knows exactly what im talking about)

that is accurate. in 2.7 it doesnt work like this, but this isnt useful at all, as an animator you want to see in the path the keyframes of the currently selected object that affects it, example: the path is set to the head control, but i have the hip selected, the path should show the keys of the hip, because that´s what im modifiying that will ultimately affect the path because of the hierarchy (you should try to confirm with hjalti, he knows exactly what im talking about)

Dalai Felinto commented

2018-06-04 10:25:04 +02:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2018-06-04 10:25:04 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Implement motion path drawing code in draw engine #54991