(Certain) shapekeys stopped working in 2.8 #60783

New Issue

Daniel Salazar · 2019-01-23T06:20:21+01:00

Daniel Salazar commented

2019-01-23 06:20:21 +01:00

System Information
Operating system: Windows 10 64
Graphics card: GTX 1080

Blender Version
Broken: dc3b5024be

Short description of error
Recent builds broke shapekeys on this object. If you delete all shapekeys including base and add a new shapekey it will work.

ShapekeyBug.blend

Exact steps for others to reproduce the error
Open provided blend file and change value of shapekey 01. Nothing will happen even when the shapekey should show a deformation

**System Information** Operating system: Windows 10 64 Graphics card: GTX 1080 **Blender Version** Broken: dc3b5024be1a **Short description of error** Recent builds broke shapekeys on this object. If you delete all shapekeys including base and add a new shapekey it will work. [ShapekeyBug.blend](https://archive.blender.org/developer/F6375315/ShapekeyBug.blend) **Exact steps for others to reproduce the error** Open provided blend file and change value of shapekey 01. Nothing will happen even when the shapekey should show a deformation

Daniel Salazar commented

2019-01-23 06:20:21 +01:00

Added subscriber: @zanqdo

blender-admin commented

2019-01-23 06:20:21 +01:00

#60858 was marked as duplicate of this issue

Philipp Oeser commented

2019-01-23 11:56:54 +01:00

Added subscribers: @mont29, @lichtwerk

Philipp Oeser commented

2019-01-23 11:56:54 +01:00

Not sure if this has the same roots as #60401, #60249
There was also the fix by @mont29 (47be4e9a33)

But I can confirm example file is not working in 2.8 (if you append this into 2.79 it is working though...)

Not sure if this has the same roots as #60401, #60249 There was also the fix by @mont29 (47be4e9a33) But I can confirm example file is not working in 2.8 (if you append this into 2.79 it is working though...)

Philipp Oeser changed title from ~~Shapekeys stopped working in 2.8~~ to (Certain) shapekeys stopped working in 2.8

2019-01-23 11:57:51 +01:00

Bastien Montagne self-assigned this 2019-01-23 14:00:10 +01:00

Bastien Montagne commented

2019-01-23 14:00:10 +01:00

Will check that

Bastien Montagne commented

2019-01-24 14:41:41 +01:00

This is kind of expected, since this mesh's shpaekey does not have the 'user' ('from') pointer set properly. This makes it a corrupted file, so what we need here is a way to reproduce such error.

(If you remove all shapekeys and add new one, everything works as expected).

This is kind of expected, since this mesh's shpaekey does not have the 'user' ('from') pointer set properly. This makes it a corrupted file, so what we need here is a way to reproduce such error. (If you remove all shapekeys and add new one, everything works as expected).

Philipp Oeser commented

2019-01-24 14:45:35 +01:00

just out of pure interest: are we stricter here in 2.8? (since 2.79 handles the appended ob nicely?)

Bastien Montagne commented

2019-01-24 17:53:45 +01:00

Yes, since shapekeys are now often evaluated in CoW context (i.e. with IDs that are not orig ones), the 'fix' that was setting 'from' pointer to correct ID when it was NULL is no more valid, and had to be removed (47be4e9a33).

In any case, doing that sort of on-the-fly fixes is very, very bad practice, since it allows real bug(s) to remain unnoticed forever. So now we need to know how that bloody pointer can get NULLified.

Yes, since shapekeys are now often evaluated in CoW context (i.e. with IDs that are not orig ones), the 'fix' that was setting 'from' pointer to correct ID when it was NULL is no more valid, and had to be removed (47be4e9a33). In any case, doing that sort of on-the-fly fixes is very, very bad practice, since it allows real bug(s) to remain unnoticed forever. So now we need to know how that bloody pointer can get NULLified.

Daniel Salazar commented

2019-01-24 21:13:47 +01:00

Oh boy.. we where using a blender build from about 2 weeks or so, that's all I can think of

Brecht Van Lommel commented

2019-01-25 15:05:02 +01:00

Added subscribers: @HenriqueGonzaga, @WilliamReynish

Brecht Van Lommel commented

2019-01-25 15:08:24 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-01-25 15:08:24 +01:00

@mont29, from might be NULL if it was saved with a COW id.

Can we do a version patch to fix such broken from pointers?

@mont29, `from` might be `NULL` if it was saved with a COW id. Can we do a version patch to fix such broken `from` pointers?

Bastien Montagne commented

2019-01-25 15:12:25 +01:00

@brecht actually, was thinking about doing a systematic check on load for that, and also add a check for that issue on write (in our optional 'check file validity' that was also used to track down the library issue at the studio).

Not sure which one is best, doing do_version only, or systematic check (at least for now), at read time?

@brecht actually, was thinking about doing a systematic check on load for that, and also add a check for that issue on write (in our optional 'check file validity' that was also used to track down the library issue at the studio). Not sure which one is best, doing do_version only, or systematic check (at least for now), at read time?

Brecht Van Lommel commented

2019-01-25 15:25:54 +01:00

@mont29, always doing it as part of lib linking seems fine too.

At some point we should really make Key not a datablock anymore, it makes no sense, but it's probably somewhat tricky.

@mont29, always doing it as part of lib linking seems fine too. At some point we should really make `Key` not a datablock anymore, it makes no sense, but it's probably somewhat tricky.

blender-admin commented

2019-01-25 17:42:43 +01:00

This issue was referenced by da6bda6483

This issue was referenced by da6bda64839e91dea4e6a7c144f8ae30e2d9076b

Bastien Montagne commented

2019-01-25 17:48:20 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2019-01-25 17:48:20 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

(Certain) shapekeys stopped working in 2.8 #60783