Multires modifier memory leak #60840

New Issue

Tal Hershkovich · 2019-01-25T00:44:37+01:00

Tal Hershkovich commented

2019-01-25 00:44:37 +01:00

System Information
Operating system: Windows 10
Graphics card: GeForce GTX 1070/PCIe/SSE2

Blender Version
Broken: 2.80, 2019-01-19, hash: b0dee09a6d
Worked: (optional)

Short description of error
Every time I pose the character the memory goes up more and more until the ram is completly full, when starting a new scene it also keeps going up and being released only after closing blender. the solution was to delete all the multires modfiers

Exact steps for others to reproduce the error
open the file Arnold_2.8.blend and start the task manager. move the character from the torso or any other controller more times then on the undo list. The Ram will go up always.
Delete all the multires modifiers via the outliner and the problem is solved

**System Information** Operating system: Windows 10 Graphics card: GeForce GTX 1070/PCIe/SSE2 **Blender Version** Broken: 2.80, 2019-01-19, hash: b0dee09a6d55 Worked: (optional) **Short description of error** Every time I pose the character the memory goes up more and more until the ram is completly full, when starting a new scene it also keeps going up and being released only after closing blender. the solution was to delete all the multires modfiers **Exact steps for others to reproduce the error** open the file [Arnold_2.8.blend](https://archive.blender.org/developer/F6394163/Arnold_2.8.blend) and start the task manager. move the character from the torso or any other controller more times then on the undo list. The Ram will go up always. Delete all the multires modifiers via the outliner and the problem is solved

Tal Hershkovich commented

2019-01-25 00:44:37 +01:00

Added subscriber: @TalHershkovich

Sergey Sharybin was assigned by Jacques Lucke

2019-01-25 17:57:55 +01:00

Sergey Sharybin commented

2019-01-25 18:05:15 +01:00

Added subscribers: @mont29, @ideasman42

Sergey Sharybin commented

2019-01-25 18:05:15 +01:00

Doesn't seem to be multires related. Even with P899: (An Untitled Masterwork)

diff --git a/source/blender/modifiers/intern/MOD_multires.c b/source/blender/modifiers/intern/MOD_multires.c
index a18fd6a4c5e..fae8d264615 100644
--- a/source/blender/modifiers/intern/MOD_multires.c
+++ b/source/blender/modifiers/intern/MOD_multires.c
@@ -152,6 +152,7 @@ static Mesh *applyModifier(ModifierData *md,
                            const ModifierEvalContext *ctx,
                            Mesh *mesh)
 {
+	return mesh;
 	Mesh *result = mesh;
 	MultiresModifierData *mmd = (MultiresModifierData *)md;
 	SubdivSettings subdiv_settings;
diff --git a/source/blender/modifiers/intern/MOD_subsurf.c b/source/blender/modifiers/intern/MOD_subsurf.c
index 3cabd1131cb..fafd04d761f 100644
--- a/source/blender/modifiers/intern/MOD_subsurf.c
+++ b/source/blender/modifiers/intern/MOD_subsurf.c
@@ -199,6 +199,7 @@ static Mesh *applyModifier(ModifierData *md,
                            const ModifierEvalContext *ctx,
                            Mesh *mesh)
 {
+	return mesh;
 	Mesh *result = mesh;
 	SubsurfModifierData *smd = (SubsurfModifierData *) md;
 	SubdivSettings subdiv_settings;

applied the memory is still leaking. (Also, simplification is enabled at level 0, so don't think any of subsurf/multires is active).

So maybe @mont29 or @ideasman42 will be faster than me in fixing this.

Doesn't seem to be multires related. Even with [P899: (An Untitled Masterwork)](https://archive.blender.org/developer/P899.txt) ``` diff --git a/source/blender/modifiers/intern/MOD_multires.c b/source/blender/modifiers/intern/MOD_multires.c index a18fd6a4c5e..fae8d264615 100644 --- a/source/blender/modifiers/intern/MOD_multires.c +++ b/source/blender/modifiers/intern/MOD_multires.c @@ -152,6 +152,7 @@ static Mesh *applyModifier(ModifierData *md, const ModifierEvalContext *ctx, Mesh *mesh) { + return mesh; Mesh *result = mesh; MultiresModifierData *mmd = (MultiresModifierData *)md; SubdivSettings subdiv_settings; diff --git a/source/blender/modifiers/intern/MOD_subsurf.c b/source/blender/modifiers/intern/MOD_subsurf.c index 3cabd1131cb..fafd04d761f 100644 --- a/source/blender/modifiers/intern/MOD_subsurf.c +++ b/source/blender/modifiers/intern/MOD_subsurf.c @@ -199,6 +199,7 @@ static Mesh *applyModifier(ModifierData *md, const ModifierEvalContext *ctx, Mesh *mesh) { + return mesh; Mesh *result = mesh; SubsurfModifierData *smd = (SubsurfModifierData *) md; SubdivSettings subdiv_settings; ``` applied the memory is still leaking. (Also, simplification is enabled at level 0, so don't think any of subsurf/multires is active). So maybe @mont29 or @ideasman42 will be faster than me in fixing this.

Bastien Montagne commented

2019-01-26 01:14:18 +01:00

Indeed some modifiers are very bad here (not taking care of non-ID pointers when copying themselves, have patch for that will commit tomorrow). Looks like there is more memleak though… :/

Sergey Sharybin was unassigned by Bastien Montagne

2019-01-26 01:14:34 +01:00

Bastien Montagne self-assigned this 2019-01-26 01:14:34 +01:00

Bastien Montagne commented

2019-01-26 01:14:34 +01:00

Added subscriber: @Sergey

blender-admin commented

2019-01-28 21:46:05 +01:00

This issue was referenced by 147e22ef70

This issue was referenced by 147e22ef700124dcbaa5576b72a2a77e73adf350

Bastien Montagne commented

2019-01-28 21:55:11 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2019-01-28 21:55:11 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Multires modifier memory leak #60840