Backtrace when importing FBX file from the Unity asset store #62984

New Issue

Pete Chown · 2019-03-26T20:48:11+01:00

Pete Chown commented

2019-03-26 20:48:11 +01:00

System Information
Operating system: Linux-4.15.0-46-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 415.27

Blender Version
Broken: version: 2.80 (sub 51), branch: blender2.7, commit date: 2019-03-25 23:15, hash: adfdae3fc2
Worked: (optional)

Short description of error
Backtrace when importing some FBX files.

Exact steps for others to reproduce the error
Unfortunately providing exact reproduction steps is difficult because the FBX file is not mine to distribute; it's from the Unity asset store. However I have a fix and I think it makes sense bearing in mind the surrounding code. First of all, this is the backtrace:

Traceback (most recent call last):
  File "/nobackup/src/blender-2.80-adfdae3fc2f4-linux-glibc224-x86_64/2.80/scripts/addons/io_scene_fbx/__init__.py", line 231, in execute
    return import_fbx.load(self, context, **keywords)
  File "/nobackup/src/blender-2.80-adfdae3fc2f4-linux-glibc224-x86_64/2.80/scripts/addons/io_scene_fbx/import_fbx.py", line 2889, in load
    _(); del _
  File "/nobackup/src/blender-2.80-adfdae3fc2f4-linux-glibc224-x86_64/2.80/scripts/addons/io_scene_fbx/import_fbx.py", line 2887, in _
    blen_read_animations(fbx_tmpl_astack, fbx_tmpl_alayer, stacks, scene, settings.anim_offset)
  File "/nobackup/src/blender-2.80-adfdae3fc2f4-linux-glibc224-x86_64/2.80/scripts/addons/io_scene_fbx/import_fbx.py", line 720, in blen_read_animations
    if id_data.type == 'MESH' and id_data.parent and id_data.parent.type == 'ARMATURE':
AttributeError: 'NoneType' object has no attribute 'type'

That section of code looks like this (from 2.80/scripts/addons/io_scene_fbx/import_fbx.py):

                if isinstance(item, Material):
                    id_data = item
                elif isinstance(item, ShapeKey):
                    id_data = item.id_data
                elif isinstance(item, Camera):
                    id_data = item
                else:
                    id_data = item.bl_obj
                    - XXX Ignore rigged mesh animations - those are a nightmare to handle, see note about it in
                    - FbxImportHelperNode class definition.
                    if id_data.type == 'MESH' and id_data.parent and id_data.parent.type == 'ARMATURE':
                        continue
                if id_data is None:
                    continue

The exception is thrown on the id_data.type == 'MESH' line and it happens because id_data is None. The next statement tests for this condition and if it holds, executes continue. It seems reasonable then to change the line to read:

                    if id_data is not None and id_data.type == 'MESH' and id_data.parent and id_data.parent.type == 'ARMATURE':

What do you think? This fix seems to allow correct imports of the FBX file concerned on my system.

**System Information** Operating system: Linux-4.15.0-46-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 415.27 **Blender Version** Broken: version: 2.80 (sub 51), branch: blender2.7, commit date: 2019-03-25 23:15, hash: `adfdae3fc2` Worked: (optional) **Short description of error** Backtrace when importing some FBX files. **Exact steps for others to reproduce the error** Unfortunately providing exact reproduction steps is difficult because the FBX file is not mine to distribute; it's from the Unity asset store. However I have a fix and I think it makes sense bearing in mind the surrounding code. First of all, this is the backtrace: ``` Traceback (most recent call last): File "/nobackup/src/blender-2.80-adfdae3fc2f4-linux-glibc224-x86_64/2.80/scripts/addons/io_scene_fbx/__init__.py", line 231, in execute return import_fbx.load(self, context, **keywords) File "/nobackup/src/blender-2.80-adfdae3fc2f4-linux-glibc224-x86_64/2.80/scripts/addons/io_scene_fbx/import_fbx.py", line 2889, in load _(); del _ File "/nobackup/src/blender-2.80-adfdae3fc2f4-linux-glibc224-x86_64/2.80/scripts/addons/io_scene_fbx/import_fbx.py", line 2887, in _ blen_read_animations(fbx_tmpl_astack, fbx_tmpl_alayer, stacks, scene, settings.anim_offset) File "/nobackup/src/blender-2.80-adfdae3fc2f4-linux-glibc224-x86_64/2.80/scripts/addons/io_scene_fbx/import_fbx.py", line 720, in blen_read_animations if id_data.type == 'MESH' and id_data.parent and id_data.parent.type == 'ARMATURE': AttributeError: 'NoneType' object has no attribute 'type' ``` That section of code looks like this (from 2.80/scripts/addons/io_scene_fbx/import_fbx.py): ``` if isinstance(item, Material): id_data = item elif isinstance(item, ShapeKey): id_data = item.id_data elif isinstance(item, Camera): id_data = item else: id_data = item.bl_obj - XXX Ignore rigged mesh animations - those are a nightmare to handle, see note about it in - FbxImportHelperNode class definition. if id_data.type == 'MESH' and id_data.parent and id_data.parent.type == 'ARMATURE': continue if id_data is None: continue ``` The exception is thrown on the `id_data.type == 'MESH'` line and it happens because `id_data` is `None`. The next statement tests for this condition and if it holds, executes `continue`. It seems reasonable then to change the line to read: ``` if id_data is not None and id_data.type == 'MESH' and id_data.parent and id_data.parent.type == 'ARMATURE': ``` What do you think? This fix seems to allow correct imports of the FBX file concerned on my system.

Pete Chown commented

2019-03-26 20:48:11 +01:00

Added subscriber: @PeteX-2