Dopesheet click-drag-selection deselects channels [e.g. breaking copy-pasting keys workflow] #70457

New Issue

iurimonteiro · 2019-10-02T18:32:51+02:00

iurimonteiro commented

2019-10-02 18:32:51 +02:00

System Information
Operating system: Windows 10
Blender Version
Broken: (example: 2.80, edbf15d3c0, master, 2018-11-28, as found on the splash screen)

gif showing the error
https://imgur.com/a/J7wiido

Quick detour beforehand: copy-paste behaviour is dependent on row/channels selection:

if you have no row/channels selected, all copied keyframes will be pasted
if you have only a subset of row/channels selected, only keyframes matching this selection will be pasted [afaik this is expected behavior and was also the case in 2.79]

OK, now click-drag-box-selecting does not play very nice with this:

once started, all previously selected rows/channels will be deselected [thats pretty bad workflow-wise, box selection with B doesnt suffer from this]
if you happen to start the drag on a particular row/channel, only that row/channel will get selected [equally bad]

original report:
When you select with the mouse, click, drag and select the keys copy and paste (having more that 2 channels with keyframes like in the gif selected) he will only select 1 channel and only pastes 1 channel and not the 3. There are other work arounds like I show in the gif so that this doesnt happen like clicking B ou selecting from down to the channels you want.

**System Information** Operating system: Windows 10 **Blender Version** Broken: (example: 2.80, edbf15d3c044, master, 2018-11-28, as found on the splash screen) gif showing the error https://imgur.com/a/J7wiido Quick detour beforehand: copy-paste behaviour is dependent on row/channels selection: - if you have no row/channels selected, all copied keyframes will be pasted - if you have only a subset of row/channels selected, only keyframes matching this selection will be pasted [afaik this is expected behavior and was also the case in 2.79] OK, now click-drag-box-selecting does not play very nice with this: - once started, all previously selected rows/channels will be deselected [thats pretty bad workflow-wise, box selection with B doesnt suffer from this] - if you happen to start the drag on a particular row/channel, only that row/channel will get selected [equally bad] original report: When you select with the mouse, click, drag and select the keys copy and paste (having more that 2 channels with keyframes like in the gif selected) he will only select 1 channel and only pastes 1 channel and not the 3. There are other work arounds like I show in the gif so that this doesnt happen like clicking B ou selecting from down to the channels you want.

iurimonteiro commented

2019-10-02 18:32:51 +02:00

Added subscriber: @iurimonteiro

Brecht Van Lommel commented

2019-10-02 23:21:09 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-10-02 23:21:09 +02:00

Please provide all the requested information in the bug submission form.

In particular, a .blend file with exact steps to reproduce the problem, and the exact Blender version.

Please provide all the requested information in the bug submission form. In particular, a .blend file with exact steps to reproduce the problem, and the exact Blender version.

iurimonteiro commented

2019-10-02 23:27:54 +02:00

blender 2.8

gif showing the error
https://imgur.com/a/J7wiido

Gif tell it all. Blendfile.blend

blender 2.8 gif showing the error https://imgur.com/a/J7wiido Gif tell it all. [Blendfile.blend](https://archive.blender.org/developer/F7786460/Blendfile.blend)

Brecht Van Lommel commented

2019-10-02 23:29:59 +02:00

Blender 2.8 is not a specific version, probably you mean the Blender 2.80 official release.

iurimonteiro commented

2019-10-03 13:10:19 +02:00

yes

Philipp Oeser commented

2019-10-18 15:55:01 +02:00

Added subscribers: @WilliamReynish, @JulianEisel, @lichtwerk

Philipp Oeser commented

2019-10-18 15:55:01 +02:00

Can confirm, seems like tweak-box-selecting multiple rows/channels doesnt work so well:

Quick detour beforehand: copy-paste behaviour is dependent on row/channels selection:

if you have no row/channels selected, all copied keyframes will be pasted
if you have only a subset of row/channels selected, only keyframes matching this selection will be pasted [afaik this is expected behavior and was also the case in 2.79]

OK, now click-drag-box-selecting does not play very nice with this:

once started, all previously selected rows/channels will be deselected [thats pretty bad workflow-wise, box selection with B doesnt suffer from this]
if you happen to start the drag on a particular row/channel, only that row/channel will get selected [equally bad]

CC @WilliamReynish
CC @JulianEisel

Can confirm, seems like tweak-box-selecting multiple rows/channels doesnt work so well: Quick detour beforehand: copy-paste behaviour is dependent on row/channels selection: - if you have no row/channels selected, all copied keyframes will be pasted - if you have only a subset of row/channels selected, only keyframes matching this selection will be pasted [afaik this is expected behavior and was also the case in 2.79] OK, now click-drag-box-selecting does not play very nice with this: - once started, all previously selected rows/channels will be deselected [thats pretty bad workflow-wise, box selection with `B` doesnt suffer from this] - if you happen to start the drag on a particular row/channel, only that row/channel will get selected [equally bad] CC @WilliamReynish CC @JulianEisel

Philipp Oeser changed title from ~~Dopesheet Timeline select and copy frames with mouse~~ to Dopesheet click-drag-selection deselects channels [e.g. breaking copy-pasting keys workflow]

2019-10-18 15:57:12 +02:00

Sybren A. Stüvel commented

2020-01-13 17:39:15 +01:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2020-01-13 17:39:15 +01:00

Changed status from 'Confirmed' to: 'Needs User Info'

Sybren A. Stüvel commented

2020-01-13 17:39:15 +01:00

Please attach a blend file that demonstrates the issue. The file attached earlier doesn't seem to have any animation at all.

Richard Antalik commented

2020-01-14 12:19:22 +01:00

Added subscriber: @iss

Richard Antalik commented

2020-01-14 12:19:22 +01:00

Changed status from 'Needs User Info' to: 'Archived'

Richard Antalik closed this issue

2020-01-14 12:19:22 +01:00

Richard Antalik self-assigned this 2020-01-14 12:19:22 +01:00

Richard Antalik commented

2020-01-14 12:19:22 +01:00

Can not reproduce this issue.

Philipp Oeser commented

2020-01-14 13:23:22 +01:00

Changed status from 'Archived' to: 'Confirmed'

Philipp Oeser reopened this issue

2020-01-14 13:23:22 +01:00

Philipp Oeser commented

2020-01-14 13:23:22 +01:00

Hold on:

#70457.blend

Open that file (three channels are selected -- bright white)
Just Ctrl + C then Ctrl + V > all keyframes are pasted
Open the file again (three channels are selected -- bright white)
click-drag box select (starting in the channel Z Location) around X, Y and Z keyframes
notice only the Z Location is highlighted, the other channels become unselected (dimmer, grey)
Ctrl + C then Ctrl + V > only the Z Location keyframes are pasted :(

Hold on: [#70457.blend](https://archive.blender.org/developer/F8277786/T70457.blend) - Open that file (three channels are selected -- bright white) - Just `Ctrl + C` then `Ctrl + V` > all keyframes are pasted - Open the file again (three channels are selected -- bright white) - click-drag box select (starting in the channel `Z Location`) around X, Y and Z keyframes - notice only the `Z Location` is highlighted, the other channels become unselected (dimmer, grey) - `Ctrl + C` then `Ctrl + V` > only the `Z Location` keyframes are pasted :(

Richard Antalik commented

2020-01-14 13:52:40 +01:00

I see now - so if you do box select by clicking on some channel and then dragging, only channel where you clicked on will be copied.

Took me some time even with your steps - Subconciously I try to never start tweak on clickable item.

I see now - so if you do box select by clicking on some channel and then dragging, only channel where you clicked on will be copied. Took me some time even with your steps - Subconciously I try to never start tweak on clickable item.

Philipp Oeser commented

2020-01-14 14:11:50 +01:00

Subconciously I try to never start tweak on clickable item

Point is, if your animation editor is filled with channels, you will always start click-drag-box-selecting on a channel...

> Subconciously I try to never start tweak on clickable item Point is, if your animation editor is filled with channels, you will **always** start click-drag-box-selecting on a channel...

Philipp Oeser commented

2020-01-17 10:08:51 +01:00

Could feedback from @WilliamReynish or @JulianEisel help here?

Richard Antalik was unassigned by Sybren A. Stüvel

2020-01-20 11:17:12 +01:00

Sybren A. Stüvel commented

2020-01-20 11:17:12 +01:00

This is really a UI team issue to triage. From my point of view this is a bug in the box select implementation, but I'm not on the UI team ;-)

Julian Eisel commented

2020-01-28 12:57:54 +01:00

Added subscriber: @mont29

Julian Eisel commented

2020-01-28 12:57:54 +01:00

This relates quite a bit to the discussion in #63994, and the changes I've recently done as followups see #57918.
So this is generally dangerous territory :)

However, I think we can easily fix this.
The issue seems to only be that click-on-empty-space-to-deselect is performed too early. From what I can see this report is entirely addressed by doing that on key release only (if no drag event was recognized). Earlier it would've been tricky to do that, which I guess is why it was done on key press, now it's trivial.

P1231: Potential fix for #70457

diff --git a/source/blender/editors/space_action/action_select.c b/source/blender/editors/space_action/action_select.c
index ca6efb5f69e..09a0c297d35 100644
--- a/source/blender/editors/space_action/action_select.c
+++ b/source/blender/editors/space_action/action_select.c
@@ -1718,7 +1718,7 @@ static int mouse_action_keys(bAnimContext *ac,
     /* reset selection mode for next steps */
     select_mode = SELECT_ADD;
 
-    if (wait_to_deselect_others && is_selected) {
+    if (wait_to_deselect_others) {
       ret_value = OPERATOR_RUNNING_MODAL;
     }
     else {

@brecht, @mont29, @WilliamReynish do you see any issue with always delaying deselecting to the release event for regular mouse-select?

Note that we can/should do the same change to other editors as well. 3D View, File-Browser and Outliner already behave that way.

This relates quite a bit to the discussion in #63994, and the changes I've recently done as followups see #57918. So this is generally dangerous territory :) However, I think we can easily fix this. The issue seems to only be that *click-on-empty-space-to-deselect* is performed too early. From what I can see this report is entirely addressed by doing that on key release only (if no drag event was recognized). Earlier it would've been tricky to do that, which I guess is why it was done on key press, now it's trivial. [P1231: Potential fix for #70457](https://archive.blender.org/developer/P1231.txt) ``` diff --git a/source/blender/editors/space_action/action_select.c b/source/blender/editors/space_action/action_select.c index ca6efb5f69e..09a0c297d35 100644 --- a/source/blender/editors/space_action/action_select.c +++ b/source/blender/editors/space_action/action_select.c @@ -1718,7 +1718,7 @@ static int mouse_action_keys(bAnimContext *ac, /* reset selection mode for next steps */ select_mode = SELECT_ADD; - if (wait_to_deselect_others && is_selected) { + if (wait_to_deselect_others) { ret_value = OPERATOR_RUNNING_MODAL; } else { ``` @brecht, @mont29, @WilliamReynish do you see any issue with always delaying deselecting to the release event for regular mouse-select? *Note that we can/should do the same change to other editors as well. 3D View, File-Browser and Outliner already behave that way.*

Brecht Van Lommel commented

2020-01-28 14:13:15 +01:00

I'm fine with doing this specifically for the dopesheet, but not necessarily everywhere else.

We should avoid click delays whenever possible. I would only make the same change in other places if it solves a specific problem, not for consistency. In the 3D viewport we already have this delay with the box select tool, but not the tweak tool for example.

I'm fine with doing this specifically for the dopesheet, but not necessarily everywhere else. We should avoid click delays whenever possible. I would only make the same change in other places if it solves a specific problem, not for consistency. In the 3D viewport we already have this delay with the box select tool, but not the tweak tool for example.

Sybren A. Stüvel commented

2020-01-28 14:18:56 +01:00

Sounds like a good solution to me.

William Reynish commented

2020-01-29 08:18:00 +01:00

Maybe I don’t understand the issue completely, but I have a hard time seeing how setting it to a click is needed. We don’t have this problem with keyframes or strips - only the channel lists, so I don’t see why we can fix this without the click delay trade off.

Part of the issue, as I see it, is also just that our theme is bad. It’s very very hard to see which channels are selected, which can cause unneeded confusion.

Maybe I don’t understand the issue completely, but I have a hard time seeing how setting it to a click is needed. We don’t have this problem with keyframes or strips - only the channel lists, so I don’t see why we can fix this without the click delay trade off. Part of the issue, as I see it, is also just that our theme is bad. It’s very very hard to see which channels are selected, which can cause unneeded confusion.

Julian Eisel commented

2020-01-29 12:19:48 +01:00

@brecht re other editors - I remember complaints about the current behavior. It becomes especially annoying if you start box selecting (selection changes) and abort. The selection changed even though you aborted the select action. Not a huge issue since you can undo, but together with the consistency argument I'd say it's enough to justify the slight delay. It's not like I had huge issues with keeping the current behavior, but it does feel a bit weak to me.

William Reynish commented

2020-01-29 12:21:49 +01:00

After discussing with @JulianEisel, I agree this seems ok. I thought it would change everything to use CLICK events, but it's just the deselection that will happen on mouseup, which seems fine.

Julian Eisel commented

2020-01-29 12:41:05 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Julian Eisel closed this issue

2020-01-29 12:41:05 +01:00

Julian Eisel self-assigned this 2020-01-29 12:41:05 +01:00

Julian Eisel commented

2020-01-29 12:41:05 +01:00

Should be resolved with 395dfff103.

Should be resolved with 395dfff103.

Philipp Oeser commented

2020-01-29 12:55:43 +01:00

Similar issue in the Sequencer, see #73453 (Sequencer: Selecting playhead deselects all selected strips)

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Dopesheet click-drag-selection deselects channels [e.g. breaking copy-pasting keys workflow] #70457