Known-issues with interaction handling inside pop-ups #73565

New Issue

Julian Eisel · 2020-02-03T15:27:11+01:00

Julian Eisel commented

2020-02-03 15:27:11 +01:00

Known-issues with interaction handling inside pop-ups

Pop-up in this case includes menus and popovers.

There are quite some old and some new issues with pop-ups. Their increased usage after 2.80 means that users run into them more and more.

In this task all related known issues should be listed, to give a good view over the situation. Eventually it should help deciding how to move forward.

Resetting default value does not work in popovers or menus. (#69200)
Context Manual Help Operator does not work in context menus. (#67201)
Add Driver : Clicking the picker doesn't work. (#58341)
Popover: Color Sampling doesn't work. (#63890)
No color drag'n'drop in Viewport Shading popover. (#70654)
Eyedropper does nothing on "New" in Uv image editor (button is disabled as workaround). (#32396)
Most ID selectors (like e.g. the 'target' ones in constraints and modifiers) do not show difference between local and linked IDs. Even worse, they do not allow to select linked ones when a local one exists with the same name. (#73156) (d6cefef98f)
Double-click not working in UI_Lists in popovers (e.g., grease pencil layers renaming) (#66286)
#76833 (Eyedropper in object selection box doesn't work)
#76124 (Cannot use keyframes, File select, File picker (eyedropper), etc. in modal Operators/Panels called by WindowManager)

Most of these issues probably have similar roots (e.g. code not checking if CTX_wm_menu() can be used over CTX_wm_region(), but often times the former returns NULL when it shouldn't).

# Known-issues with interaction handling inside pop-ups *Pop-up in this case includes menus and popovers.* There are quite some old and some new issues with pop-ups. Their increased usage after 2.80 means that users run into them more and more. In this task all related known issues should be listed, to give a good view over the situation. Eventually it should help deciding how to move forward. * Resetting default value does not work in popovers or menus. (#69200) * Context Manual Help Operator does not work in context menus. (#67201) * Add Driver : Clicking the picker doesn't work. (#58341) * Popover: Color Sampling doesn't work. (#63890) * No color drag'n'drop in Viewport Shading popover. (#70654) * Eyedropper does nothing on "New" in Uv image editor (button is disabled as workaround). (#32396) * ~~Most ID selectors (like e.g. the 'target' ones in constraints and modifiers) do not show difference between local and linked IDs. Even worse, they do not allow to select linked ones when a local one exists with the same name. (#73156)~~ (d6cefef98f) * Double-click not working in UI_Lists in popovers (e.g., grease pencil layers renaming) (#66286) * #76833 (Eyedropper in object selection box doesn't work) * #76124 (Cannot use keyframes, File select, File picker (eyedropper), etc. in modal Operators/Panels called by WindowManager) Most of these issues probably have similar roots (e.g. code not checking if `CTX_wm_menu()` can be used over `CTX_wm_region()`, but often times the former returns `NULL` when it shouldn't).

Julian Eisel commented

2020-02-03 15:27:11 +01:00

Added subscriber: @JulianEisel

blender-admin commented

2020-02-03 15:27:11 +01:00

#84636 was marked as duplicate of this issue

blender-admin commented

2020-02-03 15:27:11 +01:00

#78723 was marked as duplicate of this issue

Aaron Carlisle commented

2020-02-17 20:34:14 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Campbell Barton commented

2020-02-21 02:30:06 +01:00

Added subscriber: @ideasman42

Campbell Barton commented

2020-02-21 02:30:06 +01:00

I looked into this yesterday... there is a complication in using CTX_wm_menu, as-is. Which is that you can nest popup menus mixed with popovers.

The complication comes from:

We often want menus to execute in the context that activated them (so an operator should get the menu at the point it was opened, not the menu which is currently open). There are some exceptions to this, when right clicking on a menu item for e.g.
The rules regarding menus/context need to be consistent over multiple areas (poll, operator execution, popover refresh. to name a few).

I tried out always setting CTX_wm_menu, then adding a function to access parent menus when looking for buttons.

While this did work, it sometimes causes popovers to close immediately after dragging a button (see P1267).
Some more time could be spent to make this work, I think it's worth looking into better alternatives.

I looked into this yesterday... there is a complication in using `CTX_wm_menu,` as-is. Which is that you can nest popup menus mixed with popovers. The complication comes from: - We *often* want menus to execute in the context that activated them (so an operator should get the menu at the point it was opened, not the menu which is currently open). There are some exceptions to this, when right clicking on a menu item for e.g. - The rules regarding menus/context need to be consistent over multiple areas (poll, operator execution, popover refresh. to name a few). ---- I tried out always setting `CTX_wm_menu`, then adding a function to access parent menus when looking for buttons. While this did work, it sometimes causes popovers to close immediately after dragging a button (see [P1267](https://archive.blender.org/developer/P1267.txt)). Some more time could be spent to make this work, I think it's worth looking into better alternatives.

Ryan Inch commented

2020-05-12 07:37:20 +02:00

Added subscriber: @Imaginer

Ryan Inch commented

2020-05-12 07:37:20 +02:00

#76635 may be one to include here.

Philipp Oeser commented

2020-07-09 14:20:05 +02:00

Added subscribers: @Bayron-Fernel, @lichtwerk

Fabrício Luis commented

2020-11-12 16:52:01 +01:00

Added subscriber: @ce3po

Fabrício Luis commented

2020-11-12 16:52:01 +01:00

D9395 fix:

#58341: Add Driver : Clicking the picker doesn't work
#76833: Eyedropper in object selection box doesn't work

D9538 fix:

#63890: Popover: Color Sampling doesn't work

D9608 fix:

#69200: Resetting default value does not work in popovers or menus

[D9395](https://archive.blender.org/developer/D9395) fix: - #58341: Add Driver : Clicking the picker doesn't work - #76833: Eyedropper in object selection box doesn't work [D9538](https://archive.blender.org/developer/D9538) fix: - #63890: Popover: Color Sampling doesn't work [D9608](https://archive.blender.org/developer/D9608) fix: - #69200: Resetting default value does not work in popovers or menus

Julian Eisel commented

2021-01-29 02:19:33 +01:00

Added subscribers: @rcorre-3, @rjg

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Known-issues with interaction handling inside pop-ups #73565

Known-issues with interaction handling inside pop-ups