ActionEditor: Add callback function to ANIM_animdata_filter #75127

New Issue

Jeroen Bakker · 2020-03-27T11:44:08+01:00

Jeroen Bakker commented

2020-03-27 11:44:08 +01:00

anim filter is used to filter animation data that the user wants to see or work with.
The current implementation creates a linked list and sometimes uses more temp linked list internally. This list contains a wrapper around the items they want to see.
This is also done during drawing of the action editor.

Current Implementation

Current implementation has a linked list parameter. When traversing the animation data a bAnimListElem is added containing the data.

Target Implementation

Use a callback function and an already allocated bAnimListElem template that can be reused. The callback function can then be used to add it to the requested data structure.
For drawing we could use an array as we need to loop over the items three times. This callback can also break the iteration when it needs to.
Add a default callback that is similar to the current behavior as the function is used many times.

anim filter is used to filter animation data that the user wants to see or work with. The current implementation creates a linked list and sometimes uses more temp linked list internally. This list contains a wrapper around the items they want to see. This is also done during drawing of the action editor. ## Current Implementation * Current implementation has a linked list parameter. When traversing the animation data a `bAnimListElem` is added containing the data. ## Target Implementation * Use a callback function and an already allocated `bAnimListElem` template that can be reused. The callback function can then be used to add it to the requested data structure. * For drawing we could use an array as we need to loop over the items three times. This callback can also break the iteration when it needs to. * Add a default callback that is similar to the current behavior as the function is used many times.

Jeroen Bakker commented

2020-03-27 11:44:08 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jeroen Bakker commented

2020-03-27 11:44:08 +01:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker changed title from ~~Add callback function to ANIM_animdata_filter~~ to ActionEditor: Add callback function to ANIM_animdata_filter

2020-03-27 11:45:43 +01:00

Paul Szajner commented

2020-04-03 03:47:33 +02:00

Added subscriber: @sozap

Hans Goudey commented

2024-03-03 04:34:35 +01:00

I'll close this task, since with the new animation system in the works, performance improvements to the existing one probably aren't relevant anymore.

Hans Goudey closed this issue

2024-03-03 04:34:38 +01:00

Blender Bot added

and removed

labels 2024-03-03 04:34:40 +01:00

Sign in to join this conversation.