Overrides: Can't override Python properties #78534

Closed
opened 2020-07-02 15:10:30 +02:00 by Demeter Dzadik · 10 comments
Member

System Information
Operating system: Linux-5.3.0-7629-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.44

Blender Version
Broken: version: 2.90.0 Alpha, branch: HEAD, commit date: 2020-07-02 12:26, hash: f58f09c9a9

Short description of error
For example, the built-in Bone Selection Sets addon stores some things as python properties:

bpy.types.Object.selection_sets = CollectionProperty(
        type=SelectionSet, ...)
bpy.types.Object.active_selection_set = IntProperty(...)

When linking an armature and making a library override of it, these properties can't be edited and can't be overridden. I tried adding options={'LIBRARY_EDITABLE'} to these property definitions, but it didn't seem to make a difference. I also tried drawing them on the UI directly (as sliders) and storing them in bpy.types.Armature instead of bpy.types.Object, but to no avail.

Exact steps for others to reproduce the error

  • Enable Bone Selection Sets addon
    armature_to_override.blend
  • Link the collection in above file to a new file
  • Make Library Override->Armature
  • See how Selection Sets are grayed out - you can't change the active selection set, and you can't rename any of them.

CC @mont29 Is this supposed to be supported? I couldn't find a todo task, sorry if I'm being blind or dumb.

**System Information** Operating system: Linux-5.3.0-7629-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.44 **Blender Version** Broken: version: 2.90.0 Alpha, branch: HEAD, commit date: 2020-07-02 12:26, hash: `f58f09c9a9` **Short description of error** For example, the built-in Bone Selection Sets addon stores some things as python properties: ``` bpy.types.Object.selection_sets = CollectionProperty( type=SelectionSet, ...) bpy.types.Object.active_selection_set = IntProperty(...) ``` When linking an armature and making a library override of it, these properties can't be edited and can't be overridden. I tried adding `options={'LIBRARY_EDITABLE'}` to these property definitions, but it didn't seem to make a difference. I also tried drawing them on the UI directly (as sliders) and storing them in bpy.types.Armature instead of bpy.types.Object, but to no avail. **Exact steps for others to reproduce the error** - Enable Bone Selection Sets addon [armature_to_override.blend](https://archive.blender.org/developer/F8659714/armature_to_override.blend) - Link the collection in above file to a new file - Make Library Override->Armature - See how Selection Sets are grayed out - you can't change the active selection set, and you can't rename any of them. CC @mont29 Is this supposed to be supported? I couldn't find a todo task, sorry if I'm being blind or dumb.
Author
Member

Added subscribers: @mont29, @Mets

Added subscribers: @mont29, @Mets
Contributor

Added subscriber: @RedMser

Added subscriber: @RedMser

Added subscriber: @mano-wii

Added subscriber: @mano-wii

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'

Well, the tooltip says:

Disabled: Can't edit this property from an override data-block

I'm not familiar with this area, but from what I see, it doesn't look like a bug.
Otherwise the limitation would not be described in the blender itself.
Did I get something wrong?

I suggest using other channels for questions like that: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

For more information on what is considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

Well, the tooltip says: ``` Disabled: Can't edit this property from an override data-block ``` I'm not familiar with this area, but from what I see, it doesn't look like a bug. Otherwise the limitation would not be described in the blender itself. Did I get something wrong? I suggest using other channels for questions like that: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests For more information on what is considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug
Author
Member

I poked Bastien IRL and from what I understood/from what I remember, he said it's supposed to be working, so I think it might be a bug. But it's possible he misunderstood what I was asking about. poke poke @mont29

If this part of library overrides is still work in progress(an so this is not a bug) then ofc feel free to close this. But, this does mean that we had to go back to using proxies still, which makes us all sad! D:

I poked Bastien IRL and from what I understood/from what I remember, he said it's supposed to be working, so I think it might be a bug. But it's possible he misunderstood what I was asking about. *poke poke* @mont29 If this part of library overrides is still work in progress(an so this is not a bug) then ofc feel free to close this. But, this does mean that we had to go back to using proxies still, which makes us all sad! D:

This is more a TODO than really a bug, since it was never implemented. But thanks for the report, easier to keep track of this and not forget about it then. ;)

This is more a TODO than really a bug, since it was never implemented. But thanks for the report, easier to keep track of this and not forget about it then. ;)
See [D8249: Refactor override code to properly deal with runtime rna properties too.](https://archive.blender.org/developer/D8249) and [D8250: Expose override flags to python RNA properties definition.](https://archive.blender.org/developer/D8250)

This issue was referenced by c2304d2f02

This issue was referenced by c2304d2f029cf4610c33c0e9cbf5afe519b770b8

Changed status from 'Needs User Info' to: 'Resolved'

Changed status from 'Needs User Info' to: 'Resolved'
Bastien Montagne self-assigned this 2020-07-10 15:50:53 +02:00
Thomas Dinges added this to the 2.90 milestone 2023-02-08 16:26:17 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#78534
No description provided.