Change Bone Layers fails in Pose Mode #81844

New Issue

Niina Goto · 2020-10-19T13:48:44+02:00

Niina Goto commented

2020-10-19 13:48:44 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: Quadro P620/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.67

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-10-18 20:27, hash: 48c484a22e
Worked: (newest version of Blender that worked as expected)

Short description of error
In Pose Mode, the 2nd change of Change Bone Layers wouldn't be reflected.

The 1st and after the 3rd changes are normally reflected.
This only happens in Pose Mode. It's OK in Edit Mode.
It doesn't happen when changed from on Properties Editor > Object Data Properties > Layers.

Exact steps for others to reproduce the error

Open attached .blend file
Press M in 3dView(shortcut: Change Bone Layers) and Shift + Click twice on the vacant bone layer.
The 2 changes wouldn't be reflected.

bone_layer_not_reflected.blend

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: Quadro [P620](https://archive.blender.org/developer/P620.txt)/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.67 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-10-18 20:27, hash: `48c484a22e` Worked: (newest version of Blender that worked as expected) **Short description of error** In Pose Mode, the 2nd change of Change Bone Layers wouldn't be reflected. - The 1st and after the 3rd changes are normally reflected. - This only happens in Pose Mode. It's OK in Edit Mode. - It doesn't happen when changed from on Properties Editor > Object Data Properties > Layers. **Exact steps for others to reproduce the error** - Open attached .blend file - Press M in 3dView(shortcut: Change Bone Layers) and Shift + Click twice on the vacant bone layer. - The 2 changes wouldn't be reflected. ![bone_layer.jpg](https://archive.blender.org/developer/F9015926/bone_layer.jpg) [bone_layer_not_reflected.blend](https://archive.blender.org/developer/F9015933/bone_layer_not_reflected.blend)

Niina Goto commented

2020-10-19 13:48:44 +02:00

Added subscriber: @Goto_at_StudioQ

Sebastian Parborg commented

2020-10-19 14:11:48 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sebastian Parborg self-assigned this 2020-10-19 14:16:10 +02:00

Sebastian Parborg commented

2020-10-23 17:49:40 +02:00

Ok, this issue doesn't happen with "Undo Legacy" activated (Preferences -> Experimental -> Undo Legacy).

The issue seems to be that when selecting multiple layers, the operator writes the changes to the data block freed by ED_undo_operator_repeat.
I'm guessing this is because it gets the wrong context when rolling back to the initial state with undo.
(So the context stays at the block we rollback from).

This need to be fixed as we should never access freed memory like this. I'm just posting my current finding here.

Ok, this issue doesn't happen with "Undo Legacy" activated (Preferences -> Experimental -> Undo Legacy). The issue seems to be that when selecting multiple layers, the operator writes the changes to the data block freed by `ED_undo_operator_repeat`. I'm guessing this is because it gets the wrong context when rolling back to the initial state with undo. (So the context stays at the block we rollback from). This need to be fixed as we should never access freed memory like this. I'm just posting my current finding here.

blender-admin commented

2020-10-27 15:10:44 +01:00

This issue was referenced by 4975aa410c

This issue was referenced by 4975aa410cf0178fa19a29256659f91d7ea84ccb

Sebastian Parborg commented

2020-10-27 15:14:23 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Sebastian Parborg closed this issue

2020-10-27 15:14:23 +01:00

Thomas Dinges added this to the 2.91 milestone 2023-02-08 16:20:09 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Change Bone Layers fails in Pose Mode #81844