Boolean Modifier is evaluated if an object linked to the cutter object is link-duplicated #84156

New Issue

Matthew Wiebe · 2020-12-26T19:38:47+01:00

Matthew Wiebe commented

2020-12-26 19:38:47 +01:00

System Information
Operating system: Linux-5.4.0-58-generic-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 455.38

Blender Version
Broken: version: 2.91.0, branch: master, commit date: 2020-11-25 08:34, hash: 0f45cab862

Short description of error
Suppose ObjectA has a boolean modifier, the target object of which is CutterA. CutterA shares the same mesh datablock as CutterB. If CutterB is link-duplicated (Alt-D), ObjectA 's boolean modifier is re-evaluated. In large technical scenes with many linked cutters this means Blender frequently stalls, re-evaluating every boolean in the scene every time you duplicate a cutter.

Expected behaviour: boolean modifier should only be evaluated if the cutter object datablocks change, and adding a user to a datablock should not count as a change.

**System Information** Operating system: Linux-5.4.0-58-generic-x86_64-with-debian-bullseye-sid 64 Bits Graphics card: GeForce RTX 3070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 455.38 **Blender Version** Broken: version: 2.91.0, branch: master, commit date: 2020-11-25 08:34, hash: `0f45cab862` **Short description of error** Suppose ObjectA has a boolean modifier, the target object of which is CutterA. CutterA shares the same mesh datablock as CutterB. If CutterB is link-duplicated (Alt-D), ObjectA 's boolean modifier is re-evaluated. In large technical scenes with many linked cutters this means Blender frequently stalls, re-evaluating *every boolean in the scene every time you duplicate a cutter.* Expected behaviour: boolean modifier should only be evaluated if the cutter object datablocks *change*, and adding a user to a datablock should not count as a change.

Matthew Wiebe commented

2020-12-26 19:38:47 +01:00

Added subscriber: @cerebral

Bastien Montagne commented

2021-01-04 16:20:12 +01:00

Added subscribers: @Sergey, @mont29

Bastien Montagne commented

2021-01-04 16:20:12 +01:00

There are several sources for that update:

Some very, very old code in object duplicate operator (duplicate_exec in object_add.c file) would also deg-tag obdata. This was probably needed with old depsgraph, but definitively not with the new one? either mesh remains the same, and there is nothing to tag, or a new one is added, and depsgraph will know by itself it needs to process it.
deg_graph_on_visible_update will 'tag' mesh ID with 0, i.e. LEGACY_0, which it should most likely not use here.

`deg_graph_id_tag_legacy_compat` (which is currently called basically when tagging any ID for update) will currently systematically also tag with `LEGACY_0` the object data, when called for an object.

tagging the mesh for update will then trigger geometry updates of all its object users...

Points 1. and 2. are fairly trivial to address, but point 3. is a bit of a rabbit hole, so would consider this more like a known issue.

Here is a dummy patch fixing all three aspects of the problem - but the 'fix' for 3. breaks even basic things like switching to Edit mode...

P1865: (An Untitled Masterwork)

diff --git a/source/blender/depsgraph/intern/depsgraph_tag.cc b/source/blender/depsgraph/intern/depsgraph_tag.cc
index 95ee8234ef3..97ef7a563c9 100644
--- a/source/blender/depsgraph/intern/depsgraph_tag.cc
+++ b/source/blender/depsgraph/intern/depsgraph_tag.cc
@@ -313,7 +313,7 @@ void deg_graph_id_tag_legacy_compat(
         Object *object = (Object *)id;
         ID *data_id = (ID *)object->data;
         if (data_id != nullptr) {
-          graph_id_tag_update(bmain, depsgraph, data_id, 0, update_source);
+          //          graph_id_tag_update(bmain, depsgraph, data_id, 0, update_source);
         }
         break;
       }
@@ -539,7 +539,10 @@ void deg_graph_on_visible_update(Main *bmain, Depsgraph *graph, const bool do_ti
     if (id_type == ID_OB) {
       flag |= ID_RECALC_TRANSFORM | ID_RECALC_GEOMETRY;
     }
-    graph_id_tag_update(bmain, graph, id_node->id_orig, flag, DEG_UPDATE_SOURCE_VISIBILITY);
+    /* Do not update with LEGACY_0 flag here. */
+    if (flag != 0) {
+      graph_id_tag_update(bmain, graph, id_node->id_orig, flag, DEG_UPDATE_SOURCE_VISIBILITY);
+    }
     if (id_type == ID_SCE) {
       /* Make sure collection properties are up to date. */
       id_node->tag_update(graph, DEG_UPDATE_SOURCE_VISIBILITY);
diff --git a/source/blender/editors/object/object_add.c b/source/blender/editors/object/object_add.c
index 03ff8808423..ce65dab5f1a 100644
--- a/source/blender/editors/object/object_add.c
+++ b/source/blender/editors/object/object_add.c
@@ -3168,10 +3168,6 @@ static int duplicate_exec(bContext *C, wmOperator *op)
     if (BASACT(view_layer) == base) {
       ED_object_base_activate(C, basen);
     }
-
-    if (basen->object->data) {
-      DEG_id_tag_update(basen->object->data, 0);
-    }
   }
   CTX_DATA_END;

CC @Sergey for completeness.

There are several sources for that update: - Some very, very old code in object duplicate operator (`duplicate_exec` in `object_add.c` file) would also deg-tag obdata. This was probably needed with old depsgraph, but definitively not with the new one? either mesh remains the same, and there is nothing to tag, or a new one is added, and depsgraph will know by itself it needs to process it. - `deg_graph_on_visible_update` will 'tag' mesh ID with `0`, i.e. `LEGACY_0`, which it should most likely not use here. # `deg_graph_id_tag_legacy_compat` (which is currently called basically when tagging any ID for update) will currently systematically also tag with `LEGACY_0` the object data, when called for an object. tagging the mesh for update will then trigger geometry updates of all its object users... Points `1.` and `2.` are fairly trivial to address, but point `3.` is a bit of a rabbit hole, so would consider this more like a known issue. Here is a dummy patch fixing all three aspects of the problem - but the 'fix' for `3.` breaks even basic things like switching to Edit mode... [P1865: (An Untitled Masterwork)](https://archive.blender.org/developer/P1865.txt) ``` diff --git a/source/blender/depsgraph/intern/depsgraph_tag.cc b/source/blender/depsgraph/intern/depsgraph_tag.cc index 95ee8234ef3..97ef7a563c9 100644 --- a/source/blender/depsgraph/intern/depsgraph_tag.cc +++ b/source/blender/depsgraph/intern/depsgraph_tag.cc @@ -313,7 +313,7 @@ void deg_graph_id_tag_legacy_compat( Object *object = (Object *)id; ID *data_id = (ID *)object->data; if (data_id != nullptr) { - graph_id_tag_update(bmain, depsgraph, data_id, 0, update_source); + // graph_id_tag_update(bmain, depsgraph, data_id, 0, update_source); } break; } @@ -539,7 +539,10 @@ void deg_graph_on_visible_update(Main *bmain, Depsgraph *graph, const bool do_ti if (id_type == ID_OB) { flag |= ID_RECALC_TRANSFORM | ID_RECALC_GEOMETRY; } - graph_id_tag_update(bmain, graph, id_node->id_orig, flag, DEG_UPDATE_SOURCE_VISIBILITY); + /* Do not update with LEGACY_0 flag here. */ + if (flag != 0) { + graph_id_tag_update(bmain, graph, id_node->id_orig, flag, DEG_UPDATE_SOURCE_VISIBILITY); + } if (id_type == ID_SCE) { /* Make sure collection properties are up to date. */ id_node->tag_update(graph, DEG_UPDATE_SOURCE_VISIBILITY); diff --git a/source/blender/editors/object/object_add.c b/source/blender/editors/object/object_add.c index 03ff8808423..ce65dab5f1a 100644 --- a/source/blender/editors/object/object_add.c +++ b/source/blender/editors/object/object_add.c @@ -3168,10 +3168,6 @@ static int duplicate_exec(bContext *C, wmOperator *op) if (BASACT(view_layer) == base) { ED_object_base_activate(C, basen); } - - if (basen->object->data) { - DEG_id_tag_update(basen->object->data, 0); - } } CTX_DATA_END; ``` CC @Sergey for completeness.

Germano Cavalcante commented

2021-01-06 17:58:47 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Boolean Modifier is evaluated if an object linked to the cutter object is link-duplicated #84156

deg_graph_id_tag_legacy_compat (which is currently called basically when tagging any ID for update) will currently systematically also tag with LEGACY_0 the object data, when called for an object.

`deg_graph_id_tag_legacy_compat` (which is currently called basically when tagging any ID for update) will currently systematically also tag with `LEGACY_0` the object data, when called for an object.