"Allow Execution" reloads the wrong file when recovering auto-saved file #85011

New Issue

Sam Brubaker · 2021-01-24T08:47:28+01:00

Sam Brubaker commented

2021-01-24 08:47:28 +01:00

System Information
Linux 4.4.0-200-lowlatency x86_64

Blender Version
2.91.2 Stable

Short description of error
If an auto-saved file is loaded but untrusted, clicking "Allow Execution" causes Blender to reload the non-autosaved version.

Exact steps for others to reproduce the error

In User Prefs, disable "Auto Run Python Scripts".
Create a .blend file which contains a registered python script
Allow the file to be auto-saved by Blender
Recover the auto-saved file in File > Recover > Auto Save
Upon loading, the "automatic execution of Python scripts in this file was disabled" prompt will appear.
Click "Allow Execution"

This causes Blender drop the auto-saved file and reload the original non-autosaved version of the file!

**System Information** Linux 4.4.0-200-lowlatency x86_64 **Blender Version** 2.91.2 Stable **Short description of error** If an auto-saved file is loaded but untrusted, clicking "Allow Execution" causes Blender to reload the non-autosaved version. **Exact steps for others to reproduce the error** - In User Prefs, disable "Auto Run Python Scripts". - Create a .blend file which contains a registered python script - Allow the file to be auto-saved by Blender - Recover the auto-saved file in File > Recover > Auto Save - Upon loading, the "automatic execution of Python scripts in this file was disabled" prompt will appear. - Click "Allow Execution" # This causes Blender drop the auto-saved file and reload the original non-autosaved version of the file!

Sam Brubaker commented

2021-01-24 08:47:28 +01:00

Added subscriber: @rocketman

Falk David commented

2021-01-25 11:51:47 +01:00

Added subscriber: @filedescriptor

Falk David commented

2021-01-25 11:51:47 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Falk David self-assigned this 2021-01-25 11:51:47 +01:00

Falk David commented

2021-01-25 11:51:47 +01:00

I can confirm this issue on the latest master. Will investigate.

Falk David commented

2021-01-25 14:36:06 +01:00

Added subscriber: @mont29

Falk David commented

2021-01-25 14:36:06 +01:00

I know why this is happening now, but not sure how to solve it.

Clicking the "Allow Execution" button will call wm_block_autorun_warning_reload_with_scripts which then will call the WM_OT_revert_mainfile operator with the use_scripts property set to true. So it just reloads the file and allows all scripts to execute. The problem is that WM_OT_revert_mainfile uses BKE_main_blendfile_path(bmain) to get the filename. The autosave saves to a specific filename (see wm_autosave_location) but does not update the bmain->name. So when the autosave is reloaded it loads the wrong file.
In fact the exact same problem can be caused by just loading an autosave via File>Recover>Auto Save... and then trying to reload the file with File>Revert.
This also means that if the original file does no longer exist, the operator will fail.

@mont29 Do you know how we could fix this?

I know why this is happening now, but not sure how to solve it. Clicking the "Allow Execution" button will call `wm_block_autorun_warning_reload_with_scripts` which then will call the `WM_OT_revert_mainfile` operator with the `use_scripts` property set to `true`. So it just reloads the file and allows all scripts to execute. The problem is that `WM_OT_revert_mainfile` uses `BKE_main_blendfile_path(bmain)` to get the filename. The autosave saves to a specific filename (see `wm_autosave_location`) but does not update the `bmain->name`. So when the autosave is reloaded it loads the wrong file. In fact the exact same problem can be caused by just loading an autosave via *File*>*Recover*>*Auto Save...* and then trying to reload the file with *File*>*Revert*. This also means that if the original file does no longer exist, the operator will fail. @mont29 Do you know how we could fix this?

Falk David removed their assignment 2021-01-25 14:36:51 +01:00

Bastien Montagne commented

2021-01-25 14:44:12 +01:00

Added subscriber: @ideasman42

Bastien Montagne commented

2021-01-25 14:44:12 +01:00

Not sure, but iirc @ideasman42 was the main dev working on this area? Would be interested to get his input here.

I guess we could forbid allow execution on files that where recovered from auto-save, until they are properly saved back into a regular file? Storing the state that we are currently in 'unsaved auto-saved recovered' status. Or modify revert_mainfile to deal with that specific case?

But I would rather not consider auto-saved recovered files as normal situation, and just prevent reloading those at all?

Not sure, but iirc @ideasman42 was the main dev working on this area? Would be interested to get his input here. I guess we could forbid `allow execution` on files that where recovered from auto-save, until they are properly saved back into a regular file? Storing the state that we are currently in 'unsaved auto-saved recovered' status. Or modify `revert_mainfile` to deal with that specific case? But I would rather not consider auto-saved recovered files as normal situation, and just prevent reloading those at all?

Campbell Barton self-assigned this 2021-01-26 00:59:34 +01:00

blender-admin commented

2021-01-26 03:21:13 +01:00

This issue was referenced by 7909f70f64

This issue was referenced by 7909f70f64e550633fd381b0875fc5ba21616187

blender-admin commented

2021-01-26 05:08:28 +01:00

This issue was referenced by d55d95b04d

This issue was referenced by d55d95b04da42f120406678fc47deb00081f7285

Campbell Barton commented

2021-01-26 05:17:17 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2021-01-26 05:17:17 +01:00

Campbell Barton commented

2021-01-26 10:23:09 +01:00

Changed status from 'Resolved' to: 'Confirmed'

Campbell Barton reopened this issue

2021-01-26 10:23:09 +01:00

Campbell Barton commented

2021-01-26 10:23:09 +01:00

(auto-closed when it shouldn't have).

Campbell Barton commented

2021-01-26 10:34:38 +01:00

While this is more related to the newer dialogs, I've written two fixes, but I'm not so happy with either of them.

P1914 - holds the action needed to revert, in case it's needed. Currently it's not freed until the window-manager is freed, which isn't so nice (although in practice it's not a much memory).
P1915 - uses the operator storage to check how the file was loaded, although it requires those operators to be registered.

I think a better approach would be to extend on P1914, replacing wm_test_autorun_warning with a more generic dynamic callback that runs at the end of the event loop (and removes it's self when no longer needed). Although it seems like overkill for this one-off case.

While this is more related to the newer dialogs, I've written two fixes, but I'm not so happy with either of them. - [P1914](https://archive.blender.org/developer/P1914.txt) - holds the action needed to revert, in case it's needed. Currently it's not freed until the window-manager is freed, which isn't so nice (although in practice it's not a much memory). - [P1915](https://archive.blender.org/developer/P1915.txt) - uses the operator storage to check how the file was loaded, although it requires those operators to be registered. I think a better approach would be to extend on [P1914](https://archive.blender.org/developer/P1914.txt), replacing `wm_test_autorun_warning` with a more generic dynamic callback that runs at the end of the event loop (and removes it's self when no longer needed). Although it seems like overkill for this one-off case.

blender-admin commented

2021-01-26 11:56:49 +01:00

This issue was referenced by 548d8a397c

This issue was referenced by 548d8a397c39f43459af404170614db6a18ebde1

Campbell Barton commented

2021-01-26 12:03:57 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2021-01-26 12:03:57 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

"Allow Execution" reloads the wrong file when recovering auto-saved file #85011

This causes Blender drop the auto-saved file and reload the original non-autosaved version of the file!