Crash undoing in certain scenario (disabling Global Undo) #86015

New Issue

Philipp Oeser · 2021-02-26T14:19:02+01:00

Philipp Oeser commented

2021-02-26 14:19:02 +01:00

System Information
Operating system: Linux-5.10.12-200.fc33.x86_64-x86_64-with-glibc2.32 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 455.45.01

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-02-25 23:27, hash: b1b9671c93
Worked: 2.82a

Short description of error
Crash undoing in certain scenario (disabling Global Undo)

Exact steps for others to reproduce the error
From the default startup file (order of operations is important here):

move the cube (could be any objectmode operator) {key G Z 3}
disable Global Undo in Preferences {key F4} > Preferences > System > uncheck Global Undo
add an armature {key Shift A} > Armature
go to pose mode
select bone
move bone
Undo {key Ctrl Z}
- crash

1   BKE_scene_object_base_flag_sync_from_base scene.c           2914 0x35b41a9 
2   BKE_scene_set_background                  scene.c           2125 0x35b2957 
3   setup_app_data                            blendfile.c       386  0x4b63950 
4   setup_app_blend_file_data                 blendfile.c       416  0x4b639e4 
5   BKE_blendfile_read_from_memfile           blendfile.c       524  0x4b63e38 
6   BKE_memfile_undo_decode                   blender_undo.c    88   0x4b62cc0 
7   memfile_undosys_step_decode               memfile_undo.c    193  0x486eb47 
8   undosys_step_decode                       undo_system.c     214  0x4bb97ec 
9   BKE_undosys_step_load_data_ex             undo_system.c     809  0x4bbb2df 
10  BKE_undosys_step_undo_with_data_ex        undo_system.c     870  0x4bbb4a4 
11  BKE_undosys_step_undo_with_data           undo_system.c     880  0x4bbb4d3 
12  BKE_undosys_step_undo                     undo_system.c     889  0x4bbb511 
13  ed_undo_step_direction                    ed_undo.c         278  0x486c907 
14  ed_undo_exec                              ed_undo.c         489  0x486d214 
15  wm_operator_invoke                        wm_event_system.c 1332 0x3a17b06 
16  wm_handler_operator_call                  wm_event_system.c 2161 0x3a198e3 
17  wm_handlers_do_keymap_with_keymap_handler wm_event_system.c 2486 0x3a1a617 
18  wm_handlers_do_intern                     wm_event_system.c 2782 0x3a1b591 
19  wm_handlers_do                            wm_event_system.c 2914 0x3a1bafc 
20  wm_event_do_handlers                      wm_event_system.c 3445 0x3a1d2a3

**System Information** Operating system: Linux-5.10.12-200.fc33.x86_64-x86_64-with-glibc2.32 64 Bits Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 455.45.01 **Blender Version** Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-02-25 23:27, hash: `b1b9671c93` Worked: 2.82a **Short description of error** Crash undoing in certain scenario (disabling Global Undo) **Exact steps for others to reproduce the error** From the default startup file (order of operations is important here): - move the cube (could be any objectmode operator) {key G Z 3} - disable `Global Undo` in Preferences {key F4} > `Preferences` > `System` > uncheck `Global Undo` - add an armature {key Shift A} > `Armature` - go to pose mode - select bone - move bone - Undo {key Ctrl Z} - > crash ``` 1 BKE_scene_object_base_flag_sync_from_base scene.c 2914 0x35b41a9 2 BKE_scene_set_background scene.c 2125 0x35b2957 3 setup_app_data blendfile.c 386 0x4b63950 4 setup_app_blend_file_data blendfile.c 416 0x4b639e4 5 BKE_blendfile_read_from_memfile blendfile.c 524 0x4b63e38 6 BKE_memfile_undo_decode blender_undo.c 88 0x4b62cc0 7 memfile_undosys_step_decode memfile_undo.c 193 0x486eb47 8 undosys_step_decode undo_system.c 214 0x4bb97ec 9 BKE_undosys_step_load_data_ex undo_system.c 809 0x4bbb2df 10 BKE_undosys_step_undo_with_data_ex undo_system.c 870 0x4bbb4a4 11 BKE_undosys_step_undo_with_data undo_system.c 880 0x4bbb4d3 12 BKE_undosys_step_undo undo_system.c 889 0x4bbb511 13 ed_undo_step_direction ed_undo.c 278 0x486c907 14 ed_undo_exec ed_undo.c 489 0x486d214 15 wm_operator_invoke wm_event_system.c 1332 0x3a17b06 16 wm_handler_operator_call wm_event_system.c 2161 0x3a198e3 17 wm_handlers_do_keymap_with_keymap_handler wm_event_system.c 2486 0x3a1a617 18 wm_handlers_do_intern wm_event_system.c 2782 0x3a1b591 19 wm_handlers_do wm_event_system.c 2914 0x3a1bafc 20 wm_event_do_handlers wm_event_system.c 3445 0x3a1d2a3 ``` ``` ```

Philipp Oeser commented

2021-02-26 14:19:02 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-02-26 14:19:16 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Bastien Montagne commented

2021-03-01 11:26:59 +01:00

Added subscribers: @ideasman42, @mont29

Bastien Montagne commented

2021-03-01 11:26:59 +01:00

Would like to get input from @ideasman42 here, but imho when this setting is disabled we should immediately nuke the whole undo stack?

Also find it weird that we still allow Edit mode undos then when Global Undo is disabled? Since the stack is unified nowadays, this can lead to quiet a broken stage of undo stack... Not to mention that Pose mode undo is also using global undo.

For now I will go with the simple workaround of disabling new undo system when Global Undo is disabled, but this won't fix all the issues by far.

Would like to get input from @ideasman42 here, but imho when this setting is disabled we should immediately nuke the whole undo stack? Also find it weird that we still allow Edit mode undos then when Global Undo is disabled? Since the stack is unified nowadays, this can lead to quiet a broken stage of undo stack... Not to mention that Pose mode undo is also using global undo. For now I will go with the simple workaround of disabling new undo system when Global Undo is disabled, but this won't fix all the issues by far.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash undoing in certain scenario (disabling Global Undo) #86015